• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
OmniRa

glGetUniformLocation Failing on uniform

3 posts in this topic

Hi, i have this fragment shader and glGetUniformLocation is returning -1 for a few entries. one of which is "camera_position".

Im not sure why this is happening, it's working for other variables like "num_directional_lights" & "num_point_lights". Is there any reason it would fail for that particular one. The shader doesn't appear to have an compilation errors.

 

This is the fragment shader:

//
// version
//
#version 330

//
// constants
//
const int NAX_DIRECTIONAL_LIGHTS = 2;
const int MAX_POINT_LIGHTS =       2;
const int MAX_SPOT_LIGHTS =        2;

//
// structs
//
struct DIRECTIONAL_LIGHT
{
	vec3  colour;
	float ambientIntensity;
	float diffuseIntensity;
	vec3  direction;
};

struct POINT_LIGHT
{
	vec3  colour;
	float ambientIntensity;
	float diffuseIntensity;
	float constantAttenuation;
	float linearAttenuation;
	float exponetialAttenuation;
};

struct SPOT_LIGHT
{
	vec3  colour;
	float ambientIntensity;
	float diffuseIntensity;
	float constantAttenuation;
	float linearAttenuation;
	float exponetialAttenuation;
	vec3  direction;
	float cutoff;
};

//
// uniforms
//
uniform vec3              camera_position;
uniform sampler2D         texture0;
uniform int               num_directional_lights;
uniform int               num_point_lights;
uniform int               num_spot_lights;
uniform DIRECTIONAL_LIGHT directional_light [NAX_DIRECTIONAL_LIGHTS];
uniform POINT_LIGHT       point_light       [MAX_POINT_LIGHTS];
uniform SPOT_LIGHT        spot_light        [MAX_SPOT_LIGHTS];

//
// in attributes
//
in vec4 frag_colour;
in vec2 frag_texCoord0;
in vec3 frag_normal;
in vec3 frag_worldPos;

//
// out attributes
//
out vec4 out_colour;

//
// functions
//
vec4 CalculateDirectionalLight(void)
{
	vec4 totalLight = vec4(0, 0, 0, 0);

	// temp
	// ====
	float specularIntensity = 0.0;
	float specularPower =     0.0;
	// ====

	for (int i = 0; i < num_directional_lights; ++i)
	{
		vec4  ambientColour =  vec4(directional_light[i].colour, 1.0) * directional_light[i].ambientIntensity;
		float diffuseFactor =  dot(frag_normal, -directional_light[i].direction);
		vec4  diffuseColour =  vec4(0, 0, 0, 0);
		vec4  specularColour = vec4(0, 0, 0, 0);

		if (diffuseFactor > 0.0)
		{
			vec3  toEye =          normalize(camera_position - frag_worldPos);
			vec3  lightReflect =   normalize(reflect(directional_light[i].direction, frag_normal));
			float specularFactor = pow(dot(toEye, lightReflect), specularPower);

			if (specularFactor > 0.0)
				specularColour = vec4(directional_light[i].colour, 1.0) * specularIntensity * specularFactor;
		}

		totalLight += (ambientColour + diffuseColour + specularColour);
	}

	return totalLight;
}

vec4 CalculatePointLight(void)
{
	vec4 totalLight = vec4(0, 0, 0, 0);

	for (int i = 0; i < num_point_lights; ++i)
	{
		// ...
		// TODO
	}

	return totalLight;
}

vec4 CalculateSpotLight(void)
{
	vec4 totalLight = vec4(0, 0, 0, 0);

	for (int i = 0; i < num_spot_lights; ++i)
	{
		// ...
		// TODO
	}

	return totalLight;
}

//
// entry
//
void main(void)
{
	vec4 totalLight = CalculateDirectionalLight();
	totalLight +=     CalculatePointLight();
	totalLight +=     CalculateSpotLight();

	out_colour = texture(texture0, frag_texCoord0.st) * frag_colour * totalLight;
}

Will conintue looking myself, but time for bed :( TY for any help

0

Share this post


Link to post
Share on other sites

It's worth noting that you're allowed to pass a uniform location of -1 into the glUniform* functions, so in practice you don't really have to worry about whether the uniform exists or not. Just pass the location you got in and all will be well.

1

Share this post


Link to post
Share on other sites

Thankyou smile.png

 

I thought the optimizer would just remove variables that didn't get referenced in the code, I didn't realise it was that good at removing unused things!

I changed some variables to make sure they have influence on the result and it works now.

 

Ty

Edited by OmniRa
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0