Hi

this seem to be the trouble:

if (rainP <= 0.3 || temperatureC < 0 || cloudAlt <= altibaro){
alSourceStop(Sources[0]);
}else{
alSourcePlay(Sources[0]);
}

I want to stop the sound if either rain is less 0.3 or temp below zero or cloud altitude is below.

But the sound keeps playing even if temp is below zero. Am I doing something wrong and

how to write the above?

Thanks

bool b1 = rainP <= 0.3;
bool b2 = temperatureC < 0;
bool b3 = cloudAlt <= altibaro;
bool b = b1 || b2 || b3;

Check your values like Buckeye and unbird suggests, also Wooh is hinting at something here:

Why don't you make a flag, a boolean telling if the sound is playing or not, and track state changes rather than be calling playsound or stopsound on every iteration?

That should actually work (with the operator precedence there should be no confusion, so no brackets needed).

There must be something else off (maybe the sound switch off?). Go through with your debugger and inspect those values.

As a general hint: If you don't know/trust what's going on, declare a couple of temporary variables (or even functions), and inspect those, e.g:

bool b1 = rainP <= 0.3;
bool b2 = temperatureC < 0;
bool b3 = cloudAlt <= altibaro;
bool b = b1 || b2 || b3;

Edit: Thinking about it, using parentheses explicitly (even if not needed) isn't that bad. Not only for readability.

Edit2: @Buckeye: Question now is rather who has ninja'd whom ?

This is a fantastic idea. In fact, const bools are often used in UE4 for readability purposes. Variables and constants may be self-documenting by themselves, but you can take it a step further as in the below example. For example:

// Before:
if (someDescriptiveVariable < someDescriptiveNumber) {
    // Do stuff
}

// After:
const bool bSomeDescriptiveBool = (someDescriptiveVariable < someDescriptiveNumber);
if (bSomeDescriptiveBool) {
    // Do stuff
}

It may seem unnecessary to some, but let me tell you that it makes for very clean and self-documenting code that other people (not just yourself) can read. I also agree that expressions are generally cleaner when they're surrounded by parentheses.

As for the actual topic, the best thing to do here (as previously mentioned) is to display the values in one way or another.

It should be noted that performing your comparisons using multiple Boolean variables means that you cannot take advantage of short-circuit evaluation.

Thanks. || was ok but a displaced clamp. Below seems fine:

if(state != AL_PLAYING)
{
SourcesPos[0][0] = 0.0;
SourcesPos[0][1] = 0.0;
SourcesPos[0][2] = 0.0;

alSourcefv(Sources[0], AL_POSITION, SourcesPos[0]);
}
if (rainP <= 0.3 || temperatureC < 0 || cloudAlt <= altibaro){
alSourceStop(Sources[0]);
}else if(state != AL_PLAYING){
alSourcePlay(Sources[0]);
}