• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Rick281

Is this memory leakage?

5 posts in this topic

So I am wondering if what I did here is something that is bad or if the java garbage collector will take care of it on its own. I have two different methods below and I have taken out all irrelevant code to simplify things. I create a scanner in each method. Usually I would close the scanners to get rid of the memory leak warning, however, when I close the first scanner, I was unable to use the second. I found a solution that said just don't close the scanners and it works fine, but I am wondering if this is dangerous to do. Thanks in advance!

static String menu(){
 
String menuoption;
Scanner menuscanner = new Scanner(System.in);
 
menuoption = menuscanner.next();
 
return menuoption;
 
}// end of menu method
 
 
static void info(){
 
Scanner infoscanner = new Scanner(System.in);
 
infoscanner.next();
 
}//end of info method
 
0

Share this post


Link to post
Share on other sites
Another approach would be to create the scanner in main(), and pass it to these methods. Alternatively, the scanner could be a field on the class where these methods are, and they could be made non-static.
0

Share this post


Link to post
Share on other sites

Best practice would be to re-use the same scanner instance. If the menu() and info() method must remain static then you can do something like this:
 

private static final Scanner scanner = new Scanner(System.in);

//You should specify either if the method is public or private. 
private static String menu(){
   String menuoption = scanner.next();
 
   //Do some stuff...

   return menuoption;
}
 


//You should specify either if the method is public or private.
private static void info(){
   String info = scanner.next();

   //Do some stuff... 
}
Edited by PsychotikRabbit
0

Share this post


Link to post
Share on other sites

I believe this usage of the Scanner class is a resource leak.

You should be calling close() on the scanner reference after each use (unless ideally your architecture is such that you can use a single reference and pass it around). This should only clean up the scanner instance but leave stdin untouched for future use.

 

If you have an Exception thrown (or you return) between where you have instantiated scanner and when you call close() then you have a leak. So you will probably want to add a bunch of try catch finallys around your code (inside the finally you have the close() call).

 

C++ deals with this (and memory leaks) in a much more elegant fashion with RAII, C# has the "using" pattern (which unfortunately only works in function scope) but with Java you unfortunately need to fall back to the try catch stuff.

 

Unless you are happy for your code to not be exception safe (which is likely to not really be a problem for many games), in which case just remember to call close().

Edited by Karsten_
0

Share this post


Link to post
Share on other sites

Yes you are right you need to call close.

Another approach:
 

public class InputManager {
   private final Scanner scanner;

   public InputManager() {
      scanner = new Scanner(System.in);
   }

   //This should be called when you don't want to read input anymore.
   public void shutdown() {
      scanner.close();
   }

   public String menu(){
      String menuoption = scanner.next();
 
      //Do some stuff...

      return menuoption;
   }
 
   public void info(){
      String info = scanner.next();

      //Do some stuff... 
   }
}

You could then use your class like this:
 

public static void main(String[] args) {
   InputManager inputManager = new InputManager();

   //Do whatever you want with the user input.
   String option = inputManager.menu();
   System.out.println("Option: " + option);

   //Before exiting the application you free resources
   inputManager.shutdown();
}
Edited by PsychotikRabbit
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0