• Advertisement
Sign in to follow this  

OpenGL Opengl Multiple renderings, how to improve performance?

This topic is 1288 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello everybody I am working on an application that needs to render the scene from multiple points of view. I notice that if I render once, even if the frag shader is long and complicated (writing to multiple 3D textures) it runs at 65 FPS. As soon as I add another rendering pass before that (simply rendering to 2 targets, colour and normals+depth) the framerate drops to 40. If I add a shadowmap pass it drops even further to 25-30 FPS. What is the best way to cope with multiple renderings and still retain a high framerate?

 

This is what I have right now:

1 - a shader that computes the normal+depth and colors, 2 targets on the same FBO

2 - the same shader gets called again for the shadowmap (different uniform parameters) but renders to a different FBO target

3 - a shader that writes values on a 3D texture using imageStore, new FBO

4 - a last shader that performs ray marching through the 3D texture and, at the same time, reads from the 2 maps created before

if i just run step 3 and 4 i get 65 FPS, if i add the 2 steps above the performance drops and the only explanation I have is that I am doing something useless in the middle cause the shaders in 3 and 4 are way more complicated (1000+ lines)

Thank you 

Share this post


Link to post
Share on other sites
Advertisement

It's not strange that a severely un-optimized shader of 20 lines will get outperformed by a severely optimized shader of 100 lines (so to speak that is). Add the fact that you're using the same shader multiple times to render multiple viewpoints and your performance will go down the drain.

 

With that being said, we have no clue what your shaders look like so we can't really comment on anything if you're doing something wrong or not. It might be in the shaders, it might be in the way you are using the FBO, it might be something totally unrelated to either!

 

I'd suggest using a profiler to see where your bottleneck is, (double) check your shaders (1000+ lines for a single shader seems like a lot, but I don't know what you're aiming for) and check your code for silly mistakes.

 

But if you want help, post some code along with an explanation of what you're trying to achieve and I'm sure these lovely people are able to help you out!

Edited by Rld_

Share this post


Link to post
Share on other sites

I have Nsights installed in VS 13, would it work as a profiler for glsl? Btw the big shader is fine cause everything runs fast when i run it alone. The other one is slowing things down, Also, I have 5 FBOs with a total of 6 targets, maybe this is one of the things that is slowing down everything

Share this post


Link to post
Share on other sites

I never used Nsights before, but it seems like an option to rule some things out, but I'm not sure if it enables you to profile your shaders. A quick google already showed some options for you that might do the trick a bit better specifically for shaders.

Share this post


Link to post
Share on other sites

So I started doing some debugging with Nsight and I took a look at the events. This is what I saw:

 

I have numerous calls like this 

void glBindTexture(GLenum target = GL_TEXTURE_2D, GLuint texture = 15)	0x00010000	1539	0
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 1188, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 000354FC, GLint basevertex = 38051)	0x00010000	21038	22504
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003678C, GLint basevertex = 38847)	0x00010000	17446	15872
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 000373D4, GLint basevertex = 39373)	0x00010000	16933	15292
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003801C, GLint basevertex = 39899)	0x00010000	21552	14868
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 00038C64, GLint basevertex = 40425)	0x00010000	17960	14080
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 1188, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 000398AC, GLint basevertex = 40951)	0x00010000	16933	21740
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 1188, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003AB3C, GLint basevertex = 41747)	0x00010000	16420	21856
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003BDCC, GLint basevertex = 42543)	0x00010000	16933	15432
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003CA14, GLint basevertex = 43069)	0x00010000	16933	15448
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003D65C, GLint basevertex = 43595)	0x00010000	16420	14704
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 786, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003E2A4, GLint basevertex = 44121)	0x00010000	16933	13788
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 1188, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0003EEEC, GLint basevertex = 44647)	0x00010000	16420	21668

and I guess I could turn those draw calls into a single call.

I then noticed this other thing:

void glBindTexture(GLenum target = GL_TEXTURE_2D, GLuint texture = 10)	0x00010000	1539	0
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 612, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0004017C, GLint basevertex = 45443)	0x00010000	21038	30748
void glBindTexture(GLenum target = GL_TEXTURE_2D, GLuint texture = 12)	0x00010000	1026	0
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 612, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 00040B0C, GLint basevertex = 45959)	0x00010000	20525	28388
void glBindTexture(GLenum target = GL_TEXTURE_2D, GLuint texture = 10)	0x00010000	1026	0
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 444, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0004149C, GLint basevertex = 46475)	0x00010000	20525	55416
void glBindTexture(GLenum target = GL_TEXTURE_2D, GLuint texture = 11)	0x00010000	1026	0
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 480, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 00041B8C, GLint basevertex = 46797)	0x00010000	20525	13716
void glBindTexture(GLenum target = GL_TEXTURE_2D, GLuint texture = 12)	0x00010000	1026	0
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 336, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0004230C, GLint basevertex = 47117)	0x00010000	20525	10060
void glBindTexture(GLenum target = GL_TEXTURE_2D, GLuint texture = 11)	0x00010000	1026	0
void glDrawElementsBaseVertex(GLenum mode = GL_TRIANGLES, GLsizei count = 480, GLenum type = GL_UNSIGNED_INT, GLvoid* indices = 0004284C, GLint basevertex = 47349)	0x00010000	20525	11676

Now in this one as you can notice I keep binding to the same 3 textures back and forth. Would it make sense to sort my elements based on texture object when I load the model, so that I can bind one texture and make all the draw calls and then go to the next?

Share this post


Link to post
Share on other sites

I'm not sure how expensive texture binding is, but it will probably increase performance by some if you keep it all together. Constantly (re)binding shaders is a costly thing, so you probably do want to have that sorted out.

 

Having less draw calls might also help.

 

You might also benefit from timing your instructions, see if something is taking up more time than it should. Most, if not all, profilers have an option to see your highest bottlenecks, but you can also time specific functions yourself if you want that.

Share this post


Link to post
Share on other sites

I notice that if I render once, even if the frag shader is long and complicated (writing to multiple 3D textures) it runs at 65 FPS1. As soon as I add another rendering pass before that (simply rendering to 2 targets, colour and normals+depth) the framerate drops to 40 FPS2. If I add a shadowmap pass it drops even further to 25-30 FPS3

That's 1=15.4ms, 2=25ms, 3=40 to 33ms per frame maximum from the CPU and GPU.

So your original pass is 15.4ms, your added pass is (25-15.4=) 9.6ms, and your shadowmap pass is (33-25= / 40-25=) 8ms to 15 ms.
 
Those all sound like feasible numbers... I don't know why you expect to be able to do more work without spending more milliseconds of GPU time wink.png tongue.png
 
You can use gl_ext_timer_query to measure how long different passes are taking on the GPU. e.g. insert a query before/after your shadowmap pass, and then next frame, retrieve the results of the query to find out what the duration of those commands on the GPU actually was.

Share this post


Link to post
Share on other sites

Actually I turned off vsync so that I get the actual FPS. So these are the actual results (voxelization is the expensive shader)

 

voxelization alone: 94 FPS

 

normal+depth and color pass alone: 240 FPS (I could improve this by using a g-buffer instead of 2 textures)

 

shadowmap alone: 135 FPS

 

normal+depth+color & shadowmap: 160 FPS (those 2 passes use the same shader)

 

second pass + shadowmap + voxelisation (in this order) : 67 FPS

 

The weird thing is that if I run the shadowmap pass alone it's slower than if i run it after th other pass, so it means that I am probabily wasting something. 

I will go on and try to optimize the voxelisation part. It's the cyril crassin method of rendering everything while using the geometry shader to project to the dominant axis and use the fragment shader to write to a 3d texture. Right now I am writing to the 3d Tex by using imageStore even though that doesn't seem the bottleneck of the shader.

 

If I use gl_ext_timer_query i get those results

 

normal+depth & color : 10,336,416 ns

shadowmap: 5,412,064 ns

voxelise: 55,344,416 ns

which should run at 14 fps...

 

all I did was

glBeginQuery(GL_TIME_ELAPSED_EXT, queries[0]);
firstPass();
glEndQuery(GL_TIME_ELAPSED_EXT);
glBeginQuery(GL_TIME_ELAPSED_EXT, queries[1]);
ShadowMapPass();
glEndQuery(GL_TIME_ELAPSED_EXT);
glDisable(GL_DEPTH_TEST);
glDisable(GL_CULL_FACE);
glBeginQuery(GL_TIME_ELAPSED_EXT, queries[2]);
Voxelize(false);
glEndQuery(GL_TIME_ELAPSED_EXT);

while (!available) {
	glGetQueryObjectiv(queries[4 - 1], GL_QUERY_RESULT_AVAILABLE, &available);
}
for (int i = 0; i < 3; i++) {
  // See how much time the rendering of object i took in nanoseconds.
  glGetQueryObjectui64vEXT(queries[i], GL_QUERY_RESULT, &timeElapsed);
}

I assure that the fps count above is correct because it is the same one that is displayed by NSight

Share this post


Link to post
Share on other sites

As demonstrated by Hodgman above: Using a non-linear measure like FPS (which is in fact reciprocal) is meaningless for quantitative assessment of relative performance. 

 

However, in your query code, IMHO this line

glGetQueryObjectiv(queries[4 - 1], GL_QUERY_RESULT_AVAILABLE, &available);

should read so

glGetQueryObjectiv(queries[3 - 1], GL_QUERY_RESULT_AVAILABLE, &available);

because you want to wait for queries[2] to be ready, not for (the not existing) queries[3].

Edited by haegarr

Share this post


Link to post
Share on other sites

I also tried this: i put a glFinish() at the end so that all the commands in the queue would be executed at that point. This is what shows up in the debugger

 

1 void glFinish() 0x00010000 1772914 0
2 void glClear(GLbitfield mask = GL_DEPTH_BUFFER_BIT) 0x00010000 7749507 0

 

glClear is taking 7 ms of CPU time?

 

If i run other stuff before it it takes even 12ms. Also I have 2 more glClear and they both take this long. Is this normal?

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Now

  • Advertisement
  • Similar Content

    • By Balma Alparisi
      i got error 1282 in my code.
      sf::ContextSettings settings; settings.majorVersion = 4; settings.minorVersion = 5; settings.attributeFlags = settings.Core; sf::Window window; window.create(sf::VideoMode(1600, 900), "Texture Unit Rectangle", sf::Style::Close, settings); window.setActive(true); window.setVerticalSyncEnabled(true); glewInit(); GLuint shaderProgram = createShaderProgram("FX/Rectangle.vss", "FX/Rectangle.fss"); float vertex[] = { -0.5f,0.5f,0.0f, 0.0f,0.0f, -0.5f,-0.5f,0.0f, 0.0f,1.0f, 0.5f,0.5f,0.0f, 1.0f,0.0f, 0.5,-0.5f,0.0f, 1.0f,1.0f, }; GLuint indices[] = { 0,1,2, 1,2,3, }; GLuint vao; glGenVertexArrays(1, &vao); glBindVertexArray(vao); GLuint vbo; glGenBuffers(1, &vbo); glBindBuffer(GL_ARRAY_BUFFER, vbo); glBufferData(GL_ARRAY_BUFFER, sizeof(vertex), vertex, GL_STATIC_DRAW); GLuint ebo; glGenBuffers(1, &ebo); glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, ebo); glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof(indices), indices,GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, false, sizeof(float) * 5, (void*)0); glEnableVertexAttribArray(0); glVertexAttribPointer(1, 2, GL_FLOAT, false, sizeof(float) * 5, (void*)(sizeof(float) * 3)); glEnableVertexAttribArray(1); GLuint texture[2]; glGenTextures(2, texture); glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageOne = new sf::Image; bool isImageOneLoaded = imageOne->loadFromFile("Texture/container.jpg"); if (isImageOneLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageOne->getSize().x, imageOne->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageOne->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageOne; glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageTwo = new sf::Image; bool isImageTwoLoaded = imageTwo->loadFromFile("Texture/awesomeface.png"); if (isImageTwoLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageTwo->getSize().x, imageTwo->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageTwo->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageTwo; glUniform1i(glGetUniformLocation(shaderProgram, "inTextureOne"), 0); glUniform1i(glGetUniformLocation(shaderProgram, "inTextureTwo"), 1); GLenum error = glGetError(); std::cout << error << std::endl; sf::Event event; bool isRunning = true; while (isRunning) { while (window.pollEvent(event)) { if (event.type == event.Closed) { isRunning = false; } } glClear(GL_COLOR_BUFFER_BIT); if (isImageOneLoaded && isImageTwoLoaded) { glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glUseProgram(shaderProgram); } glBindVertexArray(vao); glDrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_INT, nullptr); glBindVertexArray(0); window.display(); } glDeleteVertexArrays(1, &vao); glDeleteBuffers(1, &vbo); glDeleteBuffers(1, &ebo); glDeleteProgram(shaderProgram); glDeleteTextures(2,texture); return 0; } and this is the vertex shader
      #version 450 core layout(location=0) in vec3 inPos; layout(location=1) in vec2 inTexCoord; out vec2 TexCoord; void main() { gl_Position=vec4(inPos,1.0); TexCoord=inTexCoord; } and the fragment shader
      #version 450 core in vec2 TexCoord; uniform sampler2D inTextureOne; uniform sampler2D inTextureTwo; out vec4 FragmentColor; void main() { FragmentColor=mix(texture(inTextureOne,TexCoord),texture(inTextureTwo,TexCoord),0.2); } I was expecting awesomeface.png on top of container.jpg

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
  • Advertisement