• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
cozzie

'pass through member function'

10 posts in this topic

Hi,

 

I was wondering if there's s a clean way to do this:

 

- assume we have class A and B

- class B has a member 'SetThingie(const int pValue)'

- class A has a vector of class B

- class A has a 'current B' int

- class A has a member 'SetThingie(const int pValue)', same as class B

- when class A SetThingie is called, it should call SetThingie of the class B object in the vector, with index 'current B'

 

Now the most straigt forward you would be something like this:

class ClassA
{
public:
    void SetThingie(const int pValue);

private:
    int currentIndex;
    std::vector<ClassB> mObjects;
}

class ClassB
{
public:
    void SetThingie(const int pValue);
}

void ClassA::SetThingie(const int pValue)
{
    mObjects[currentIndex].SetIndex(pValue);
}

Do you think there are easier/ cleaner ways to do this?

Edited by cozzie
0

Share this post


Link to post
Share on other sites

Hi.

Class A is the ShaderManager class, class B is a individual effect.

I want to be able to set shader constants through the ShaderManager.

 

In pseudo code:

 

ShaderManager->SetCurrentPermutation(5);

ShaderManager->SetWorldMatrix(myMatrix);

 

The SetWorldMatrix should call the SetWorldMatrix of the effect class,

ShaderManager class has a std::vector<EffectClass>

 

I don't think it's a flyweight pattern, because the member functions are not 100% the same (the ShaderManager class functions simply call the similar named function of the Effect class (for the 'current effect' = index of the vector of effect objects)

0

Share this post


Link to post
Share on other sites
You could treat Class A as an iterator:
class B;
class A {
public:
	B& operator*() {
		return vec[idx];
	}

	B* operator->() {
		return &vec[idx];
	}
private:
	int idx;
	vector<B> vec;
};

class B {
public:
	void frobnicate();
};

void test(A& a) {
	(*a).frobnicate();
	a->frobnicate();
}
1

Share this post


Link to post
Share on other sites

If you are wanting to directly call arbitrary member functions on every object, you can pass in member functions as function pointers:

#include <iostream>
#include <vector>

class ClassB
{
public:
    void SetThingie(const std::string &str);
    void DoSomething(float f, int i);
};

class ClassA
{
public:
	ClassA(int objCount)
	{
		this->objects.resize(objCount);
	}
	
	template<typename MemberFunc, typename ...Args>
	typename std::enable_if<std::is_member_function_pointer<MemberFunc>::value, void>::type
    CallMemberFuncOnObjects(MemberFunc memberFunc, Args&& ...args)
    {
    	int id = 0;
    	
    	for(auto &object : this->objects)
    	{
    		std::cout << "ClassB #" << ++id << " = ";
    		(object.*memberFunc)( args... );
    	}
    	
    	std::cout << std::endl;
    }

private:
    std::vector<ClassB> objects;
};

void ClassB::SetThingie(const std::string &str)
{
    std::cout << str << std::endl;
}

void ClassB::DoSomething(float f, int i)
{
	std::cout << "(" << f << ", " << i << ")" << std::endl;
}

int main()
{
	ClassA myClassA(5);
	
	myClassA.CallMemberFuncOnObjects(&ClassB::SetThingie, "Hello world!");
	myClassA.CallMemberFuncOnObjects(&ClassB::DoSomething, 3.14f, 357);
	
	return 0;
}

[Ideone test code]

 

The same thing works with just a single object in the array (using currentIndex), but that wouldn't serve much point because you could just access the object and call the function directly, as fastcall22 pointed out.

Edited by Servant of the Lord
0

Share this post


Link to post
Share on other sites

Hi,

 

I was wondering if there's s a clean way to do this:

 

- assume we have class A and B

- class B has a member 'SetThingie(const int pValue)'

- class A has a vector of class B

- class A has a 'current B' int

- class A has a member 'SetThingie(const int pValue)', same as class B

- when class A SetThingie is called, it should call SetThingie of the class B object in the vector, with index 'current B'

 

Now the most straigt forward you would be something like this:

class ClassA
{
public:
    void SetThingie(const int pValue);

private:
    int currentIndex;
    std::vector<ClassB> mObjects;
}

class ClassB
{
public:
    void SetThingie(const int pValue);
}

void ClassA::SetThingie(const int pValue)
{
    mObjects[currentIndex].SetIndex(pValue);
}

Do you think there are easier/ cleaner ways to do this?

 

What about intefacing the Effect with Shader?

class ShaderBase {
public:
    
    virtual void setWorldMatrix(MATRIX &matrix) = 0; //-- For interface class.
     void SetIndex(int &value);
     std::vector<ShaderBase> ShaderArray;
     int currentIndex;
private:

};

class Effect : public ShaderBase {
  public:
 
  void setWorldMatrix(MATRIX &matrix); //-- Because shader base has a function called setWorldMatrix(MATRIX &) you overwrite the virtual function in ShaderBase 
   
private:
}

Or are you talking about using inheritences in classes? I thought interfacing was what you're looking for because of the SetThingy thingy thing example.

0

Share this post


Link to post
Share on other sites

Wow, seems that that are other ways to do this.

To be honest, I'm not sure if they're improving readability of the code, and in the end maybe the most straight forward way will be the way to go.

 

The last solution although also looks interesting, but I believe this will need moving around (const) ref's when just need to set a shader constant (For each constant). So for no I'll go for the straight forward option.

 

Thanks again for sketching the options

1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0