Sign in to follow this  

OpenGL uniforms optimized-out

This topic is 1251 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hi.

I'm facing the problem that GLSL optimizer eliminates my uniforms, that are actually used.

Here's my vertex shader:

#version 120
#ifdef GL_ES
precision mediump float
#endif

attribute vec3 a_position;
attribute vec3 a_normal;
attribute vec2 a_texCoord0;

attribute vec2 a_boneWeight0;
attribute vec2 a_boneWeight1;
attribute vec2 a_boneWeight2;
attribute vec2 a_boneWeight3;
attribute vec2 a_boneWeight4;
attribute vec2 a_boneWeight5;
attribute vec2 a_boneWeight6;
attribute vec2 a_boneWeight7;

// uniforms
uniform mat4 MVP;
uniform mat4 shadowMVP;
uniform int useBoneWeight[8]; // use numbered bone or not
uniform mat4 boneTransform[8];
uniform int useSkinning;
 
//// outputs
#ifdef GL_ES
    varying medium vec3 normal;
    varying medium vec3 worldPos;
    varying medium vec2 textureCoord;
    varying medium vec4 shadowCoord;
#else
    varying vec3 normal;
    varying vec3 worldPos;
    varying vec2 textureCoord;
    varying vec4 shadowCoord;
#endif

void main() {
    shadowCoord = shadowMVP * vec4( a_position, 1.0f );
    textureCoord = a_texCoord0;
    mat4 skinning = mat4( 0.0 );
    if ( 1 == useSkinning )  {
        skinning += ( ( a_boneWeight0.y ) * boneTransform[ int( a_boneWeight0.x ) ] * useBoneWeight[ 0 ] );
        skinning += ( ( a_boneWeight1.y ) * boneTransform[ int( a_boneWeight1.x ) ] * useBoneWeight[ 1 ] );
        skinning += ( ( a_boneWeight2.y ) * boneTransform[ int( a_boneWeight2.x ) ] * useBoneWeight[ 2 ] );
        skinning += ( a_boneWeight3.y ) * boneTransform[ int( a_boneWeight3.x ) ] * useBoneWeight[ 3 ];
        skinning += ( a_boneWeight4.y ) * boneTransform[ int( a_boneWeight4.x ) ] * useBoneWeight[ 4 ];
        skinning += ( a_boneWeight5.y ) * boneTransform[ int( a_boneWeight5.x ) ] * useBoneWeight[ 5 ];
        skinning += ( a_boneWeight6.y ) * boneTransform[ int( a_boneWeight6.x ) ] * useBoneWeight[ 6 ];
        skinning += ( a_boneWeight7.y ) * boneTransform[ int( a_boneWeight7.x ) ] * useBoneWeight[ 7 ];
        gl_Position = MVP * skinning * vec4( a_position, 1.0f );
        normal = ( MVP * skinning * vec4( a_normal, 0.0f ) ).xyz;
        worldPos = ( MVP * skinning * vec4( a_position, 1.0f ) ).xyz;
    } else {
        gl_Position = MVP * vec4( a_position, 1.0f );
        normal = ( MVP * vec4( a_normal, 0.0f ) ).xyz;
        worldPos = ( MVP * vec4( a_position, 1.0f ) ).xyz;
    }
}

Uniforms 'useBoneWeights' and 'boneTransform' are erased during optimization.

I've tried to get their location with glGetUniformLocation() querying them by array name and array indexed elements.

All other parts of the shader are working fine.

 

I'm using Java and libgdx1.2.0 ( thus - opengl es 2.0 ) and my semi-custom shader system ( incapsulated libgdx' Shader class to give it more 'native' C/C++ interface ).

Share this post


Link to post
Share on other sites


I've tried to get their location with glGetUniformLocation() querying them by array name and array indexed elements.

Can you show the code where you query the location ?

Share this post


Link to post
Share on other sites

Ok, here it is. I'm building on top of libgdx' ShaderProgram :

import com.badlogic.gdx.Gdx;
import com.badlogic.gdx.graphics.glutils.ShaderProgram;
import com.badlogic.gdx.math.Matrix4;
import com.badlogic.gdx.math.Vector2;
import com.badlogic.gdx.math.Vector3;
import com.badlogic.gdx.utils.Disposable;

import java.util.Map;
import java.util.HashMap;

public class Shader implements Disposable {
    public ShaderProgram program;
    public Map<String, Integer> uniforms;
    public final static String SHADER_TAG = Shader.class.getSimpleName();

    public static final int SHADER_OK = 0;
    public static final int SHADER_ERROR = 1;

    public Shader( String vertexShader, String fragmentShader ) {
        ShaderProgram.pedantic = false;
        program = new ShaderProgram( Gdx.files.internal( vertexShader ), Gdx.files.internal( fragmentShader ) );
        if ( program.isCompiled() ) {
            Gdx.app.log( SHADER_TAG, "Shader compiled." );
        } else {
            Gdx.app.log( SHADER_TAG, "Shader compilation failed: " + program.getLog() );
        }
        uniforms = new HashMap<String, Integer>();
    }

    public void bind() {
        program.begin();
    }

    public void unbind() {
        program.end();
    }

    public int addUniform( String name ) {
        int location = program.getUniformLocation( name );
        if ( -1 == location ) {
            Gdx.app.log( SHADER_TAG, "Failed to get uniform's '" + name + "' location." );
            return SHADER_ERROR;
        } else {
            uniforms.put( name, location );
        }
        return SHADER_OK;
    }

    public int setUniformInt( String name, int value ) {
        Integer location = uniforms.get( name );
        if ( null == location ) {
            Gdx.app.log( SHADER_TAG, "Integer uniform '" + name + "' doesn't exists." );
            return SHADER_ERROR;
        } else {
            program.setUniformi( location.intValue(), value );
        }
        return SHADER_OK;
    }

    public int setUniformFloat( String name, float value ) {
        Integer location = uniforms.get( name );
        if ( null == location ) {
            Gdx.app.log( SHADER_TAG, "Float uniform '" + name + "' doesn't exists." );
            return SHADER_ERROR;
        } else {
            program.setUniformf( location.intValue(), value );
        }
        return SHADER_OK;
    }

    public int setUniformVec2( String name, Vector2 value ) {
        Integer location = uniforms.get( name );
        if ( null == location ) {
            Gdx.app.log( SHADER_TAG, "Vector2 uniform '" + name + "' doesn't exists." );
            return SHADER_ERROR;
        } else {
            program.setUniformf( location.intValue(), value );
        }
        return SHADER_OK;
    }

    public int setUniformVec3( String name, Vector3 value ) {
        Integer location = uniforms.get( name );
        if ( null == location ) {
            Gdx.app.log( SHADER_TAG, "Vector3 uniform '" + name + "' doesn't exists." );
            return SHADER_ERROR;
        } else {
            program.setUniformf( location.intValue(), value );
        }
        return SHADER_OK;
    }

    public int setUniformMat4( String name, Matrix4 value ) {
        Integer location = uniforms.get( name );
        if ( null == location ) {
            Gdx.app.log( SHADER_TAG, "Matrix4 uniform '" + name + "' doesn't exists." );
            return SHADER_ERROR;
        } else {
            program.setUniformMatrix( location.intValue(), value );
        }
        return SHADER_OK;
    }

    @Override
    public void dispose() {
        program.dispose();
    }

}

ShaderProgram, in it's turn, has the following code inside:

    private void fetchUniforms () {
        params.clear();
        Gdx.gl20.glGetProgramiv(program, GL20.GL_ACTIVE_UNIFORMS, params);
        int numUniforms = params.get(0);

        uniformNames = new String[numUniforms];

        for (int i = 0; i < numUniforms; i++) {
            params.clear();
            params.put(0, 1);
            type.clear();
            String name = Gdx.gl20.glGetActiveUniform(program, i, params, type);
            int location = Gdx.gl20.glGetUniformLocation(program, name);
            uniforms.put(name, location);
            uniformTypes.put(name, type.get(0));
            uniformSizes.put(name, params.get(0));
            uniformNames[i] = name;
        }
    }

So, yeah, basically, I'm fetching uniforms not directly from shader, but from libgdx' object, which kind of sucks.

Edited by syskrank

Share this post


Link to post
Share on other sites

do a sanity check

 

bump #version 120 up and recompile see if the problem persists.

 

From the code above it's too difficult to work out what's wrong. Maybe print out name and location in the for loop of fetchUniforms and see what that tells you.

Share this post


Link to post
Share on other sites

Hi, Stainless.

What do you mean by sanity check?

I've tried playing with shader 'version' string with no luck.

 

Edit: I mentioned that my Java Shader object detects only the first element of the uniform array:  'useBoneWeight[0]' and 'boneTransform[0]' are located;

So, theoretically, I can use OpenGL's glUniform*() capabilities to send a whole array of data to the shader.

I will try that somehow.

 

 

What OS/GPU do you run it on?

 

I'm developing on two machines with Linux Mint 16 and Linux Debian 7 resp.

First system has Intel HD4000 and NV GF740M cards ( tried both ) and the last one has NV GT630. I'm using libgdx 1.2.0.

Android emulator produces same results.

Edited by syskrank

Share this post


Link to post
Share on other sites

This topic is 1251 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
    • By dpadam450
      I have this code below in both my vertex and fragment shader, however when I request glGetUniformLocation("Lights[0].diffuse") or "Lights[0].attenuation", it returns -1. It will only give me a valid uniform location if I actually use the diffuse/attenuation variables in the VERTEX shader. Because I use position in the vertex shader, it always returns a valid uniform location. I've read that I can share uniforms across both vertex and fragment, but I'm confused what this is even compiling to if this is the case.
       
      #define NUM_LIGHTS 2
      struct Light
      {
          vec3 position;
          vec3 diffuse;
          float attenuation;
      };
      uniform Light Lights[NUM_LIGHTS];
       
       
    • By pr033r
      Hello,
      I have a Bachelor project on topic "Implenet 3D Boid's algorithm in OpenGL". All OpenGL issues works fine for me, all rendering etc. But when I started implement the boid's algorithm it was getting worse and worse. I read article (http://natureofcode.com/book/chapter-6-autonomous-agents/) inspirate from another code (here: https://github.com/jyanar/Boids/tree/master/src) but it still doesn't work like in tutorials and videos. For example the main problem: when I apply Cohesion (one of three main laws of boids) it makes some "cycling knot". Second, when some flock touch to another it scary change the coordination or respawn in origin (x: 0, y:0. z:0). Just some streng things. 
      I followed many tutorials, change a try everything but it isn't so smooth, without lags like in another videos. I really need your help. 
      My code (optimalizing branch): https://github.com/pr033r/BachelorProject/tree/Optimalizing
      Exe file (if you want to look) and models folder (for those who will download the sources):
      http://leteckaposta.cz/367190436
      Thanks for any help...

    • By Andrija
      I am currently trying to implement shadow mapping into my project , but although i can render my depth map to the screen and it looks okay , when i sample it with shadowCoords there is no shadow.
      Here is my light space matrix calculation
      mat4x4 lightViewMatrix; vec3 sun_pos = {SUN_OFFSET * the_sun->direction[0], SUN_OFFSET * the_sun->direction[1], SUN_OFFSET * the_sun->direction[2]}; mat4x4_look_at(lightViewMatrix,sun_pos,player->pos,up); mat4x4_mul(lightSpaceMatrix,lightProjMatrix,lightViewMatrix); I will tweak the values for the size and frustum of the shadow map, but for now i just want to draw shadows around the player position
      the_sun->direction is a normalized vector so i multiply it by a constant to get the position.
      player->pos is the camera position in world space
      the light projection matrix is calculated like this:
      mat4x4_ortho(lightProjMatrix,-SHADOW_FAR,SHADOW_FAR,-SHADOW_FAR,SHADOW_FAR,NEAR,SHADOW_FAR); Shadow vertex shader:
      uniform mat4 light_space_matrix; void main() { gl_Position = light_space_matrix * transfMatrix * vec4(position, 1.0f); } Shadow fragment shader:
      out float fragDepth; void main() { fragDepth = gl_FragCoord.z; } I am using deferred rendering so i have all my world positions in the g_positions buffer
      My shadow calculation in the deferred fragment shader:
      float get_shadow_fac(vec4 light_space_pos) { vec3 shadow_coords = light_space_pos.xyz / light_space_pos.w; shadow_coords = shadow_coords * 0.5 + 0.5; float closest_depth = texture(shadow_map, shadow_coords.xy).r; float current_depth = shadow_coords.z; float shadow_fac = 1.0; if(closest_depth < current_depth) shadow_fac = 0.5; return shadow_fac; } I call the function like this:
      get_shadow_fac(light_space_matrix * vec4(position,1.0)); Where position is the value i got from sampling the g_position buffer
      Here is my depth texture (i know it will produce low quality shadows but i just want to get it working for now):
      sorry because of the compression , the black smudges are trees ... https://i.stack.imgur.com/T43aK.jpg
      EDIT: Depth texture attachment:
      glTexImage2D(GL_TEXTURE_2D, 0,GL_DEPTH_COMPONENT24,fbo->width,fbo->height,0,GL_DEPTH_COMPONENT,GL_FLOAT,NULL); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, fbo->depthTexture, 0);
  • Popular Now