• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
cavendert

Advice on Simplifying

6 posts in this topic

So, the code that I have works, and as far as I know, doesn't have any bugs. But, I was unsure how to write a piece of code near the end, and was able to do it (with lots of unnecessary strings), and would like some advice on how to simplify it. Code below, and then I'll explain which part (though you can probably guess). 

 

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;


namespace Practice_Battle
{
    class Pokemon
    {
        public string Name;
        public int Health;
        public int Attack;
    }


    class Program
    {
        static List<Pokemon> chadPokemon = new List<Pokemon>() {
            new Pokemon {
                Name = "Charizard",
                Health = 200,
                Attack = 50
            },
            new Pokemon {
                Name = "Garchomp",
                Health = 180,
                Attack = 70
            },
            new Pokemon {
                Name= "Metagross", 
                Health = 220,
                Attack = 60
            },
            new Pokemon {
                Name = "Aegislash",
                Health = 250,
                Attack = 40
            },
            new Pokemon {
                Name = "Quagsire",
                Health = 220, 
                Attack = 50
            },
            new Pokemon {
                Name = "Gardevoir",
                Health = 170,
                Attack = 70
            }
        };


        static List<Pokemon> myPokemon = new List<Pokemon>() {
            new Pokemon {
                Name = "Blastoise",
                Health = 250,
                Attack = 60
            },
            new Pokemon {
                Name = "Blazekin",
                Health = 180, 
                Attack = 70
            },
            new Pokemon {
                Name = "Meganium", 
                Health= 200, 
                Attack = 60
            }
        };


        static void Main(string[] args)
        {


            //Chad's List of Pokemon
            //string[] chadPokemon = new string[6] { "Charizard", "Garchomp", "Metagross", "Aegislash", "Quagsire", "Gardevoir" };


            //Random Pokemon Generator
            var rnd = new Random();
            var randomChoice = chadPokemon[rnd.Next(chadPokemon.Count)];






            Console.WriteLine("Gamer Chad wants to battle!");
            Console.WriteLine("Do you accept? (yes or no)");
            string acceptInput = Console.ReadLine();


            string message = "";


            if (acceptInput == "yes")
                message = "It's time to put your game face on!";
            else
                message = "Too bad. It's time to battle!";


            //Random Pokemon is Chosen, I choose a Pokemon
            Console.WriteLine(message);
            Console.WriteLine();
            Console.WriteLine("I choose you, " + randomChoice.Name);
            Console.WriteLine();
            Console.WriteLine("Please choose your Pokemon:");
            Console.WriteLine("Press 1 for Blastoise.");
            Console.WriteLine("Press 2 for Blazekin.");
            Console.WriteLine("Press 3 for Meganium.");
            var myInput = Console.ReadLine();
            Console.WriteLine();
            var myName = myPokemon[int.Parse(myInput) - 1].Name;
            var myHealth = myPokemon[int.Parse(myInput) - 1].Health;
            var myAttack = myPokemon[int.Parse(myInput) - 1].Attack;
            Console.WriteLine(myName + ", I choose you!");


            Console.WriteLine("Type yes to Attack.");
            acceptInput = Console.ReadLine();


            while(myHealth > 0 && randomChoice.Health>0)
            {
                myHealth -= randomChoice.Attack;
                randomChoice.Health -= myAttack;
            };


            if (myHealth <= 0)
                Console.WriteLine("You are out of useable Pokemon! You blacked out!");
            else
                Console.WriteLine("You have defeated Gamer Chad! You earn a pat on the back!");


            Console.ReadLine();
        }
    }
}
So, with the random selection in the beginning, I can always reference that, whether it be health or attack. But, I wasn't able to figure out how to take myInput, and save that as a reference point. So, here is the long part. 
 
Console.WriteLine("Press 1 for Blastoise.");
            Console.WriteLine("Press 2 for Blazekin.");
            Console.WriteLine("Press 3 for Meganium.");
            var myInput = Console.ReadLine();
            Console.WriteLine();
            var myName = myPokemon[int.Parse(myInput) - 1].Name;
            var myHealth = myPokemon[int.Parse(myInput) - 1].Health;
            var myAttack = myPokemon[int.Parse(myInput) - 1].Attack;
            Console.WriteLine(myName + ", I choose you!");

As you can see at the end of the code in the While statement, I use myName, myHealth, and myAttack whenever necessary, while I can just keep sing randomChoice.etc.

 

Is there a way to simplify the code above?

 

0

Share this post


Link to post
Share on other sites

Ok. I follow you with the first part. In the 2nd part, wouldn't I still need to use all 3 variables in the while loop? I guess my next question would be this. Is it possible to avoid creating the 3 variables, or is that just how it has to be?

0

Share this post


Link to post
Share on other sites

No, they are only there so the code looks like what you had before.

You don't have to create new variables in this case, since selected.Name is very straight-forward and tells anyone reading it exactly what the code would be doing.

Console.WriteLine(selected.Name + ", I choose you!");
1

Share this post


Link to post
Share on other sites

Alright, I needed to step away from this for a bit, because I wasn't following. 

 

Having said that, and going back and writing it again fresh with your advice, it all makes perfect since to me. 

 

The

 index, and Pokemon selected

was exactly what I was looking for. Thank you for the help! I'm writing this again fresh, so I can get it to memory. 

0

Share this post


Link to post
Share on other sites

Right, again I wrote it so that you could try to follow what happened easier.

 

1. We figured out which pokemon the user selected

2. We turned that number into an index into the Pokemon-we-own array

3. We turned that index into a selected Pokemon, which is not a copy (notice no NEW keyword)

Instead it's just a reference, or better yet, just a name for a Pokemon existing somewhere else. It originally came from myPokemon[index].

The object will continue to stay alive/exist as long as the object has existing references.

 

An example:

Pokemon P1 = myPokemon[index];
Pokemon P2 = P1;
Pokemon P3 = P2;
Pokemon P4 = P3;
Pokemon P5 = P4;

Console.WriteLine(P5.Name + ", I choose you!");

So, now that I have a Pokemon named P5, which is a reference to the Pokemon named P4, which is ... to a Pokemon named P1, which is a reference to myPokemon[index].

They are all one and the same Pokemon.

Edited by Kaptein
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0