Jump to content
  • Advertisement
Sign in to follow this  
Sean_Seanston

OpenGL Drawing Sprites using Instancing - Can someone explain this behaviour?

This topic is 1366 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

My idea was to use instancing to display multiple sprites using the same texture, but with different modelView matrices applied to them and using different frames of a sprite sheet if appropriate.

The basic idea being:

1. Load texture, set some things up with the sprite sheet.

2. Set up a sprite to be drawn by adding a textured quad to a VBO by passing the position etc. and sprite sheet index to a function.

3. Call a draw function once to draw all of the added sprites at once.

 

Now, I got to the point where I could draw 1 sprite no problem, or many sprites as long as I called the function with glDrawArrays() right after adding another quad.

But when I added more than 1, a problem occurred with the texture. I then figured out that what seemed to be happening was that all of the sprites were being drawn with the same texture, which appeared to be a combination of all of the intended sprites. i.e. Right now I'm testing it with a bitmap font, and if I tried to draw 3 sprites with the letters A, B and C, I'd get all 3 quads with the same texture, which would appear to be the A, B and C images superimposed over each other in some way. I'm using transparency BTW, so any non-letter area of the sprite is transparent, hence how I can see through.

 

Now... after looking at the code and thinking about it, I'm pretty sure I understand why that's happening; simply because I set up the modelView matrix (the positions are all working perfectly) using glVertexAttribDivisor() and put in the texture coordinates as normal, therefore meaning that all vertices in a single draw call have the same texture coordinates, yes?

 

HOWEVER, while I assume that if I simply set up the texture coords in the same way, it would start to work as desired (and I've always realized as a result that the vertex coord code should probably be cleaned up a bit)... I can't actually quite get my head around just WHY this is happening, and I'd really like to find out before going forward.

 

The setup is:

- Every time I call the addQuad() function, the texture coordinates for that sprite are calculated using the sprite sheet index, then the vertices and tex coords are added to a VBO thus:

for( int i = 0; i < 6; i++ )
{
	vbo.addData( &vertices[i], sizeof( glm::vec3 ) );
	vbo.addData( &texVerts[i], sizeof( glm::vec2 ) );
}

Where vbo is an instance of a class that wraps a vertex buffer object, and addData places data sequentially in an internal byte array before the call of glBufferData() which occurs when drawSprites() is called.

There are 6 vertices and tex coords because I'm drawing 2 triangles without indices.

 

- In the drawSprites() function, after the call to glBufferData(), I set up the vertex attributes:

//Vertex positions
glEnableVertexAttribArray( 0 );
glVertexAttribPointer( 0, 3, GL_FLOAT, GL_FALSE, sizeof( glm::vec3 ) + sizeof( glm::vec2 ), 0 );

//Texture coordinates
glEnableVertexAttribArray( 1 );
glVertexAttribPointer( 1, 2, GL_FLOAT, GL_FALSE, sizeof( glm::vec3 ) + sizeof( glm::vec2 ), reinterpret_cast<void*>( sizeof( glm::vec3 ) ) );

As you can see, the buffers contains a vec3 for a vertex position, followed by a vec2 for texture coordinates, repeating for as many vertices as there are.

 

The start of the vertex shader looks like this:

#version 330

uniform mat4 projMatrix;

layout (location = 0) in vec3 inPosition;
layout (location = 1) in vec2 inCoord;
layout (location = 2) in mat4 modelView; //(Takes up locations 2-5)

out vec2 texCoord;

Where inCoord is the texture coordinate input and it's just later passed to the fragment shader by the texCoord out variable, where it is then sampled using texture2D().

 

Like I said, it all works when 1 quad is used, so I assume there aren't any fundamental errors here.

 

f there are 2 quads, say, that would mean 6*2 = 12 vec2 structures in the VBO (or 24 floats). Because I'm trying to draw multiple objects with 1 draw call and the texture coordinates aren't properly set up for this, that means I'm applying all of these to just 6 vertices for every quad.

 

I assume what's happening is, one sprite is being applied to the texture, and then another is being applied later on top of it, resulting in the garbled image I'm seeing.

But HOW exactly is that happening? What are the stages it's all going through? I would have thought that the data in the buffer would be traversed sequentially and the result would be that each vertex would be paired up with the correct texture coordinates, would would be sampled to apply the texture to that vertex's location on screen... not resulting in what I've been seeing here. But somehow, even the texture coordinates at the end of the buffer wind up influencing the texture that is applied to the vertex at the very start of the buffer.

 

I'm sure it's just something simple I'm missing about how these things work, but I just can't quite make sense of it, even though I see that it kind of makes sense when I consider that all quads must have the same texture coordinates.

Is the texture colour applied in more than 1 pass? Does OpenGL maybe deal with all of the vertex positions first (i.e. the vertex shader, though even when the first vertex position is passed in, so is its texture coordinate pair), create the areas on screen that are to be drawn to, then texture over them with the first set of texture coordinates (i.e. applies the first quad's texture to every quad), then eventually comes to the last sprite's texture coordinates and applies those over every quad again?

 

That must be how it works, but I never thought it worked like that. I'd imagined it much more... parallel or something. But maybe I just never quite thought too hard about it.

 

Sorry if I've rambled, but I've just been struggling to try and understand this.

Share this post


Link to post
Share on other sites
Advertisement

Also, am I right in thinking that attributes using glVertexAttribDivisor() need their own buffer? Or can they also be in a buffer along with other attributes with the same divisor setting?

Share this post


Link to post
Share on other sites

I did something similar a while back. For starters, I used an array texture instead of a sprite sheet. Next I found out that you don't even need to use a VBO when you are using core profile. Simply bind a VAO and then do nothing else. You can put the vertex coordinates in an array inside your vertex shader and index it using gl_VertexID. Next you set up a UBO/SSBO which contains your transformation matrices and the sprite texture index for each sprite. You index these arrays using gl_InstanceID and you are done.

Share this post


Link to post
Share on other sites

I did something similar a while back. For starters, I used an array texture instead of a sprite sheet. Next I found out that you don't even need to use a VBO when you are using core profile. Simply bind a VAO and then do nothing else.

 

Isn't that deprecated though? I've definitely heard of something along those lines, but I think people said it wasn't the modern way of doing things.

 

I have my VBOs all set up now anyways...

 

Now I've tried changing the glVertexAttribDivisor for the texture coordinates and realized something obvious: It isn't going to work if I change the divisor to only change after each quad is rendered, because that would obviously result in every vertex having the same texture coordinates and causing nothing to be rendered >_<

 

So I think what I actually need is to pass in some form of information and use that to alter the texture coordinates in the shaders.

 

i.e. My texture coordinates are currently set up like this:

const float offsetPixX = 0.01f / ( float ) texWidth;
const float offsetPixY = 0.01f / ( float ) texHeight;

const float tw = ( float( spriteWidth ) )/ ( float ) texWidth; //Width of sprite relative to texture
const float th = ( float( spriteHeight ) )/ ( float ) texHeight; //Height of sprite relative to texture
const int numPerRow = texWidth / spriteWidth;
const float tx = ( ( float )( frameIndex % numPerRow ) )* tw; //X texture coordinate
const float ty = ( ( float )( frameIndex / numPerRow ) )* th; //Y texture coordinate

glm::vec2 texVerts[] =
{
	glm::vec2( tx + offsetPixX, ty + offsetPixY ),
	glm::vec2( tx + tw - offsetPixX, ty + offsetPixY ), 
	glm::vec2( tx + tw - offsetPixX, ty + th - offsetPixY ),

	glm::vec2( tx + tw - offsetPixX, ty + th - offsetPixY ),
	glm::vec2( tx + offsetPixX, ty + th - offsetPixY ),
	glm::vec2( tx + offsetPixX, ty + offsetPixY ),
};

The key values that must change per vertex being:

const float tx = ( ( float )( frameIndex % numPerRow ) )* tw; //X texture coordinate
const float ty = ( ( float )( frameIndex / numPerRow ) )* th; //Y texture coordinate

Where frameIndex is.

 

However, I really don't know how to do that...

 

While the tex coords in the shaders are a simple vec2 and I assume it's easy to access both elements of a vec2 from a shader, I'm not sure how to go about setting them to the right values...

 

Hmmm... should I in fact just replace the tx and ty values in my current tex coords with 0, then input the frameIndex and numPerRow values as uniforms, and use those to calculate the value to add to every 1st and 2nd component of the texture coordinate vec2 sent to the shader...?

 

I think that's a reasonable plan... if no one can see any holes in it...

 

EDIT: Oh, and for that to work, I'd also have to pass in the tw and th values... those being the width of the area I want to sample relative to the whole texture.

 

EDIT2: I'm actually not sure anymore if what I said made any sense... I can't quite grasp what I was thinking anymore and why I thought it would be different to just calculating them outside the shaders and passing them in...

 

There must be examples of this somewhere... or can anyone give me a clue of where to start?... I think I've been looking at the same problem for too long...

 

EDIT3: I think I have it again... the texture coordinates need to change similarly to how I have the ModelView matrix successfully working differently with each sprite. The only different here is that there are 6 texture coordinates per quad... and the ModelView matrix works by applying the same matrix to the 6 vertices of each quad. If I could figure out the offset I need for a particular quad's texture coordinates, then I could make that the same kind of attribute that varies once for every 6 vertices, and just apply it to each texture coordinate before being passed to the fragment shader.

Whew, I think I have that right.

Edited by Sean_Seanston

Share this post


Link to post
Share on other sites

Isn't that deprecated though?

 

Is what deprecated? Rendering with a "blank" VAO bound? It's the opposite. This can only be done in core profile OpenGL, if you try this in compatibility mode you will get undefined behavior.

 

My shaders looked like this:

layout(std140, binding = 0) readonly buffer matrix_buffer
{
    mat4 matrix[];
};

layout(packed, binding = 1) readonly buffer texid_buffer
{
    int texid[];
};

const vec2 position[4] = vec2[]
(
    vec2(-1.0,  1.0),
    vec2(-1.0, -1.0),
    vec2( 1.0,  1.0),
    vec2( 1.0, -1.0)
);

out vec3 tex_coord;
 
void main()
{
    vec2 pos = position[gl_VertexID];

    tex_coord = vec3(pos * 0.5 + 0.5, texid[gl_InstanceID]);

    gl_Position = matrix[gl_InstanceID] * vec4(pos, 0.0f, 1.0);
}
layout(binding = 0) uniform sampler2DArray textures;

in vec3 tex_coord;
out vec4 frag_color;

void main()
{
    frag_color = texture(textures, tex_coord);
}

I was using SSBOs but you could use UBOs instead if you need to.

Edited by Chris_F

Share this post


Link to post
Share on other sites

 


Isn't that deprecated though?

 

Is what deprecated? Rendering with a "blank" VAO bound? It's the opposite. This can only be done in core profile OpenGL, if you try this in compatibility mode you will get undefined behavior.

 

Come to think of it... I think I might actually have been thinking of rendering without a VAO, rather than without a VBO. Nvm.

 

Interesting... I haven't looked into SSBOs yet. Is there any real advantage for most things apart from avoiding the hassle of setting up VBOs?

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Similar Content

    • By nOoNEE
      i am reading this book : link
      in the OpenGL Rendering Pipeline section there is a picture like this: link
      but the question is this i dont really understand why it is necessary to turn pixel data in to fragment and then fragment into pixel could please give me a source or a clear Explanation that why it is necessary ? thank you so mu
       
       
    • By Inbar_xz
      I'm using the OPENGL with eclipse+JOGL.
      My goal is to create movement of the camera and the player.
      I create main class, which create some box in 3D and hold 
      an object of PlayerAxis.
      I create PlayerAxis class which hold the axis of the player.
      If we want to move the camera, then in the main class I call to 
      the func "cameraMove"(from PlayerAxis) and it update the player axis.
      That's work good.
      The problem start if I move the camera on 2 axis, 
      for example if I move with the camera right(that's on the y axis)
      and then down(on the x axis) -
      in some point the move front is not to the front anymore..
      In order to move to the front, I do
      player.playerMoving(0, 0, 1);
      And I learn that in order to keep the front move, 
      I need to convert (0, 0, 1) to the player axis, and then add this.
      I think I dont do the convert right.. 
      I will be glad for help!

      Here is part of my PlayerAxis class:
       
      //player coordinate float x[] = new float[3]; float y[] = new float[3]; float z[] = new float[3]; public PlayerAxis(float move_step, float angle_move) { x[0] = 1; y[1] = 1; z[2] = -1; step = move_step; angle = angle_move; setTransMatrix(); } public void cameraMoving(float angle_step, String axis) { float[] new_x = x; float[] new_y = y; float[] new_z = z; float alfa = angle_step * angle; switch(axis) { case "x": new_z = addVectors(multScalar(z, COS(alfa)), multScalar(y, SIN(alfa))); new_y = subVectors(multScalar(y, COS(alfa)), multScalar(z, SIN(alfa))); break; case "y": new_x = addVectors(multScalar(x, COS(alfa)), multScalar(z, SIN(alfa))); new_z = subVectors(multScalar(z, COS(alfa)), multScalar(x, SIN(alfa))); break; case "z": new_x = addVectors(multScalar(x, COS(alfa)), multScalar(y, SIN(alfa))); new_y = subVectors(multScalar(y, COS(alfa)), multScalar(x, SIN(alfa))); } x = new_x; y = new_y; z = new_z; normalization(); } public void playerMoving(float x_move, float y_move, float z_move) { float[] move = new float[3]; move[0] = x_move; move[1] = y_move; move[2] = z_move; setTransMatrix(); float[] trans_move = transVector(move); position[0] = position[0] + step*trans_move[0]; position[1] = position[1] + step*trans_move[1]; position[2] = position[2] + step*trans_move[2]; } public void setTransMatrix() { for (int i = 0; i < 3; i++) { coordiTrans[0][i] = x[i]; coordiTrans[1][i] = y[i]; coordiTrans[2][i] = z[i]; } } public float[] transVector(float[] v) { return multiplyMatrixInVector(coordiTrans, v); }  
      and in the main class i have this:
       
      public void keyPressed(KeyEvent e) { if (e.getKeyCode()== KeyEvent.VK_ESCAPE) { System.exit(0); //player move } else if (e.getKeyCode()== KeyEvent.VK_W) { //front //moveAmount[2] += -0.1f; player.playerMoving(0, 0, 1); } else if (e.getKeyCode()== KeyEvent.VK_S) { //back //moveAmount[2] += 0.1f; player.playerMoving(0, 0, -1); } else if (e.getKeyCode()== KeyEvent.VK_A) { //left //moveAmount[0] += -0.1f; player.playerMoving(-1, 0, 0); } else if (e.getKeyCode()== KeyEvent.VK_D) { //right //moveAmount[0] += 0.1f; player.playerMoving(1, 0, 0); } else if (e.getKeyCode()== KeyEvent.VK_E) { //moveAmount[0] += 0.1f; player.playerMoving(0, 1, 0); } else if (e.getKeyCode()== KeyEvent.VK_Q) { //moveAmount[0] += 0.1f; player.playerMoving(0, -1, 0); //camera move } else if (e.getKeyCode()== KeyEvent.VK_I) { //up player.cameraMoving(1, "x"); } else if (e.getKeyCode()== KeyEvent.VK_K) { //down player.cameraMoving(-1, "x"); } else if (e.getKeyCode()== KeyEvent.VK_L) { //right player.cameraMoving(-1, "y"); } else if (e.getKeyCode()== KeyEvent.VK_J) { //left player.cameraMoving(1, "y"); } else if (e.getKeyCode()== KeyEvent.VK_O) { //right round player.cameraMoving(-1, "z"); } else if (e.getKeyCode()== KeyEvent.VK_U) { //left round player.cameraMoving(1, "z"); } }  
      finallt found it.... i confused with the transformation matrix row and col. thanks anyway!
    • By Lewa
      So, i'm currently trying to implement an SSAO shader from THIS tutorial and i'm running into a few issues here.
      Now, this SSAO method requires view space positions and normals. I'm storing the normals in my deferred renderer in world-space so i had to do a conversion and reconstruct the position from the depth buffer.
      And something there goes horribly wrong (which has probably to do with worldspace to viewspace transformations).
      (here is the full shader source code if someone wants to take a look at it)
      Now, i suspect that the normals are the culprit.
      vec3 normal = ((uNormalViewMatrix*vec4(normalize(texture2D(sNormals, vTexcoord).rgb),1.0)).xyz); "sNormals" is a 2D texture which stores the normals in world space in a RGB FP16 buffer.
      Now i can't use the camera viewspace matrix to transform the normals into viewspace as the cameras position isn't set at (0,0,0), thus skewing the result.
      So what i did is to create a new viewmatrix specifically for this normal without the position at vec3(0,0,0);
      //"camera" is the camera which was used for rendering the normal buffer renderer.setUniform4m(ressources->shaderSSAO->getUniform("uNormalViewMatrix"), glmExt::createViewMatrix(glm::vec3(0,0,0),camera.getForward(),camera.getUp())//parameters are (position,forwardVector,upVector) ); Though i have the feeling this is the wrong approach. Is this right or is there a better/correct way of transforming a world space normal into viewspace?
    • By HawkDeath
      Hi,
      I'm trying mix two textures using own shader system, but I have a problem (I think) with uniforms.
      Code: https://github.com/HawkDeath/shader/tree/test
      To debug I use RenderDocs, but I did not receive good results. In the first attachment is my result, in the second attachment is what should be.
      PS. I base on this tutorial https://learnopengl.com/Getting-started/Textures.


    • By norman784
      I'm having issues loading textures, as I'm clueless on how to handle / load images maybe I missing something, but the past few days I just google a lot to try to find a solution. Well theres two issues I think, one I'm using Kotlin Native (EAP) and OpenGL wrapper / STB image, so I'm not quite sure wheres the issue, if someone with more experience could give me some hints on how to solve this issue?
      The code is here, if I'm not mistaken the workflow is pretty straight forward, stbi_load returns the pixels of the image (as char array or byte array) and you need to pass those pixels directly to glTexImage2D, so a I'm missing something here it seems.
      Regards
    • By Hashbrown
      I've noticed in most post processing tutorials several shaders are used one after another: one for bloom, another for contrast, and so on. For example: 
      postprocessing.quad.bind() // Effect 1 effect1.shader.bind(); postprocessing.texture.bind(); postprocessing.quad.draw(); postprocessing.texture.unbind(); effect1.shader.unbind(); // Effect 2 effect2.shader.bind(); // ...and so on postprocessing.quad.unbind() Is this good practice, how many shaders can I bind and unbind before I hit performance issues? I'm afraid I don't know what the good practices are in open/webGL regarding binding and unbinding resources. 
      I'm guessing binding many shaders at post processing is okay since the scene has already been updated and I'm just working on a quad and texture at that moment. Or is it more optimal to put shader code in chunks and bind less frequently? I'd love to use several shaders at post though. 
      Another example of what I'm doing at the moment:
      1) Loop through GameObjects, bind its phong shader (send color, shadow, spec, normal samplers), unbind all.
      2) At post: bind post processor quad, and loop/bind through different shader effects, and so on ...
      Thanks all! 
    • By phil67rpg
      void collision(int v) { collision_bug_one(0.0f, 10.0f); glutPostRedisplay(); glutTimerFunc(1000, collision, 0); } void coll_sprite() { if (board[0][0] == 1) { collision(0); flag[0][0] = 1; } } void erase_sprite() { if (flag[0][0] == 1) { glColor3f(0.0f, 0.0f, 0.0f); glBegin(GL_POLYGON); glVertex3f(0.0f, 10.0f, 0.0f); glVertex3f(0.0f, 9.0f, 0.0f); glVertex3f(1.0f, 9.0f, 0.0f); glVertex3f(1.0f, 10.0f, 0.0f); glEnd(); } } I am using glutTimerFunc to wait a small amount of time to display a collision sprite before I black out the sprite. unfortunately my code only blacks out the said sprite without drawing the collision sprite, I have done a great deal of research on the glutTimerFunc and  animation.
    • By Lewa
      So, i stumbled upon the topic of gamma correction.
      https://learnopengl.com/Advanced-Lighting/Gamma-Correction
      So from what i've been able to gather: (Please correct me if i'm wrong)
      Old CRT monitors couldn't display color linearly, that's why gamma correction was nessecary. Modern LCD/LED monitors don't have this issue anymore but apply gamma correction anyway. (For compatibility reasons? Can this be disabled?) All games have to apply gamma correction? (unsure about that) All textures stored in file formats (.png for example) are essentially stored in SRGB color space (as what we see on the monitor is skewed due to gamma correction. So the pixel information is the same, the percieved colors are just wrong.) This makes textures loaded into the GL_RGB format non linear, thus all lighting calculations are wrong You have to always use the GL_SRGB format to gamma correct/linearise textures which are in SRGB format  
      Now, i'm kinda confused how to proceed with applying gamma correction in OpenGL.
      First of, how can i check if my Monitor is applying gamma correction? I noticed in my monitor settings that my color format is set to "RGB" (can't modify it though.) I'm connected to my PC via a HDMI cable. I'm also using the full RGB range (0-255, not the 16 to ~240 range)
       
      What i tried to do is to apply a gamma correction shader shown in the tutorial above which looks essentially like this: (it's a postprocess shader which is applied at the end of the renderpipeline)
      vec3 gammaCorrection(vec3 color){ // gamma correction color = pow(color, vec3(1.0/2.2)); return color; } void main() { vec3 color; vec3 tex = texture2D(texture_diffuse, vTexcoord).rgb; color = gammaCorrection(tex); outputF = vec4(color,1.0f); } The results look like this:
      No gamma correction:
      With gamma correction:
       
      The colors in the gamma corrected image look really wased out. (To the point that it's damn ugly. As if someone overlayed a white half transparent texture. I want the colors to pop.)
      Do i have to change the textures from GL_RGB to GL_SRGB in order to gamma correct them in addition to applying the post process gamma correction shader? Do i have to do the same thing with all FBOs? Or is this washed out look the intended behaviour?
    • By OneKaidou
      Hi
       
      I am trying to program shadow volumes and i stumbled upon an artifact which i can not find the cause for.
      I generate the shadow volumes using a geometry shader with reversed extrusion (projecting the lightfacing triangles to infinity) and write the stencil buffer according to z-fail. The base of my code is the "lighting" chapter from learnopengl.com, where i extended the shader class to include geometry shader. I also modified the "lightingshader" to draw the ambient pass when "pass" is set to true and the diffuse/ specular pass when set to false. For easier testing i added a view controls to switch on/off the shadow volumes' color rendering or to change the cubes' position, i made the lightnumber controllable and changed the diffuse pass to render green for easier visualization of my problem.
       
      The first picture shows the rendered scene for one point light, all cubes and the front cube's shadow volume is the only one created (intentional). Here, all is rendered as it should be with all lit areas green and all areas inside the shadow volume black (with the volume's sides blended over).

      If i now turn on the shadow volumes for all the other cubes, we get a bit of a mess, but its also obvious that some areas that were in shadow before are now erroneously lit (for example the first cube to the right from the originaly shadow volumed cube). From my testing the areas erroneously lit are the ones where more than one shadow volume marks the area as shadowed.

      To check if a wrong stencil buffer value caused this problem i decided to change the stencil function for the diffuse pass to only render if the stencil is equal to 2. As i repeated this approach with different values for the stencil function i found out that if i set the value equal to 1 or any other uneven value the lit and shadowed areas are inverted and if i set it to 0 or any other even value i get the results shown above.
      This lead me to believe that the value and thus the stencil buffer values may be clamped to [0,1] which would also explain the artifact, because twice in shadow would equal in no shadow at all, but from what i found on the internet and from what i tested with
      GLint stencilSize = 0; glGetFramebufferAttachmentParameteriv(GL_DRAW_FRAMEBUFFER, GL_STENCIL, GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE, &stencilSize); my stencilsize is 8 bit, which should be values within [0,255].
      Does anyone know what might be the cause for this artifact or the confusing results with other stencil functions?
       
      // [the following code includes all used gl* functions, other parts are due to readability partialy excluded] // glfw: initialize and configure // ------------------------------ glfwInit(); glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 4); glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 4); glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE); // glfw window creation // -------------------- GLFWwindow* window = glfwCreateWindow(SCR_WIDTH, SCR_HEIGHT, "LearnOpenGL", NULL, NULL); if (window == NULL) { cout << "Failed to create GLFW window" << endl; glfwTerminate(); return -1; } glfwMakeContextCurrent(window); glfwSetFramebufferSizeCallback(window, framebuffer_size_callback); glfwSetCursorPosCallback(window, mouse_callback); glfwSetScrollCallback(window, scroll_callback); // tell GLFW to capture our mouse glfwSetInputMode(window, GLFW_CURSOR, GLFW_CURSOR_DISABLED); // glad: load all OpenGL function pointers // --------------------------------------- if (!gladLoadGLLoader((GLADloadproc)glfwGetProcAddress)) { cout << "Failed to initialize GLAD" << endl; return -1; } // ==================================================================================================== // window and functions are set up // ==================================================================================================== // configure global opengl state // ----------------------------- glEnable(GL_DEPTH_TEST); glEnable(GL_CULL_FACE); // build and compile our shader program [...] // set up vertex data (and buffer(s)) and configure vertex attributes [...] // shader configuration [...] // render loop // =========== while (!glfwWindowShouldClose(window)) { // input processing and fps calculation[...] // render // ------ glClearColor(0.1f, 0.1f, 0.1f, 1.0f); glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); glDepthMask(GL_TRUE); //enable depth writing glDepthFunc(GL_LEQUAL); //avoid z-fighting //draw ambient component into color and depth buffer view = camera.GetViewMatrix(); projection = glm::perspective(glm::radians(camera.Zoom), (float)SCR_WIDTH / (float)SCR_HEIGHT, 0.1f, 100.0f); // setting up lighting shader for ambient pass [...] // render the cubes glBindVertexArray(cubeVAO); for (unsigned int i = 0; i < 10; i++) { //position cube [...] glDrawArrays(GL_TRIANGLES, 0, 36); } //------------------------------------------------------------------------------------------------------------------------ glDepthMask(GL_FALSE); //disable depth writing glEnable(GL_BLEND); glBlendFunc(GL_ONE, GL_ONE); //additive blending glEnable(GL_STENCIL_TEST); //setting up shadowShader and lightingShader [...] for (int light = 0; light < lightsused; light++) { glDepthFunc(GL_LESS); glClear(GL_STENCIL_BUFFER_BIT); //configure stencil ops for front- and backface to write according to z-fail glStencilOpSeparate(GL_FRONT, GL_KEEP, GL_DECR_WRAP, GL_KEEP); //-1 for front-facing glStencilOpSeparate(GL_BACK, GL_KEEP, GL_INCR_WRAP, GL_KEEP); //+1 for back-facing glStencilFunc(GL_ALWAYS, 0, GL_TRUE); //stencil test always passes if(hidevolumes) glColorMask(GL_FALSE, GL_FALSE, GL_FALSE, GL_FALSE); //disable writing to the color buffer glDisable(GL_CULL_FACE); glEnable(GL_DEPTH_CLAMP); //necessary to render SVs into infinity //draw SV------------------- shadowShader.use(); shadowShader.setInt("lightnr", light); int nr; if (onecaster) nr = 1; else nr = 10; for (int i = 0; i < nr; i++) { //position cube[...] glDrawArrays(GL_TRIANGLES, 0, 36); } //-------------------------- glDisable(GL_DEPTH_CLAMP); glEnable(GL_CULL_FACE); glStencilFunc(GL_EQUAL, 0, GL_TRUE); //stencil test passes for ==0 so only for non shadowed areas glStencilOp(GL_KEEP, GL_KEEP, GL_KEEP); //keep stencil values for illumination glColorMask(GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE); //enable writing to the color buffer glDepthFunc(GL_LEQUAL); //avoid z-fighting //draw diffuse and specular pass lightingShader.use(); lightingShader.setInt("lightnr", light); // render the cubes for (unsigned int i = 0; i < 10; i++) { //position cube[...] glDrawArrays(GL_TRIANGLES, 0, 36); } } glDisable(GL_BLEND); glDepthMask(GL_TRUE); //enable depth writing glDisable(GL_STENCIL_TEST); //------------------------------------------------------------------------------------------------------------------------ // also draw the lamp object(s) [...] // glfw: swap buffers and poll IO events (keys pressed/released, mouse moved etc.) // ------------------------------------------------------------------------------- glfwSwapBuffers(window); glfwP } // optional: de-allocate all resources once they've outlived their purpose: // ------------------------------------------------------------------------ glDeleteVertexArrays(1, &cubeVAO); glDeleteVertexArrays(1, &lightVAO); glDeleteBuffers(1, &VBO); // glfw: terminate, clearing all previously allocated GLFW resources. // ------------------------------------------------------------------ glfwTerminate(); return 0;  
    • By Green_Baron
      Hi,
      i am self teaching me graphics and oo programming and came upon this:
      My Window class creates an input handler instance, the glfw user pointer is redirected to that object and methods there do the input handling for keyboard and mouse. That works. Now as part of the input handling i have an orbiting camera that is controlled by mouse movement. GLFW_CURSOR_DISABLED is set as proposed in the glfw manual. The manual says that in this case the cursor is automagically reset to the window's center. But if i don't reset it manually with glfwSetCursorPos( center ) mouse values seem to add up until the scene is locked up.
      Here are some code snippets, mostly standard from tutorials:
      // EventHandler m_eventHandler = new EventHandler( this, glm::vec3( 0.0f, 5.0f, 0.0f ), glm::vec3( 0.0f, 1.0f, 0.0f ) ); glfwSetWindowUserPointer( m_window, m_eventHandler ); m_eventHandler->setCallbacks(); Creation of the input handler during window creation. For now, the camera is part of the input handler, hence the two vectors (position, up-vector).  In future i'll take that functionally out into an own class that inherits from the event handler.
      void EventHandler::setCallbacks() { glfwSetCursorPosCallback( m_window->getWindow(), cursorPosCallback ); glfwSetKeyCallback( m_window->getWindow(), keyCallback ); glfwSetScrollCallback( m_window->getWindow(), scrollCallback ); glfwSetMouseButtonCallback( m_window->getWindow(), mouseButtonCallback ); } Set callbacks in the input handler.
      // static void EventHandler::cursorPosCallback( GLFWwindow *w, double x, double y ) { EventHandler *c = reinterpret_cast<EventHandler *>( glfwGetWindowUserPointer( w ) ); c->onMouseMove( (float)x, (float)y ); } Example for the cursor pos callback redirection to a class method.
      // virtual void EventHandler::onMouseMove( float x, float y ) { if( x != 0 || y != 0 ) { // @todo cursor should be set automatically, according to doc if( m_window->isCursorDisabled() ) glfwSetCursorPos( m_window->getWindow(), m_center.x, m_center.y ); // switch up/down because its more intuitive m_yaw += m_mouseSensitivity * ( m_center.x - x ); m_pitch += m_mouseSensitivity * ( m_center.y - y ); // to avoid locking if( m_pitch > 89.0f ) m_pitch = 89.0f; if( m_pitch < -89.0f ) m_pitch = -89.0f; // Update Front, Right and Up Vectors updateCameraVectors(); } } // onMouseMove() Mouse movement processor method. The interesting part is the manual reset of the mouse position that made the thing work ...
      // straight line distance between the camera and look at point, here (0,0,0) float distance = glm::length( m_target - m_position ); // Calculate the camera position using the distance and angles float camX = distance * -std::sin( glm::radians( m_yaw ) ) * std::cos( glm::radians( m_pitch) ); float camY = distance * -std::sin( glm::radians( m_pitch) ); float camZ = -distance * std::cos( glm::radians( m_yaw ) ) * std::cos( glm::radians( m_pitch) ); // Set the camera position and perspective vectors m_position = glm::vec3( camX, camY, camZ ); m_front = glm::vec3( 0.0, 0.0, 0.0 ) - m_position; m_up = m_worldUp; m_right = glm::normalize( glm::cross( m_front, m_worldUp ) ); glm::lookAt( m_position, m_front, m_up ); Orbiting camera vectors calculation in updateCameraVectors().
      Now, for my understanding, as the glfw manual explicitly states that if cursor is disabled then it is reset to the center, but my code only works if it is reset manually, i fear i am doing something wrong. It is not world moving (only if there is a world to render :-)), but somehow i am curious what i am missing.
       
      I am not a professional programmer, just a hobbyist, so it may well be that i got something principally wrong :-)
      And thanks for any hints and so ...
       
  • Advertisement
  • Popular Now

  • Forum Statistics

    • Total Topics
      631354
    • Total Posts
      2999503
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

Participate in the game development conversation and more when you create an account on GameDev.net!

Sign me up!