Jump to content
  • Advertisement
Sign in to follow this  
lolxdfly

OpenGL OpenGL-ES Light-Shader: distance-issue

This topic is 1064 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

i am working on the Light at my Android OpenGL-ES 2D-Application. I have a problem with calculating the distance between Lightsource and pixel.
This is my actual shadercode:
precision mediump float;
varying vec4 v_Color;
varying vec2 v_texCoord;
uniform vec3 uLightPos; //xy = 2dPos, z = radius
uniform sampler2D s_texture;
void main() {
  float d = distance(uLightPos.xy, gl_FragCoord.xy); //calculate distance
  if(d < uLightPos.z){ //radius
    float att = 1.0/(0.05 + (0.001 * d) + (0.0001 * d * d)); //attunation
    gl_FragColor = texture2D( s_texture, v_texCoord ) * v_Color * vec4(att, att, att, 1.0); //LightColor = diffuseColor
  }else
    gl_FragColor = vec4(0.0, 0.0, 0.0, 1.0);
}  

If the radius is 250.0f everything works! I can see the Light and the Light "is cutted off" at 250 pixel away from the Lightsource.
 
Now my Problem: if the radius is set to 300.0f the Light gets never "cutted off". I tested it with dynamic values.. between 250.0f and 300.0f is a point, where it stops working. In conclusion: The distance never increases to a higher value than this point. This also affects the light attunation! It never gets completly dark... there is a constant light after this point. Am i calculating the distance wrong?
 
Here are the two states:
 
Radius = 250.0
JCQRf.png


Radius = 300.0
Qnnfb.png Edited by lolxdfly

Share this post


Link to post
Share on other sites
Advertisement

can you be more specific ?

 

gl_FragCoord.xy returns not the thing you want you should get distance in WORLD SPACE instead of screen space. so when you pass vertex position in vertex shader you pass the same value to fragment data.

 

Please share vertex shader code too so i can fix your shader.

 

then tell me if you really do that thing with the pixel radius.

 

 

anyway it looks like you are doing it whole wrong since when you pass vertex in vertex shader you do multiple by MVP matrix then you pass that result to fragment shader.

 

lets say its:

varying vec4 uVertexPosition;

 

additionally set screen size in shader;

uniform float SCREEN_WIDTH;

uniform float SCREEN_HEIGHT;

 

//now that will work for perspective projection and i assume you use perespective calculation:

 

so then you should do:

 

uVertexPosition = uVertexPosition / uVertexPosition.w;

uVertexPosition = uVertexPosition * 0.5 + 0.5;

 

float vec2 vertex_pos = vec2( uVertexPosition.x * SCREEN_WIDTH, uVertexPosition.y * SCREEN_HEIGHT );

 

 

then you can actually check for distance (assuming light is in screen space)

 

 

 

the att factor still seems wrong 

 

try

	float dst = distance(uLightPosition.xy, vertex_pos);
	float intensity = clamp(1.0 - dst / uLightPosition.z, 0.0, 1.0);
	vec4 color = vec4(LDIFF.x, LDIFF.y, LDIFF.z, 1.0)*intensity;
LDIFF is light diffuse color - last 1.0 alpha value depends on blending you want to use
	gl_FragColor = color;
Edited by WiredCat

Share this post


Link to post
Share on other sites

Sounds like a precision issue to me. Your math is being done at mediump which could have a maximum range of -16384 to 16384, which is quite a lot more than your 250-300 but do bear in mind that the distance function is almost certainly having to square. In fact, maybe the compiler is smart enough to remove the square root from the 'distance' function and compare with your radius squared (which can be calculated per draw call) instead of using radius.

 

First up, if you have a device that supports highp in the pixel shader try just changing 'precision mediump float;' to 'precision highp float;'. If that fixes it then we're on the right track.

 

But I wouldn't stop there because lots of Android devices don't support that. Try doing your lighting math in normalized screen coordinates instead of pixel coordinates maybe? (i.e. divide both the pixel pos and the light pos by the screen height or the screen width)

Share this post


Link to post
Share on other sites

First up, if you have a device that supports highp in the pixel shader try just changing 'precision mediump float;' to 'precision highp float;'. If that fixes it then we're on the right track.

That fixed it... thanks smile.png
I changed the distance calulation into:

float d = distance((gl_FragCoord.xy - vec2(0.5, 0.5)) / 1080.0, LightPos.xy / 1080.0) * 1080.0;

can you be more specific ?
 
gl_FragCoord.xy returns not the thing you want you should get distance in WORLD SPACE instead of screen space. so when you pass vertex position in vertex shader you pass the same value to fragment data.
 
Please share vertex shader code too so i can fix your shader.
 
then tell me if you really do that thing with the pixel radius.
 
 
anyway it looks like you are doing it whole wrong since when you pass vertex in vertex shader you do multiple by MVP matrix then you pass that result to fragment shader.
 
lets say its:
varying vec4 uVertexPosition;
 
additionally set screen size in shader;
uniform float SCREEN_WIDTH;
uniform float SCREEN_HEIGHT;
 
//now that will work for perspective projection and i assume you use perespective calculation:
 
so then you should do:
 
uVertexPosition = uVertexPosition / uVertexPosition.w;
uVertexPosition = uVertexPosition * 0.5 + 0.5;
 
float vec2 vertex_pos = vec2( uVertexPosition.x * SCREEN_WIDTH, uVertexPosition.y * SCREEN_HEIGHT );
 
 
then you can actually check for distance (assuming light is in screen space)
 
 
 
the att factor still seems wrong 
 
try

	float dst = distance(uLightPosition.xy, vertex_pos);
	float intensity = clamp(1.0 - dst / uLightPosition.z, 0.0, 1.0);
	vec4 color = vec4(LDIFF.x, LDIFF.y, LDIFF.z, 1.0)*intensity;
LDIFF is light diffuse color - last 1.0 alpha value depends on blending you want to use
	gl_FragColor = color;

 
My World Coords are the same like the Pixel Coords so i.e. the bottomleft(1920, 1080) of my screen is the world coord (1920, 1080).
This is my vertexshader:

uniform mat4 uMVPMatrix;
attribute vec4 vPosition;
attribute vec4 a_Color;
attribute vec2 a_texCoord;
varying vec4 v_Color;
varying vec2 v_texCoord;
void main() {
	gl_Position = uMVPMatrix * vPosition;
	v_texCoord = a_texCoord;
	v_Color = a_Color;
}

This was my first attenuation formula: clamp(1.0 - dst / uLightPosition.z, 0.0, 1.0);. That is partly better, because it gets 0. The "Constant-Linear-Quadratic" attenuation never gets 0, but it has 3 factors to form the light. Note that the explanation from the link does not fit exactly to my formula! My complete Lightshader is not finished (LightColor, Ambient missing)!

Edited by lolxdfly

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

We are the game development community.

Whether you are an indie, hobbyist, AAA developer, or just trying to learn, GameDev.net is the place for you to learn, share, and connect with the games industry. Learn more About Us or sign up!

Sign me up!