• Advertisement
Sign in to follow this  

Unity RPG item/spell/combat system

This topic is 873 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Im working in the implementation of the combat system for my RPG (made with Unity3d and c#), which depends on the item system, skill system, etc. The idea is to have real time pausable combat, so my initial idea was to have a queue of actions. An action can be a weapon attack or an spell, and can be created by the AI or the player input during combat. But when started to work on the actual implementaiton I thought that perhaps my system was too complex.

Described in pseudocode, it something like this:

 

On the Update() of each entity (including player)

if queue is not empty

 get the first action if cooldown timer expired and it is loopable, else, remove and get next

 is it an item action?

    if the item is a weapon then get the item dmg properties, the target protect properties and decide if it is a succesful attack, dmg, etc

    if the item is something else, decide what to do

 is it a spell cast?

     then do the spell stuff, etc

 set the cooldown timer

 

The advantage I see: the item class is generic and can contain any item, because it just hold properties, doesnt knows how to actually use the item.

The disadvantage: the same. Also, the gameplay code becomes complex (you have to compare all the item damage types against all the target protection types). The action class is a mess: it must contain all possible combinations of actions: item on actor (like a sword attack), spell on actor, and any other I can figure out later.

Is there any other more optimal solution to this?

Share this post


Link to post
Share on other sites
Advertisement

I'm the author of a real-time pausable RPG. To answer your basic question, "Do I have to do all that stuff?" Yes, you do. In fact, I think you simplified; for an attack, my code runs three timers. One for a character preparing to attack, but not yet attacking, who should display a fighting animation. Second, when the character actually is attacking, to display the attacking animation. And third, when the character is recovering from his attack, displaying a recover animation (i.e. moving his sword back from the extended position to the ready position). Real-time is complicated!

 

Now, how to handle it in code? For your action class, I have a similar set of classes. However, I subclass depending on the particular action. So "attack with a weapon" in one subclass, "cast a spell" is another, etc. Is something like that possible in your architecture? If so, you should be able to avoid having one mega-action class. I actually have one giant class that handles running all the actions through a switch statement. I'm not proud of this architecture, but there are not that many types of actions, so I live with it, and it works fine. You can probably do better than that, though, if you are writing code from scratch, by moving some or all of the action-running code into the sub-classes.

 

Hope that helps a little,

Geoff

Share this post


Link to post
Share on other sites

Well, you say you have a base class, for example "Attack" and that spells, sword swipes etc Derive from it?

 

The details of how to use the item should be handled by the derived class. The caller should not be concerned with this and should just call some "activate()" or "use()" method.

 

You could also have a factory system, whereby the sword generates attack derived objects and the spellbook (or whatever is source of your magic) does the same. These can be created dynamically based on the attack type. 

 

If you can't make it work like that currently and the caller directly reads properties from the class and internally performs the action this is what is causing the confusion, refactor it to black box the use/cooldown code.

 

Hope this helps!

Edited by braindigitalis

Share this post


Link to post
Share on other sites

Well, you say you have a base class, for example "Attack" and that spells, sword swipes etc Derive from it?

 

The details of how to use the item should be handled by the derived class. The caller should not be concerned with this and should just call some "activate()" or "use()" method.

 

You could also have a factory system, whereby the sword generates attack derived objects and the spellbook (or whatever is source of your magic) does the same. These can be created dynamically based on the attack type. 

 

If you can't make it work like that currently and the caller directly reads properties from the class and internally performs the action this is what is causing the confusion, refactor it to black box the use/cooldown code.

 

Hope this helps!

 

Nope, I dont have a class Attack. What I do plan to have (not yet) are classess for abilities you can apply on targets. I will follow your advice and derive specialized item classes, that will help to clear my game logic code.

Share this post


Link to post
Share on other sites

You might look into creating an interface for your attack items and implement this in your derived classes.  This would then allow separation of the data structures and game logic of how they work but still allow you to store them in a simple data structure.

 

For example if we have an interface defined like:

interface iAttackable
{
    void Attack();
}

Then we could define a sword and spell class like this:

public class Sword : iAttackable
{
    public void Attack()
    {
        //...Do some logic in the attack
    }
}

public class Spell : iAttackable
{
    public void Attack()
    {
        //...Do some logic in the attack
    }
}

This way now you don't have to do a check on an object to see how to perform a specific attack.  Abstracting it this way now allows for different logic to be handled by the unique class.  You may need to add parameters to the interface in order to share objects between class but this information would be something you will need to figure out in your design.  Now then back to the interface and now that we have defined the usage in two classes we could write code like:

//....Update method definition skipped
iAttackable attackItem = new Sword(); // Or this could very well be "new Spell();"
attackItem.Attack();

Because the attackItem is a generic interface class we can store either the Spell class or the Sword class in this variable.  With this you can now even stack different kind of attacks so if a player wanted to use a sword and a spell they could without bloating your code just create a data structure to manage it.  Having a generic enough way to access different types of classes can be beneficial in a complex system.  One class can also implement multiple interfaces which then can allow you to blend different features generically into one class.  For example you may need to do something special on the spell being cast during the update process.  You can use type casting to these specific interfaces and then test if the cast worked before your proceed.

 

This is just one different approach that could help solve your design problem.  Try a couple of different ideas and see how it works best for your design.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By Yosef BenSadon
      Hi , I was considering this start up http://adshir.com/, for investment and i would like a little bit of feedback on what the developers community think about the technology.
      So far what they have is a demo that runs in real time on a Tablet at over 60FPS, it runs locally on the  integrated GPU of the i7 . They have a 20 000 triangles  dinosaur that looks impressive,  better than anything i saw on a mobile device, with reflections and shadows looking very close to what they would look in the real world. They achieved this thanks to a  new algorithm of a rendering technique called Path tracing/Ray tracing, that  is very demanding and so far it is done mostly for static images.
      From what i checked around there is no real option for real time ray tracing (60 FPS on consumer devices). There was imagination technologies that were supposed to release a chip that supports real time ray tracing, but i did not found they had a product in the market or even if the technology is finished as their last demo  i found was with a PC.  The other one is OTOY with their brigade engine that is still not released and if i understand well is more a cloud solution than in hardware solution .
      Would there  be a sizable  interest in the developers community in having such a product as a plug-in for existing game engines?  How important  is Ray tracing to the  future of high end real time graphics?
    • By bryandalo
      Good day,

      I just wanted to share our casual game that is available for android.

      Description: Fight your way from the ravenous plant monster for survival through flips. The rules are simple, drag and release your phone screen. Improve your skills and show it to your friends with the games quirky ranks. Select an array of characters using the orb you acquire throughout the game.

      Download: https://play.google.com/store/apps/details?id=com.HellmodeGames.FlipEscape&hl=en
       
      Trailer: 
       
    • By Manuel Berger
      Hello fellow devs!
      Once again I started working on an 2D adventure game and right now I'm doing the character-movement/animation. I'm not a big math guy and I was happy about my solution, but soon I realized that it's flawed.
      My player has 5 walking-animations, mirrored for the left side: up, upright, right, downright, down. With the atan2 function I get the angle between player and destination. To get an index from 0 to 4, I divide PI by 5 and see how many times it goes into the player-destination angle.

      In Pseudo-Code:
      angle = atan2(destination.x - player.x, destination.y - player.y) //swapped y and x to get mirrored angle around the y axis
      index = (int) (angle / (PI / 5));
      PlayAnimation(index); //0 = up, 1 = up_right, 2 = right, 3 = down_right, 4 = down

      Besides the fact that when angle is equal to PI it produces an index of 5, this works like a charm. Or at least I thought so at first. When I tested it, I realized that the up and down animation is playing more often than the others, which is pretty logical, since they have double the angle.

      What I'm trying to achieve is something like this, but with equal angles, so that up and down has the same range as all other directions.

      I can't get my head around it. Any suggestions? Is the whole approach doomed?

      Thank you in advance for any input!
       
    • By khawk
      Watch the latest from Unity.
       
    • By GytisDev
      Hello,
      without going into any details I am looking for any articles or blogs or advice about city building and RTS games in general. I tried to search for these on my own, but would like to see your input also. I want to make a very simple version of a game like Banished or Kingdoms and Castles,  where I would be able to place like two types of buildings, make farms and cut trees for resources while controlling a single worker. I have some problem understanding how these games works in the back-end: how various data can be stored about the map and objects, how grids works, implementing work system (like a little cube (human) walks to a tree and cuts it) and so on. I am also pretty confident in my programming capabilities for such a game. Sorry if I make any mistakes, English is not my native language.
      Thank you in advance.
  • Advertisement