• Advertisement
  • Popular Tags

  • Popular Now

  • Advertisement
  • Similar Content

    • By Jason Smith
      While working on a project using D3D12 I was getting an exception being thrown while trying to get a D3D12_CPU_DESCRIPTOR_HANDLE. The project is using plain C so it uses the COBJMACROS. The following application replicates the problem happening in the project.
      #define COBJMACROS #pragma warning(push, 3) #include <Windows.h> #include <d3d12.h> #include <dxgi1_4.h> #pragma warning(pop) IDXGIFactory4 *factory; ID3D12Device *device; ID3D12DescriptorHeap *rtv_heap; int WINAPI wWinMain(HINSTANCE hinst, HINSTANCE pinst, PWSTR cline, int cshow) { (hinst), (pinst), (cline), (cshow); HRESULT hr = CreateDXGIFactory1(&IID_IDXGIFactory4, (void **)&factory); hr = D3D12CreateDevice(0, D3D_FEATURE_LEVEL_11_0, &IID_ID3D12Device, &device); D3D12_DESCRIPTOR_HEAP_DESC desc; desc.NumDescriptors = 1; desc.Type = D3D12_DESCRIPTOR_HEAP_TYPE_RTV; desc.Flags = D3D12_DESCRIPTOR_HEAP_FLAG_NONE; desc.NodeMask = 0; hr = ID3D12Device_CreateDescriptorHeap(device, &desc, &IID_ID3D12DescriptorHeap, (void **)&rtv_heap); D3D12_CPU_DESCRIPTOR_HANDLE rtv = ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart(rtv_heap); (rtv); } The call to ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart throws an exception. Stepping into the disassembly for ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart show that the error occurs on the instruction
      mov  qword ptr [rdx],rax
      which seems odd since rdx doesn't appear to be used. Any help would be greatly appreciated. Thank you.
       
    • By lubbe75
      As far as I understand there is no real random or noise function in HLSL. 
      I have a big water polygon, and I'd like to fake water wave normals in my pixel shader. I know it's not efficient and the standard way is really to use a pre-calculated noise texture, but anyway...
      Does anyone have any quick and dirty HLSL shader code that fakes water normals, and that doesn't look too repetitious? 
    • By turanszkij
      Hi,
      I finally managed to get the DX11 emulating Vulkan device working but everything is flipped vertically now because Vulkan has a different clipping space. What are the best practices out there to keep these implementation consistent? I tried using a vertically flipped viewport, and while it works on Nvidia 1050, the Vulkan debug layer is throwing error messages that this is not supported in the spec so it might not work on others. There is also the possibility to flip the clip scpace position Y coordinate before writing out with vertex shader, but that requires changing and recompiling every shader. I could also bake it into the camera projection matrices, though I want to avoid that because then I need to track down for the whole engine where I upload matrices... Any chance of an easy extension or something? If not, I will probably go with changing the vertex shaders.
    • By NikiTo
      Some people say "discard" has not a positive effect on optimization. Other people say it will at least spare the fetches of textures.
       
      if (color.A < 0.1f) { //discard; clip(-1); } // tons of reads of textures following here // and loops too
      Some people say that "discard" will only mask out the output of the pixel shader, while still evaluates all the statements after the "discard" instruction.

      MSN>
      discard: Do not output the result of the current pixel.
      clip: Discards the current pixel..
      <MSN

      As usual it is unclear, but it suggests that "clip" could discard the whole pixel(maybe stopping execution too)

      I think, that at least, because of termal and energy consuming reasons, GPU should not evaluate the statements after "discard", but some people on internet say that GPU computes the statements anyways. What I am more worried about, are the texture fetches after discard/clip.

      (what if after discard, I have an expensive branch decision that makes the approved cheap branch neighbor pixels stall for nothing? this is crazy)
    • By NikiTo
      I have a problem. My shaders are huge, in the meaning that they have lot of code inside. Many of my pixels should be completely discarded. I could use in the very beginning of the shader a comparison and discard, But as far as I understand, discard statement does not save workload at all, as it has to stale until the long huge neighbor shaders complete.
      Initially I wanted to use stencil to discard pixels before the execution flow enters the shader. Even before the GPU distributes/allocates resources for this shader, avoiding stale of pixel shaders execution flow, because initially I assumed that Depth/Stencil discards pixels before the pixel shader, but I see now that it happens inside the very last Output Merger state. It seems extremely inefficient to render that way a little mirror in a scene with big viewport. Why they've put the stencil test in the output merger anyway? Handling of Stencil is so limited compared to other resources. Does people use Stencil functionality at all for games, or they prefer discard/clip?

      Will GPU stale the pixel if I issue a discard in the very beginning of the pixel shader, or GPU will already start using the freed up resources to render another pixel?!?!



       
  • Advertisement
  • Advertisement
Sign in to follow this  

DX12 [D3D12] CreateCommittedResource fails!

This topic is 772 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

CreateCommittedResource returns E_INVALIDARG One or more arguments are invalid.

I double checked my code and couldn't find where I'm giving invalid argument.

const FLOAT clearCol[] = { 0.0f, 0.2f, 0.4f, 1.0f };
const CD3DX12_CLEAR_VALUE clearValue(DXGI_FORMAT_R8G8B8A8_UNORM, clearCol);

hr = g_pDevice->CreateCommittedResource( &CD3DX12_HEAP_PROPERTIES(D3D12_HEAP_TYPE_UPLOAD),
		D3D12_HEAP_FLAG_NONE, // ?  D3D12_HEAP_FLAG_ALLOW_ONLY_RT_DS_TEXTURES
		&CD3DX12_RESOURCE_DESC::Tex2D(DXGI_FORMAT_R8G8B8A8_UNORM, width, height, 1, 0, 1, 0, D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET, D3D12_TEXTURE_LAYOUT_UNKNOWN, 0), //Arraysize was 1
		D3D12_RESOURCE_STATE_RENDER_TARGET,
		&clearValue, 
		IID_PPV_ARGS(&g_pUpHeapBuffer) );

if (FAILED(hr)) { // fails
	return false;
}

Image width = height = 225px

And here's the heap def: ID3D12Resource* g_pUpHeapBuffer;

 

Share this post


Link to post
Share on other sites
Advertisement

From MSDN:

"When a resource is created together with a D3D12_HEAP_TYPE_UPLOAD heap, InitialResourceState must be D3D12_RESOURCE_STATE_GENERIC_READ."

 

It's really odd that the debug layer doesn't say anything about that.

Share this post


Link to post
Share on other sites

What's strange is that I can create a buffer with the same flags.

CD3DX12_RESOURCE_DESC::Buffer(8 * 1024 * 1024);

Share this post


Link to post
Share on other sites

Got my error.

 

D3D12 ERROR: ID3D12Device::CreateCommittedResource: A texture resource cannot be created on a D3D12_HEAP_TYPE_UPLOAD or D3D12_HEAP_TYPE_READBACK heap. Investigate CopyTextureRegion to copy texture data in CPU accessible buffers, or investigate D3D12_HEAP_TYPE_CUSTOM and WriteToSubresource for UMA adapter optimizations. [ STATE_CREATION ERROR #638: CREATERESOURCEANDHEAP_INVALIDHEAPPROPERTIES]

 

?I'm surprised that it's not allowed to create a texture resource on upload heap!

What will I do next? I was planning to map and copy my texture from upload to default heap.

Edited by ngub05

Share this post


Link to post
Share on other sites

That's correct, no textures in Upload or Readback heaps.

 

As per the error, data you want to upload to the texture in the DEFAULT heap should reside in a Buffer in the Upload heap. You then need to use CopyTextureRegion to copy from the buffer into the Texture using either the graphics or copy command queue.

 

When you fill out the D3D12_COPY_TEXTURE_LOCATION corresponding to pSrc you'll want to fill out the D3D12_PLACED_SUBRESOURCE_FOOTPRINT so that D3D knows how the data in your buffer is laid out (eg, Pitch). This is an example from my own code:

D3D12_PLACED_SUBRESOURCE_FOOTPRINT footprint = {};
footprint.Footprint.Width = textureWidth;
footprint.Footprint.Height = textureHeight;
footprint.Footprint.Depth = 1;
footprint.Footprint.RowPitch = uploadBufferRowPitchInBytes;
footprint.Footprint.Format = textureFormat;

copyCommandList->Reset();

CD3DX12_TEXTURE_COPY_LOCATION src(textureUploadBuffer, footprint);
CD3DX12_TEXTURE_COPY_LOCATION dest(defaultHeapTexture, 0);

copyCommandList->CopyTextureRegion(&dest, 0, 0, 0, &src, nullptr);
Edited by Adam Miles

Share this post


Link to post
Share on other sites

Thanks. Why are we using copyCommandList here? Can I use my CommandList created in the initialization part. Sorry if my doubt is silly, I'm new to D3D..

Share this post


Link to post
Share on other sites

I use a CommandList on the Copy queue in order that it can be uploaded to the GPU in parallel with 3D/Graphics work executing on the Graphics (Direct) command queue. As I said in my previous answer, you're free to use a Direct command list if you wish. If you're just uploading a handful of textures are startup then there's no problem doing that.

 

It's worth saying that if you're new to D3D as a whole then starting with 12 may not be the best choice. I'm not one to put someone off trying D3D12 if they're interested, but D3D11 isn't going anywhere and is perfectly fine for the vast majority of 3D graphics applications if you're looking for something a little easier to work with.

Edited by Adam Miles

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement