• Advertisement
  • Popular Tags

  • Popular Now

  • Advertisement
  • Similar Content

    • By Jason Smith
      While working on a project using D3D12 I was getting an exception being thrown while trying to get a D3D12_CPU_DESCRIPTOR_HANDLE. The project is using plain C so it uses the COBJMACROS. The following application replicates the problem happening in the project.
      #define COBJMACROS #pragma warning(push, 3) #include <Windows.h> #include <d3d12.h> #include <dxgi1_4.h> #pragma warning(pop) IDXGIFactory4 *factory; ID3D12Device *device; ID3D12DescriptorHeap *rtv_heap; int WINAPI wWinMain(HINSTANCE hinst, HINSTANCE pinst, PWSTR cline, int cshow) { (hinst), (pinst), (cline), (cshow); HRESULT hr = CreateDXGIFactory1(&IID_IDXGIFactory4, (void **)&factory); hr = D3D12CreateDevice(0, D3D_FEATURE_LEVEL_11_0, &IID_ID3D12Device, &device); D3D12_DESCRIPTOR_HEAP_DESC desc; desc.NumDescriptors = 1; desc.Type = D3D12_DESCRIPTOR_HEAP_TYPE_RTV; desc.Flags = D3D12_DESCRIPTOR_HEAP_FLAG_NONE; desc.NodeMask = 0; hr = ID3D12Device_CreateDescriptorHeap(device, &desc, &IID_ID3D12DescriptorHeap, (void **)&rtv_heap); D3D12_CPU_DESCRIPTOR_HANDLE rtv = ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart(rtv_heap); (rtv); } The call to ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart throws an exception. Stepping into the disassembly for ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart show that the error occurs on the instruction
      mov  qword ptr [rdx],rax
      which seems odd since rdx doesn't appear to be used. Any help would be greatly appreciated. Thank you.
       
    • By lubbe75
      As far as I understand there is no real random or noise function in HLSL. 
      I have a big water polygon, and I'd like to fake water wave normals in my pixel shader. I know it's not efficient and the standard way is really to use a pre-calculated noise texture, but anyway...
      Does anyone have any quick and dirty HLSL shader code that fakes water normals, and that doesn't look too repetitious? 
    • By turanszkij
      Hi,
      I finally managed to get the DX11 emulating Vulkan device working but everything is flipped vertically now because Vulkan has a different clipping space. What are the best practices out there to keep these implementation consistent? I tried using a vertically flipped viewport, and while it works on Nvidia 1050, the Vulkan debug layer is throwing error messages that this is not supported in the spec so it might not work on others. There is also the possibility to flip the clip scpace position Y coordinate before writing out with vertex shader, but that requires changing and recompiling every shader. I could also bake it into the camera projection matrices, though I want to avoid that because then I need to track down for the whole engine where I upload matrices... Any chance of an easy extension or something? If not, I will probably go with changing the vertex shaders.
    • By NikiTo
      Some people say "discard" has not a positive effect on optimization. Other people say it will at least spare the fetches of textures.
       
      if (color.A < 0.1f) { //discard; clip(-1); } // tons of reads of textures following here // and loops too
      Some people say that "discard" will only mask out the output of the pixel shader, while still evaluates all the statements after the "discard" instruction.

      MSN>
      discard: Do not output the result of the current pixel.
      clip: Discards the current pixel..
      <MSN

      As usual it is unclear, but it suggests that "clip" could discard the whole pixel(maybe stopping execution too)

      I think, that at least, because of termal and energy consuming reasons, GPU should not evaluate the statements after "discard", but some people on internet say that GPU computes the statements anyways. What I am more worried about, are the texture fetches after discard/clip.

      (what if after discard, I have an expensive branch decision that makes the approved cheap branch neighbor pixels stall for nothing? this is crazy)
    • By NikiTo
      I have a problem. My shaders are huge, in the meaning that they have lot of code inside. Many of my pixels should be completely discarded. I could use in the very beginning of the shader a comparison and discard, But as far as I understand, discard statement does not save workload at all, as it has to stale until the long huge neighbor shaders complete.
      Initially I wanted to use stencil to discard pixels before the execution flow enters the shader. Even before the GPU distributes/allocates resources for this shader, avoiding stale of pixel shaders execution flow, because initially I assumed that Depth/Stencil discards pixels before the pixel shader, but I see now that it happens inside the very last Output Merger state. It seems extremely inefficient to render that way a little mirror in a scene with big viewport. Why they've put the stencil test in the output merger anyway? Handling of Stencil is so limited compared to other resources. Does people use Stencil functionality at all for games, or they prefer discard/clip?

      Will GPU stale the pixel if I issue a discard in the very beginning of the pixel shader, or GPU will already start using the freed up resources to render another pixel?!?!



       
  • Advertisement
  • Advertisement
Sign in to follow this  

DX12 [DX12] root constant and shader linkage question

This topic is 750 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

So I have a root signature with a descriptor table with an SRV, and two float 3 constants afterwards.
 
Code looks like:
 

        D3D12_ROOT_PARAMETER param[3];
        param[0].ParameterType = D3D12_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE;
        param[0].DescriptorTable.NumDescriptorRanges = 1;
        param[0].DescriptorTable.pDescriptorRanges = range;
        param[0].ShaderVisibility = D3D12_SHADER_VISIBILITY_PIXEL;

        param[1].ParameterType = D3D12_ROOT_PARAMETER_TYPE_32BIT_CONSTANTS;
        param[1].Constants.Num32BitValues = 3;
        param[1].Constants.RegisterSpace = 0;
        param[1].Constants.ShaderRegister = 0;
        param[1].ShaderVisibility = D3D12_SHADER_VISIBILITY_VERTEX;

        param[2].ParameterType = D3D12_ROOT_PARAMETER_TYPE_32BIT_CONSTANTS;
        param[2].Constants.Num32BitValues = 3;
        param[2].Constants.RegisterSpace = 0;
        param[2].Constants.ShaderRegister = 1;
        param[2].ShaderVisibility = D3D12_SHADER_VISIBILITY_VERTEX;

 

Later on before I draw the objects I set the constants:

            gfx->SetGraphicsRoot32BitConstants(1, 3, constant1, 0);
            gfx->SetGraphicsRoot32BitConstants(2, 3, constant2, 0);

and in the shader I have something like this but it doesn't seem to work at all.

float3 constant1 : register(b0);
float3 constant2 : register(b1);

Whatever is in constant1 seems to work fine but constant2 doesn't have the correct values. What am I missing here? I assumed from the MSDN docs that the first constant in the root signature would be b0 and the second one would be b1. Is that not how it works or is there some kind of minimum alignment of 4 DWORDs?

Share this post


Link to post
Share on other sites
Advertisement

Yeah either way I tried c too but the fact that it's a separate entry in the root descriptor table would make it a separate buffer right? Maybe with the way the constants are loaded into the shader registers on the gpu for the global register file or something it could happen to work with Cs but that probably wouldn't be correct. I'm assuming the way everything is laid out based on the root descriptor above it would be something like [t0, b0, b1] right? It's hard to believe that it's an nvidia AND intel driver bug so I must be doing something wrong here.

Share this post


Link to post
Share on other sites

Yeah whoops I was mistaken, I'm pretty sure b is right. Maybe try the visual studio graphics debugger? It should show the constant memory.

Edited by Dingleberry

Share this post


Link to post
Share on other sites

Ok I ran the graphics debugger. Pretty sweet. Makes sense why it's not working, but why does the shader compiler turn constants I declared as b0 and b1 into 1 constant buffer, is that a bug or is my syntax wrong?

 

 

It looks like the shader compiles

 

float3 constant1 : register(b0);
float3 constant2 : register(b1);

 

into something like this (which is not what I was expecting):

// cbuffer $Globals
// {
//
//   float3 constant1;                  // Offset:    0 Size:    12
//   float3 constant2;                  // Offset:   16 Size:    12
//
// }
//
//
// Resource Bindings:
//
// Name                                 Type  Format         Dim      ID      HLSL Bind  Count
// ------------------------------ ---------- ------- ----------- ------- -------------- ------
// $Globals                          cbuffer      NA          NA     CB0            cb0      1
//

While my root descriptor table looks like:

Root Descriptor Table
Descriptor Range Count 1 Descriptor Ranges
[0]
Descriptor Range Type D3D12_DESCRIPTOR_RANGE_SRV Descriptor Range Count 1 Descriptor Range Base Shader Register 0 Descriptor Range Register Space 0 Descriptor Range Offset 0
[1]
Root Parameter Type 32BIT_CONSTANTS Root Parameter Shader Visibility VERTEX Root Constants
Root Constants Shader Register 0 Root Constants Register Space 0 Root Constants Int32 Count 3
[2]
Root Parameter Type 32BIT_CONSTANTS Root Parameter Shader Visibility VERTEX Root Constants
Root Constants Shader Register 1 Root Constants Register Space 0 Root Constants Int32 Count 3

Share this post


Link to post
Share on other sites

Yeah I think my syntax is just wrong for constant buffers. The syntax below works as expected with my root signature. Thanks for the help guys!

cbuffer MyBuffer1 : register(b0)
{
    float3 constant1;
};

cbuffer MyBuffer2 : register(b1)
{
    float3 constant2;
};

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement