Sign in to follow this  
DustinB

DX12 [D3D12] Problems loading pre-compiled shaders

Recommended Posts

I am attempting to load pre-compiled shaders and create a PSO.  The moment I go to create the PSO, I receive the following D3D12 Error:

D3D12 ERROR: ID3D12Device::CreateInputLayout: Encoded Signature size doesn't match specified size. [ STATE_CREATION ERROR #63: CREATEINPUTLAYOUT_UNPARSEABLEINPUTSIGNATURE].

 

I have the following shaders which compile without errors in VS using Shader Model 5.1:

//VertexShader.hlsl

#include "PSInput.hlsli"

PSInput VSMain(float4 position : POSITION, float4 color : COLOR)
{
	PSInput result;

	result.position = position;
	result.color = color;

	return result;
}

//-------------------------------------------------
// PixelShader.hlsl

#include "PSInput.hlsli"

float4 PSMain(PSInput input) : SV_TARGET
{
	return input.color;
}

//-------------------------------------------------
// PSInput.hlsli

struct PSInput {
    float4 position : SV_POSITION;
    float4 color : COLOR;
};


.

Below is my code for reading in each shader .cso file and binding the shader bytecode to the PSO descriptor. I've checked that both vertexShaderData and pixelShaderData are non-null and that the data length is greater than zero.  Interestingly vertexShaderDataLength=668 bytes, while pxielShaderDataLength=14368 bytes (much greater than I expected so I wonder if this is something to worry about).

byte * vertexShaderData(nullptr);
uint vertexShaderDataLength(0);
ThrowIfFailed(
    ReadDataFromFile(
        GetAssetFullPath(L"VertexShader.cso").c_str(),
        &vertexShaderData,
        &vertexShaderDataLength
    )
 );


byte * pixelShaderData(nullptr);
uint pixelShaderDataLength(0);
ThrowIfFailed(
    ReadDataFromFile(
        GetAssetFullPath(L"PixelShader.cso").c_str(),
        &pixelShaderData,
        &pixelShaderDataLength
    )
 );

    
D3D12_GRAPHICS_PIPELINE_STATE_DESC psoDesc = {};
psoDesc.InputLayout = { inputElementDescriptor, _countof(inputElementDescriptor) };
psoDesc.pRootSignature = rootSignature;
psoDesc.VS = CD3DX12_SHADER_BYTECODE(vertexShaderData, vertexShaderDataLength);
psoDesc.PS = CD3DX12_SHADER_BYTECODE(pixelShaderData, pixelShaderDataLength);
// fill in remainder psoDesc ... 


device->CreateGraphicsPipelineState (     // <--- Exception Thrown here.
    &psoDesc,
    IID_PPV_ARGS(&pipelineState)
);

.

Since the report error mentioned unparsable input signature, I'll include my input element descriptor as well.  I'm using vertex interleaving with just positions and colors.

// Define the vertex input layout.
D3D12_INPUT_ELEMENT_DESC inputElementDescriptor[2];

// Positions
inputElementDescriptor[0].SemanticName = "POSITION";
inputElementDescriptor[0].SemanticIndex = 0;
inputElementDescriptor[0].Format = DXGI_FORMAT_R32G32B32_FLOAT;
inputElementDescriptor[0].InputSlot = 0;
inputElementDescriptor[0].AlignedByteOffset = 0;
inputElementDescriptor[0].InputSlotClass = D3D12_INPUT_CLASSIFICATION_PER_VERTEX_DATA;
inputElementDescriptor[0].InstanceDataStepRate = 0;

// Colors
inputElementDescriptor[1].SemanticName = "COLOR";
inputElementDescriptor[1].SemanticIndex = 0;
inputElementDescriptor[1].Format = DXGI_FORMAT_R32G32B32_FLOAT;
inputElementDescriptor[1].InputSlot = 0;
inputElementDescriptor[1].AlignedByteOffset = sizeof(float) * 3;
inputElementDescriptor[1].InputSlotClass = D3D12_INPUT_CLASSIFICATION_PER_VERTEX_DATA;
inputElementDescriptor[1].InstanceDataStepRate = 0;

.

The really odd part of this is that my program runs without error when I combine both the VertexShader and PixelShader into a single effects file "shader.hlsl" and compile the shaders at runtime.

ComPtr<ID3DBlob> vertexShader;
ComPtr<ID3DBlob> pixelShader;


// Compile vertex shader
ThrowIfFailed(
    D3DCompileFromFile (
        GetAssetFullPath(L"shaders.hlsl").c_str(),
        nullptr, nullptr, "VSMain", "vs_5_0", 
        compileFlags, 0, &vertexShader, nullptr
    )
);

// Compile pixel shader
ThrowIfFailed (
    D3DCompileFromFile (
        GetAssetFullPath(L"shaders.hlsl").c_str(),
        nullptr, nullptr, "PSMain", "ps_5_0",
        compileFlags, 0, &pixelShader, nullptr
    )
);

Edited by DustinB

Share this post


Link to post
Share on other sites

I tracked down this piece of information stating HLSL changes to Shader Model 5.1 requiring a specified root signature in order to compile shaders offline:

Note  For shader model 5.1 a root signature must be specified in order to compile shaders offline.

https://msdn.microsoft.com/en-us/library/windows/desktop/dn933268(v=vs.85).aspx

 

Specifying Root Signature in HLSL:

https://msdn.microsoft.com/en-us/library/windows/desktop/dn913202(v=vs.85).aspx

 

I'll give this a try and see if it fixes my issues.

Edited by DustinB

Share this post


Link to post
Share on other sites

You don't need to specify a root signature to compile sm 5.1 shaders. I'm pretty sure that bit in the documentation is a mix-up, since it sounds like it comes from the XB1 SDK. I suspect that something is wrong with how you pre-compile the shaders, or with how you load the data.

 

Share this post


Link to post
Share on other sites

Look at your vertex shader params and the input layout: 

//VertexShader.hlsl

#include "PSInput.hlsli"

PSInput VSMain(float4 position : POSITION, float4 color : COLOR)
{
	PSInput result;

	result.position = position;
	result.color = color;

	return result;
}

Since the report error mentioned unparsable input signature, I'll include my input element descriptor as well.  I'm using vertex interleaving with just positions and colors.

// Define the vertex input layout.
D3D12_INPUT_ELEMENT_DESC inputElementDescriptor[2];

// Positions
inputElementDescriptor[0].SemanticName = "POSITION";
inputElementDescriptor[0].SemanticIndex = 0;
inputElementDescriptor[0].Format = DXGI_FORMAT_R32G32B32_FLOAT;
inputElementDescriptor[0].InputSlot = 0;
inputElementDescriptor[0].AlignedByteOffset = 0;
inputElementDescriptor[0].InputSlotClass = D3D12_INPUT_CLASSIFICATION_PER_VERTEX_DATA;
inputElementDescriptor[0].InstanceDataStepRate = 0;

// Colors
inputElementDescriptor[1].SemanticName = "COLOR";
inputElementDescriptor[1].SemanticIndex = 0;
inputElementDescriptor[1].Format = DXGI_FORMAT_R32G32B32_FLOAT;
inputElementDescriptor[1].InputSlot = 0;
inputElementDescriptor[1].AlignedByteOffset = sizeof(float) * 3;
inputElementDescriptor[1].InputSlotClass = D3D12_INPUT_CLASSIFICATION_PER_VERTEX_DATA;
inputElementDescriptor[1].InstanceDataStepRate = 0;

 

You are using float4 for position and color in the vertex shader, but the inputlayout says it's float3.

Share this post


Link to post
Share on other sites

You are using float4 for position and color in the vertex shader, but the inputlayout says it's float3.

 

Which is perfectly fine and results in the shader receiving float4(x, y, z, 1).

Share this post


Link to post
Share on other sites

If I compile those VS and PS shaders offline to an object file I get sizes of 608 and 532 bytes respectively. I'm not sure how you managed to get a 14KB pixel shader object from just "return input.color". Are you sure the size on disk for PixelShader.cso is ~14KB?

 

It seems the bloat in size of the PS was due to setting the "enable debugging information" (/Zi) compiler flag.  I turned this off and the PixelShader.cso file compiled to only 532 bytes, matching your size output (I verified this from the filesystem as well).  I also tried disabling debugging information for my VS and VertexShader.cso is only 176 bytes.  With debugging information turned off I am still getting the D3D12 error.

 

As MJP mentioned, this definitely seems to be an issue only with compiling offline.  If I compile the shaders at runtime there are no D3D12 errors.

Edited by DustinB

Share this post


Link to post
Share on other sites

I've filed a bug and asked that this yellow box be removed from the documentation; it does indeed refer to the Xbox One XDK.

 

Using float4 in the shader is fine, it'll simply insert 1.0f into the 'w' channel.

 

Adam, is there an official link for filing bugs?  It would be nice to see if any DX team members could chime in. 

Edited by DustinB

Share this post


Link to post
Share on other sites

Adam, is there an official link for filing bugs?  It would be nice to see if any DX team members could chime in. 

 

At the bottom of every MSDN page there's a "Was this page helpful?", click No and explain in the Additional Feedback box what's up and we'll get it fixed.

 

I've had a look at the code you've posted and nothing obvious stands out, but nothing beats a standalone, single-file repro of the issue and then I/we can run it for ourselves and find out what's up.

Edited by Adam Miles

Share this post


Link to post
Share on other sites

I've had a look at the code you've posted and nothing obvious stands out, but nothing beats a standalone, single-file repro of the issue and then I/we can run it for ourselves and find out what's up.

 

Sure thing.  Here's a branch of the code that reproduces the issue: https://github.com/dustin-biser/D3D12-Demos/tree/PrecompiledShaders  Error is generated at the line creating the PSO, PrecompiledShaders.cpp:469 

 

Thanks for your help!

Edited by DustinB

Share this post


Link to post
Share on other sites

Your VertexShader.hlsl is marked as not having a "Shader Type" in Visual Studio's properties, so it's defaulting to vs_2_0 as a consequence. Set that to "Vertex Shader /vs" and you should get a shader that's much nearer my 600+ bytes and compiled correctly as Shader Model 5.1.

 

A square appears in the screen after this is fixed.

Share this post


Link to post
Share on other sites

Your VertexShader.hlsl is marked as not having a "Shader Type" in Visual Studio's properties, so it's defaulting to vs_2_0 as a consequence. Set that to "Vertex Shader /vs" and you should get a shader that's much nearer my 600+ bytes and compiled correctly as Shader Model 5.1.

 

A square appears in the screen after this is fixed.

 

Adam, thanks a lot for your help with this.  I triple checked my shader settings, but some how missed this.  I really appreciate your help.  Is working on my end as well.

Edited by DustinB

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628294
    • Total Posts
      2981882
  • Similar Content

    • By lubbe75
      I am looking for some example projects and tutorials using sharpDX, in particular DX12 examples using sharpDX. I have only found a few. Among them the porting of Microsoft's D3D12 Hello World examples (https://github.com/RobyDX/SharpDX_D3D12HelloWorld), and Johan Falk's tutorials (http://www.johanfalk.eu/).
      For instance, I would like to see an example how to use multisampling, and debugging using sharpDX DX12.
      Let me know if you have any useful examples.
      Thanks!
    • By lubbe75
      I'm writing a 3D engine using SharpDX and DX12. It takes a handle to a System.Windows.Forms.Control for drawing onto. This handle is used when creating the swapchain (it's set as the OutputHandle in the SwapChainDescription). 
      After rendering I want to give up this control to another renderer (for instance a GDI renderer), so I dispose various objects, among them the swapchain. However, no other renderer seem to be able to draw on this control after my DX12 renderer has used it. I see no exceptions or strange behaviour when debugging the other renderers trying to draw, except that nothing gets drawn to the area. If I then switch back to my DX12 renderer it can still draw to the control, but no other renderers seem to be able to. If I don't use my DX12 renderer, then I am able to switch between other renderers with no problem. My DX12 renderer is clearly messing up something in the control somehow, but what could I be doing wrong with just SharpDX calls? I read a tip about not disposing when in fullscreen mode, but I don't use fullscreen so it can't be that.
      Anyway, my question is, how do I properly release this handle to my control so that others can draw to it later? Disposing things doesn't seem to be enough.
    • By Tubby94
      I'm currently learning how to store multiple objects in a single vertex buffer for efficiency reasons. So far I have a cube and pyramid rendered using ID3D12GraphicsCommandList::DrawIndexedInstanced; but when the screen is drawn, I can't see the pyramid because it is drawn inside the cube. I'm told to "Use the world transformation matrix so that the box and pyramid are disjoint in world space".
       
      Can anyone give insight on how this is accomplished? 
       
           First I init the verts in Local Space
      std::array<VPosData, 13> vertices =     {         //Cube         VPosData({ XMFLOAT3(-1.0f, -1.0f, -1.0f) }),         VPosData({ XMFLOAT3(-1.0f, +1.0f, -1.0f) }),         VPosData({ XMFLOAT3(+1.0f, +1.0f, -1.0f) }),         VPosData({ XMFLOAT3(+1.0f, -1.0f, -1.0f) }),         VPosData({ XMFLOAT3(-1.0f, -1.0f, +1.0f) }),         VPosData({ XMFLOAT3(-1.0f, +1.0f, +1.0f) }),         VPosData({ XMFLOAT3(+1.0f, +1.0f, +1.0f) }),         VPosData({ XMFLOAT3(+1.0f, -1.0f, +1.0f) }),         //Pyramid         VPosData({ XMFLOAT3(-1.0f, -1.0f, -1.0f) }),         VPosData({ XMFLOAT3(-1.0f, -1.0f, +1.0f) }),         VPosData({ XMFLOAT3(+1.0f, -1.0f, -1.0f) }),         VPosData({ XMFLOAT3(+1.0f, -1.0f, +1.0f) }),         VPosData({ XMFLOAT3(0.0f,  +1.0f, 0.0f) }) } Then  data is stored into a container so sub meshes can be drawn individually
      SubmeshGeometry submesh; submesh.IndexCount = (UINT)indices.size(); submesh.StartIndexLocation = 0; submesh.BaseVertexLocation = 0; SubmeshGeometry pyramid; pyramid.IndexCount = (UINT)indices.size(); pyramid.StartIndexLocation = 36; pyramid.BaseVertexLocation = 8; mBoxGeo->DrawArgs["box"] = submesh; mBoxGeo->DrawArgs["pyramid"] = pyramid;  
      Objects are drawn
      mCommandList->DrawIndexedInstanced( mBoxGeo->DrawArgs["box"].IndexCount, 1, 0, 0, 0); mCommandList->DrawIndexedInstanced( mBoxGeo->DrawArgs["pyramid"].IndexCount, 1, 36, 8, 0);  
      Vertex Shader
       
      cbuffer cbPerObject : register(b0) { float4x4 gWorldViewProj; }; struct VertexIn { float3 PosL : POSITION; float4 Color : COLOR; }; struct VertexOut { float4 PosH : SV_POSITION; float4 Color : COLOR; }; VertexOut VS(VertexIn vin) { VertexOut vout; // Transform to homogeneous clip space. vout.PosH = mul(float4(vin.PosL, 1.0f), gWorldViewProj); // Just pass vertex color into the pixel shader. vout.Color = vin.Color; return vout; } float4 PS(VertexOut pin) : SV_Target { return pin.Color; }  

    • By mark_braga
      I am confused why this code works because the lights array is not 16 bytes aligned.
      struct Light {     float4 position;     float radius;     float intensity; // How does this work without adding // uint _pad0, _pad1; }; cbuffer lightData : register(b0) {     uint lightCount;     uint _pad0;     uint _pad1;     uint _pad2; // Shouldn't the shader be not able to read the second element in the light struct // Because after float intensity, we need 8 more bytes to make it 16 byte aligned?     Light lights[NUM_LIGHTS]; } This has erased everything I thought I knew about constant buffer alignment. Any explanation will help clear my head.
      Thank you
    • By HD86
      I don't know in advance the total number of textures my app will be using. I wanted to use this approach but it turned out to be impractical because D3D11 hardware may not allow binding more than 128 SRVs to the shaders. Next I decided to keep all the texture SRV's in a default heap that is invisible to the shaders, and when I need to render a texture I would copy its SRV from the invisible heap to another heap that is bound to the pixel shader, but this also seems impractical because ID3D12Device::CopyDescriptorsSimple cannot be used in a command list. It executes immediately when it is called. I would need to close, execute and reset the command list every time I need to switch the texture.
      What is the correct way to do this?
  • Popular Now