• Advertisement
Sign in to follow this  

Unity Object reference not set to an instance of an object

This topic is 672 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I'm having this problem in Unity when trying to initialize a few variables. I have an example below.

 

public class PlanetDetails
    {
        private int planetID;
        private string planetName;

        public int PlanetID
        {
            get { return planetID; }
            set { planetID = value; }
        }

        public string PlanetName
        {
            get { return planetName; }
            set { planetName = value; }
        }
    }

 

PlanetDetails[] Planet = new PlanetDetails[10];
 

...

 

Planet.PlanetID = (System.SystemID + Random.Range(0, 1000));
Planet.PlanetName = "Test" + i;
Debug.Log(Planet.PlanetID);
Debug.Log(Planet.PlanetName);

 

When I try to initialize a variable, it gives me an error in Unity, and since I'm pretty new to programming,  I can't understand why. Any help would be great.

Share this post


Link to post
Share on other sites
Advertisement
Planet[i] = new PlanetDetails();
You can only skip that step if you're using an array of value types (int, bool, float, enum, struct - basically everything that's not a class).

When you make an array, its entries are all set to the "default" value of the corresponding type.

int: 0
float: 0.0f
double: 0.0
all the other numeric and enum types = whatever their concept of 0 is.
bool: false
class: null
struct: non-null, each individual field = its own default

In this case you have a class, so the default is null; You need to individually 'new' each element in the array. Edited by Nypyren

Share this post


Link to post
Share on other sites

What is the exact error message, and what line is it on?

 

NullReferenceException: Object reference not set to an instance of an object
GameGUISystemDetails.Start () (at Assets/Scripts/GameGUISystemDetails.cs:157)

 

The line is this: Planet.PlanetID = (System.SystemID + Random.Range(0, 1000));

If I comment this line, the warning will go to the next line, which is the initialization of Planet.PlanetName and so on.

Share this post


Link to post
Share on other sites

So the problem is that you are expecting the elements of the array to be there, but they're not.  You're only allocating the space for the elements in your array, you then need to put something there.  

PlanetDetails[] Planet = new PlanetDetails[10];
for(int i=0; i<10;i++)
  Planet[i]=new PlanetDetails();

Cheers, 

 

Bob

Share this post


Link to post
Share on other sites

So the problem is that you are expecting the elements of the array to be there, but they're not.  You're only allocating the space for the elements in your array, you then need to put something there.  

PlanetDetails[] Planet = new PlanetDetails[10];
for(int i=0; i<10;i++)
  Planet[i]=new PlanetDetails();

 

:D Thank you, I completely forgot about that ...

Share this post


Link to post
Share on other sites

The Linq based solution is below, I prefer as less "moving parts" to screw up :)

 

PlanetDetails[] Planet = Enumerable.Repeat(0, 10).Select(_ => new PlanetDetails()).ToArray();

 

I am using _ as the select variable passed in as it is not used

Share this post


Link to post
Share on other sites

As a follow up, in the above Range and Repeat are interchangeable given we are not using the value in _

 

var Planet = Enumerable.Repeat(0, 10).Select(=> new PlanetDetails()).ToArray();

 

 

var Planet = Enumerable.Range(0, 10).Select(=> new PlanetDetails()).ToArray();

 

There is a more subtle use of repeat

 

Func<PlanetDetails> buildPlanet = () => new PlanetDetails();

var Planet = Enumerable.Repeat(buildPlanet, 10).Select(build => build()).ToArray()

 

This returns the same planet factory 10 times, we then call the builder in each case and slot the results into an array

 

:)

Share this post


Link to post
Share on other sites
Just curious: My C# is rusty, but isn't there anything like this?
 
private static IEnumerable<T> Generate(Func<T> f) {
    while (true) yield return f();
}

Used like so:
 
var Planets = Generate(() => new PlanetDetails()).Take(10).ToArray();

Feels a bit more straightforward than WozNZ's suggestions. Edited by kloffy

Share this post


Link to post
Share on other sites

Just curious: My C# is rusty, but isn't there anything like this?
 

private static IEnumerable<T> Generate(Func<T> f) {
    while (true) yield return f();
}
Used like so:
 
var Planets = Generate(() => new PlanetDetails()).Take(10).ToArray();
Feels a bit more straightforward than WozNZ's suggestions.

 

 

Nice one, very explicit. For some reason I forgot about using a generator

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By Florencia Sylvester Anelli
      Hi everyone! I've developed a game called The Last Dog (ZOMBIES + DOGS) and was wondering if you could give it a try in order for me to analyse your behaviour in analytics. Give it a shot! Please download it here: https://florsyl.wixsite.com/thelastdog2 and let me know if you detect any bugs. VIDEO.3gp
       

       
       
    • By Manuel Berger
      Hello fellow devs!
      Once again I started working on an 2D adventure game and right now I'm doing the character-movement/animation. I'm not a big math guy and I was happy about my solution, but soon I realized that it's flawed.
      My player has 5 walking-animations, mirrored for the left side: up, upright, right, downright, down. With the atan2 function I get the angle between player and destination. To get an index from 0 to 4, I divide PI by 5 and see how many times it goes into the player-destination angle.

      In Pseudo-Code:
      angle = atan2(destination.x - player.x, destination.y - player.y) //swapped y and x to get mirrored angle around the y axis
      index = (int) (angle / (PI / 5));
      PlayAnimation(index); //0 = up, 1 = up_right, 2 = right, 3 = down_right, 4 = down

      Besides the fact that when angle is equal to PI it produces an index of 5, this works like a charm. Or at least I thought so at first. When I tested it, I realized that the up and down animation is playing more often than the others, which is pretty logical, since they have double the angle.

      What I'm trying to achieve is something like this, but with equal angles, so that up and down has the same range as all other directions.

      I can't get my head around it. Any suggestions? Is the whole approach doomed?

      Thank you in advance for any input!
       
    • By devbyskc
      Hi Everyone,
      Like most here, I'm a newbie but have been dabbling with game development for a few years. I am currently working full-time overseas and learning the craft in my spare time. It's been a long but highly rewarding adventure. Much of my time has been spent working through tutorials. In all of them, as well as my own attempts at development, I used the audio files supplied by the tutorial author, or obtained from one of the numerous sites online. I am working solo, and will be for a while, so I don't want to get too wrapped up with any one skill set. Regarding audio, the files I've found and used are good for what I was doing at the time. However I would now like to try my hand at customizing the audio more. My game engine of choice is Unity and it has an audio mixer built in that I have experimented with following their tutorials. I have obtained a great book called Game Audio Development with Unity 5.x that I am working through. Half way through the book it introduces using FMOD to supplement the Unity Audio Mixer. Later in the book, the author introduces Reaper (a very popular DAW) as an external program to compose and mix music to be integrated with Unity. I did some research on DAWs and quickly became overwhelmed. Much of what I found was geared toward professional sound engineers and sound designers. I am in no way trying or even thinking about getting to that level. All I want to be able to do is take a music file, and tweak it some to get the sound I want for my game. I've played with Audacity as well, but it didn't seem to fit the bill. So that is why I am looking at a better quality DAW. Since being solo, I am also under a budget contraint. So of all the DAW software out there, I am considering Reaper or Presonus Studio One due to their pricing. My question is, is investing the time to learn about using a DAW to tweak a sound file worth it? Are there any solo developers currently using a DAW as part of their overall workflow? If so, which one? I've also come across Fabric which is a Unity plug-in that enhances the built-in audio mixer. Would that be a better alternative?
      I know this is long, and maybe I haven't communicated well in trying to be brief. But any advice from the gurus/vets would be greatly appreciated. I've leaned so much and had a lot of fun in the process. BTW, I am also a senior citizen (I cut my programming teeth back using punch cards and Structured Basic when it first came out). If anyone needs more clarification of what I am trying to accomplish please let me know.  Thanks in advance for any assistance/advice.
    • By Yosef BenSadon
      Hi , I was considering this start up http://adshir.com/, for investment and i would like a little bit of feedback on what the developers community think about the technology.
      So far what they have is a demo that runs in real time on a Tablet at over 60FPS, it runs locally on the  integrated GPU of the i7 . They have a 20 000 triangles  dinosaur that looks impressive,  better than anything i saw on a mobile device, with reflections and shadows looking very close to what they would look in the real world. They achieved this thanks to a  new algorithm of a rendering technique called Path tracing/Ray tracing, that  is very demanding and so far it is done mostly for static images.
      From what i checked around there is no real option for real time ray tracing (60 FPS on consumer devices). There was imagination technologies that were supposed to release a chip that supports real time ray tracing, but i did not found they had a product in the market or even if the technology is finished as their last demo  i found was with a PC.  The other one is OTOY with their brigade engine that is still not released and if i understand well is more a cloud solution than in hardware solution .
      Would there  be a sizable  interest in the developers community in having such a product as a plug-in for existing game engines?  How important  is Ray tracing to the  future of high end real time graphics?
    • By bryandalo
      Good day,

      I just wanted to share our casual game that is available for android.

      Description: Fight your way from the ravenous plant monster for survival through flips. The rules are simple, drag and release your phone screen. Improve your skills and show it to your friends with the games quirky ranks. Select an array of characters using the orb you acquire throughout the game.

      Download: https://play.google.com/store/apps/details?id=com.HellmodeGames.FlipEscape&hl=en
       
      Trailer: 
       
  • Advertisement