Jump to content
  • Advertisement
Sign in to follow this  
Solokiller

Incorrect context reference handling in scripthelper addon

This topic is 795 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

The scripthelper addon function ExecuteString doesn't handle context reference counting properly if Prepare returns an error code.

Instead of returning contexts retrieved using asIScriptEngine::RequestContext, it calls release:

// If no context was provided, request a new one from the engine
asIScriptContext *execCtx = ctx ? ctx : engine->RequestContext();
r = execCtx->Prepare(func);
if( r < 0 )
{
	func->Release();
	if( !ctx ) execCtx->Release();
	return r;
}

Normal execution will handle this correctly:

if( !ctx ) engine->ReturnContext(execCtx);

it should use the latter method in both cases.

Share this post


Link to post
Share on other sites
Advertisement
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

We are the game development community.

Whether you are an indie, hobbyist, AAA developer, or just trying to learn, GameDev.net is the place for you to learn, share, and connect with the games industry. Learn more About Us or sign up!

Sign me up!