• Advertisement
  • Popular Tags

  • Popular Now

  • Advertisement
  • Similar Content

    • By Jason Smith
      While working on a project using D3D12 I was getting an exception being thrown while trying to get a D3D12_CPU_DESCRIPTOR_HANDLE. The project is using plain C so it uses the COBJMACROS. The following application replicates the problem happening in the project.
      #define COBJMACROS #pragma warning(push, 3) #include <Windows.h> #include <d3d12.h> #include <dxgi1_4.h> #pragma warning(pop) IDXGIFactory4 *factory; ID3D12Device *device; ID3D12DescriptorHeap *rtv_heap; int WINAPI wWinMain(HINSTANCE hinst, HINSTANCE pinst, PWSTR cline, int cshow) { (hinst), (pinst), (cline), (cshow); HRESULT hr = CreateDXGIFactory1(&IID_IDXGIFactory4, (void **)&factory); hr = D3D12CreateDevice(0, D3D_FEATURE_LEVEL_11_0, &IID_ID3D12Device, &device); D3D12_DESCRIPTOR_HEAP_DESC desc; desc.NumDescriptors = 1; desc.Type = D3D12_DESCRIPTOR_HEAP_TYPE_RTV; desc.Flags = D3D12_DESCRIPTOR_HEAP_FLAG_NONE; desc.NodeMask = 0; hr = ID3D12Device_CreateDescriptorHeap(device, &desc, &IID_ID3D12DescriptorHeap, (void **)&rtv_heap); D3D12_CPU_DESCRIPTOR_HANDLE rtv = ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart(rtv_heap); (rtv); } The call to ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart throws an exception. Stepping into the disassembly for ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart show that the error occurs on the instruction
      mov  qword ptr [rdx],rax
      which seems odd since rdx doesn't appear to be used. Any help would be greatly appreciated. Thank you.
    • By lubbe75
      As far as I understand there is no real random or noise function in HLSL. 
      I have a big water polygon, and I'd like to fake water wave normals in my pixel shader. I know it's not efficient and the standard way is really to use a pre-calculated noise texture, but anyway...
      Does anyone have any quick and dirty HLSL shader code that fakes water normals, and that doesn't look too repetitious? 
    • By turanszkij
      I finally managed to get the DX11 emulating Vulkan device working but everything is flipped vertically now because Vulkan has a different clipping space. What are the best practices out there to keep these implementation consistent? I tried using a vertically flipped viewport, and while it works on Nvidia 1050, the Vulkan debug layer is throwing error messages that this is not supported in the spec so it might not work on others. There is also the possibility to flip the clip scpace position Y coordinate before writing out with vertex shader, but that requires changing and recompiling every shader. I could also bake it into the camera projection matrices, though I want to avoid that because then I need to track down for the whole engine where I upload matrices... Any chance of an easy extension or something? If not, I will probably go with changing the vertex shaders.
    • By NikiTo
      Some people say "discard" has not a positive effect on optimization. Other people say it will at least spare the fetches of textures.
      if (color.A < 0.1f) { //discard; clip(-1); } // tons of reads of textures following here // and loops too
      Some people say that "discard" will only mask out the output of the pixel shader, while still evaluates all the statements after the "discard" instruction.

      discard: Do not output the result of the current pixel.
      clip: Discards the current pixel..

      As usual it is unclear, but it suggests that "clip" could discard the whole pixel(maybe stopping execution too)

      I think, that at least, because of termal and energy consuming reasons, GPU should not evaluate the statements after "discard", but some people on internet say that GPU computes the statements anyways. What I am more worried about, are the texture fetches after discard/clip.

      (what if after discard, I have an expensive branch decision that makes the approved cheap branch neighbor pixels stall for nothing? this is crazy)
    • By NikiTo
      I have a problem. My shaders are huge, in the meaning that they have lot of code inside. Many of my pixels should be completely discarded. I could use in the very beginning of the shader a comparison and discard, But as far as I understand, discard statement does not save workload at all, as it has to stale until the long huge neighbor shaders complete.
      Initially I wanted to use stencil to discard pixels before the execution flow enters the shader. Even before the GPU distributes/allocates resources for this shader, avoiding stale of pixel shaders execution flow, because initially I assumed that Depth/Stencil discards pixels before the pixel shader, but I see now that it happens inside the very last Output Merger state. It seems extremely inefficient to render that way a little mirror in a scene with big viewport. Why they've put the stencil test in the output merger anyway? Handling of Stencil is so limited compared to other resources. Does people use Stencil functionality at all for games, or they prefer discard/clip?

      Will GPU stale the pixel if I issue a discard in the very beginning of the pixel shader, or GPU will already start using the freed up resources to render another pixel?!?!

  • Advertisement
  • Advertisement
Sign in to follow this  

DX12 [DX12] (Solved) Depth buffer is rendering backwards?

This topic is 591 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I can't for the life of me figure out why my depth buffer is playing up, and it seems like a simple oversight somewhere.


Basically, I'm drawing a series of objects in my scene and can navigate around. What happens is the objects are drawing as if they are behind each-other, with the farthest away objects being drawn through closer ones.


I can "solve" this by setting the depth buffer D3D12_CLEAR_VALUE to 0.0 and performing a D3D12_COMPARISON_FUNC_GREATER_EQUAL instead of D3D12_COMPARISON_FUNC_LESS_EQUAL Everything then renders correctly. However rather than being happy with that, I want to know what's causing this - as it's unusual and does not reflect the behaviour of the DirectX Samples.


My psuedo render loop:

  1. Set gbuffer as active render targets.

  2. Clear gbuffer render textures.

  3. Clear depth buffer.

  4. Draw objects.

  5. Set backbuffer as active render target.

  6. Draw gbuffer result.

In terms of actual code, I suppose the three useful bits here are my depth buffer creation, depth buffer clearing and PSO setup.


Creating the depth buffer:

// Create a resource description for the depth texture.
D3D12_RESOURCE_DESC depthDesc = {};
depthDesc.MipLevels = 1;
depthDesc.Format = DXGI_FORMAT_R32_TYPELESS;
depthDesc.Alignment = 0;
depthDesc.Width = _screenWidth;
depthDesc.Height = _screenHeight;
depthDesc.DepthOrArraySize = 1;
depthDesc.SampleDesc.Count = 1;
depthDesc.SampleDesc.Quality = 0;		
depthDesc.Layout = D3D12_TEXTURE_LAYOUT_UNKNOWN;

D3D12_CLEAR_VALUE* clearVal = new D3D12_CLEAR_VALUE();
clearVal->Format = DXGI_FORMAT_D32_FLOAT;
clearVal->DepthStencil.Depth = 1.0f;
clearVal->DepthStencil.Stencil = 0;

// Create a depth stencil view description.
D3D12_DEPTH_STENCIL_VIEW_DESC stencilDesc = {};
stencilDesc.Format = DXGI_FORMAT_D32_FLOAT;
stencilDesc.ViewDimension = D3D12_DSV_DIMENSION_TEXTURE2D;
stencilDesc.Texture2D.MipSlice = 0;

// Create a shader resource view description.
srvDesc.Shader4ComponentMapping = D3D12_DEFAULT_SHADER_4_COMPONENT_MAPPING;
srvDesc.Format = DXGI_FORMAT_R32_FLOAT;
srvDesc.ViewDimension = D3D12_SRV_DIMENSION_TEXTURE2D;
srvDesc.Texture2D.MipLevels = 1;

LOGFAILEDCOM(_device->CreateCommittedResource(&CD3DX12_HEAP_PROPERTIES(D3D12_HEAP_TYPE_DEFAULT), D3D12_HEAP_FLAG_NONE, &depthDesc, 
	D3D12_RESOURCE_STATE_DEPTH_READ, clearVal, IID_PPV_ARGS(&_pDepthBuffer)));
_device->CreateDepthStencilView(_pDepthBuffer, &stencilDesc, _dsvHeap->GetCPUDescriptorHandleForHeapStart());

DepthBufferIndex = ResourceFactory::GetTextureSlot();
CD3DX12_CPU_DESCRIPTOR_HANDLE srvHandle(_cbvSrvHeap->GetCPUDescriptorHandleForHeapStart(), DepthBufferIndex, D3DUtils::GetSRVDescriptorSize());
_device->CreateShaderResourceView(_pDepthBuffer, &srvDesc, srvHandle);

Clearing the depth buffer (how difficult can it be?):

_commandList->ClearDepthStencilView(_dsvHeap->GetCPUDescriptorHandleForHeapStart(), D3D12_CLEAR_FLAG_DEPTH, 1.0f, 0, 0, nullptr);

PSO (relevant bits):

psoDesc.InputLayout = {&inputLayout[0], UINT(inputLayout.size())};
psoDesc.pRootSignature = _pRootSignature;
psoDesc.VS = {reinterpret_cast<UINT8*>(_pVertexShader->GetBufferPointer()), _pVertexShader->GetBufferSize()};
psoDesc.PS = {reinterpret_cast<UINT8*>(_pPixelShader->GetBufferPointer()), _pPixelShader->GetBufferSize()};
psoDesc.RasterizerState = CD3DX12_RASTERIZER_DESC(D3D12_DEFAULT);
psoDesc.DSVFormat = DXGI_FORMAT_D32_FLOAT;
psoDesc.BlendState = blendState;
psoDesc.SampleMask = UINT_MAX;
psoDesc.SampleDesc.Count = 1;
psoDesc.PrimitiveTopologyType = D3D12_PRIMITIVE_TOPOLOGY_TYPE_TRIANGLE;
psoDesc.DepthStencilState = CD3DX12_DEPTH_STENCIL_DESC(D3D12_DEFAULT);
psoDesc.DepthStencilState.DepthFunc = _depthCheck;
psoDesc.DepthStencilState.DepthEnable = TRUE;
psoDesc.DepthStencilState.StencilEnable = FALSE;
psoDesc.DepthStencilState.DepthWriteMask = _depthWrite;

psoDesc.NumRenderTargets = GBuffer::GBUFFER_NUM_TEXTURES;			
for (size_t i = 0; i < GBuffer::GBUFFER_NUM_TEXTURES; ++i)
	psoDesc.RTVFormats[i] = DXGI_FORMAT_R8G8B8A8_UNORM;
Edited by JJJohan

Share this post

Link to post
Share on other sites

How are you constructing your projection matrix? That sounds like the correct behavior for an inverted projection matrix (far and near plane swapped from traditional way).

Share this post

Link to post
Share on other sites

Ah, you're right. I overlooked my projection matrix!


I am beginning to recall reversing my projection matrix for the depth buffer accuracy for distant objects. It seems then that a clear value of 0 and reversing the depth functions is indeed correct behaviour.


I do feel silly now!

Share this post

Link to post
Share on other sites
Sign in to follow this  

  • Advertisement