DX11 Resolvesubresource, why no error without AA?

Recommended Posts

Posted (edited)

Hi all,

I've just implemented a screenshot function for my engine, using dx11.
This all works fine, also when the rendertarget has MSAA applied, then I use resolvesubresource into an additional rendertarget.

Basically, without AA:

- copy primary RT to RT with usage STAGING and CPU access (staging texture)
- map the RT, copy the pixel data and unmap

And with AA:

- copy primary RT with AA to temporary 1 without AA (usage default, no CPU access) (resolve texture)
- copy temporary RT without AA to new RT with usage STAGING and CPU access (staging texture)
- map the RT, copy the pixel data and unmap

So it all works fine, I applied a branch for MSAA enabled/ disabled.

My question; according to the MSDN documentation, "Resolvesubresource", should only work when 'source' has >1 samples and 'dest' has 1 sample (in the desc). But somehow the process with the resolve texture, including using 'resolvesubresource', also works when I don't have MSAA enabled. So both source + dest has 1 sample.

I would expect the D3D debugger/ logging to give an error or at least a warning.
Below the code in which this applies (don't mind it not being optimized/ cleaned up yet, just for illustration)

std::vector<char> DX11RenderTarget::GetRGBByteArray() const
{
CComPtr<ID3D11Device> myDev;
CComPtr<ID3D11DeviceContext> myDevContext;
mBuffer->GetDevice(&myDev);
myDev->GetImmediateContext(&myDevContext);

// resolve texture
D3D11_TEXTURE2D_DESC tempRTDesc;
tempRTDesc.Width				= mWidth;
tempRTDesc.Height				= mHeight;
tempRTDesc.MipLevels			= 1;
tempRTDesc.ArraySize			= 1;
tempRTDesc.Format				= mDXGIFormat;
tempRTDesc.BindFlags			= 0;
tempRTDesc.MiscFlags			= 0;
tempRTDesc.SampleDesc.Count		= 1;
tempRTDesc.SampleDesc.Quality	= 0;
tempRTDesc.Usage			= D3D11_USAGE_DEFAULT;
tempRTDesc.CPUAccessFlags	= 0;

CComPtr<ID3D11Texture2D> tempTex;
CComPtr<ID3D11Texture2D> anotherTempTex;
myDev->CreateTexture2D(&tempRTDesc, 0, &tempTex);			// add check if(FAILED), logging

myDevContext->ResolveSubresource(tempTex, 0, mBuffer, 0, GetDXGIFormat(mBufferFormat));		// format = DXGI_FORMAT_R8G8B8A8_UNORM_SRGB ; not flexible now

// staging texture
tempRTDesc.Usage				= D3D11_USAGE_STAGING;

myDev->CreateTexture2D(&tempRTDesc, 0, &anotherTempTex);			// add check if(FAILED), logging
myDevContext->CopyResource(anotherTempTex, tempTex);

// map, copy pixels and unmap

std::vector<char> image(mWidth*mHeight*3);

int currPos = 0;
for(size_t row=0;row<mHeight;++row)
{

for(size_t j=0;j<mWidth*4;j+=4)		// RGBA, skip Alpha
{
image[currPos] = texPtr[j];
image[currPos+1] = texPtr[j+1];
image[currPos+2] = texPtr[j+2];
currPos += 3;
}
}
myDevContext->Unmap(anotherTempTex, 0);

return image;
}

Edited by cozzie

Share on other sites

I've known this to work in the past as well. It's probably just for convenience that it was made to work with 1 -> 1 Resolves. It may even boil down to a 'Copy' somewhere further down the stack. I wouldn't complain though!

Create an account

Register a new account

• Forum Statistics

• Total Topics
628372
• Total Posts
2982305
• Similar Content

• By joeblack
Hi,
im reading about specular aliasing because of mip maps, as far as i understood it, you need to compute fetched normal lenght and detect now its changed from unit length. I’m currently using BC5 normal maps, so i reconstruct z in shader and therefore my normals are normalized. Can i still somehow use antialiasing or its not needed? Thanks.
• By 51mon
I want to change the sampling behaviour to SampleLevel(coord, ddx(coord.y).xx, ddy(coord.y).xx). I was just wondering if it's possible without explicit shader code, e.g. with some flags or so?

• Hello,
I want to improve the performance of my game (engine) and some of your helped me to make a GPU Profiler. After creating the GPU Profiler, I started to measure the time my GPU needs per frame. I refined my GPU time measurements to find my bottleneck.
Searching the bottleneck
Rendering a small scene in an Idle state takes around 15.38 ms per frame. 13.54 ms (88.04%) are spent while rendering the scene, 1.57 ms (10.22%) are spent during the SwapChain.Present call (no VSync!) and the rest is spent on other tasks like rendering the UI. I further investigated the scene rendering, since it takes über 88% of my GPU frame rendering time.
When rendering my scene, most of the time (80.97%) is spent rendering my models. The rest is spent to render the background/skybox, updating animation data, updating pixel shader constant buffer, etc. It wasn't really suprising that most of the time is spent for my models, so I further refined my measurements to find the actual bottleneck.
In my example scene, I have five animated NPCs. When rendering these NPCs, most actions are almost for free. Setting the proper shaders in the input layout (0.11%), updating vertex shader constant buffers (0.32%), setting textures (0.24%) and setting vertex and index buffers (0.28%). However, the rest of the GPU time (99.05% !!) is spent in two function calls: DrawIndexed and DrawIndexedInstance.
I searched this forum and the web for other articles and threads about these functions, but I haven't found a lot of useful information. I use SharpDX and .NET Framework 4.5 to develop my game (engine). The developer of SharpDX said, that "The method DrawIndexed in SharpDX is a direct call to DirectX" (Source). DirectX 11 is widely used and SharpDX is "only" a wrapper for DirectX functions, I assume the problem is in my code.
How I render my scene
When rendering my scene, I render one model after another. Each model has one or more parts and one or more positions. For example, a human model has parts like head, hands, legs, torso, etc. and may be placed in different locations (on the couch, on a street, ...). For static elements like furniture, houses, etc. I use instancing, because the positions never change at run-time. Dynamic models like humans and monster don't use instancing, because positions change over time.
When rendering a model, I use this work-flow:
Set vertex and pixel shaders, if they need to be updated (e.g. PBR shaders, simple shader, depth info shaders, ...) Set animation data as constant buffer in the vertex shader, if the model is animated Set generic vertex shader constant buffer (world matrix, etc.) Render all parts of the model. For each part: Set diffuse, normal, specular and emissive texture shader views Set vertex buffer Set index buffer Call DrawIndexedInstanced for instanced models and DrawIndexed models What's the problem
After my GPU profiling, I know that over 99% of the rendering time for a single model is spent in the DrawIndexedInstanced and DrawIndexed function calls. But why do they take so long? Do I have to try to optimize my vertex or pixel shaders? I do not use other types of shaders at the moment. "Le Comte du Merde-fou" suggested in this post to merge regions of vertices to larger vertex buffers to reduce the number of Draw calls. While this makes sense to me, it does not explain why rendering my five (!) animated models takes that much GPU time. To make sure I don't analyse something I wrong, I made sure to not use the D3D11_CREATE_DEVICE_DEBUG flag and to run as Release version in Visual Studio as suggested by Hodgman in this forum thread.
My engine does its job. Multi-texturing, animation, soft shadowing, instancing, etc. are all implemented, but I need to reduce the GPU load for performance reasons. Each frame takes less than 3ms CPU time by the way. So the problem is on the GPU side, I believe.

• I was wondering if someone could explain this to me
I'm working on using the windows WIC apis to load in textures for DirectX 11. I see that sometimes the WIC Pixel Formats do not directly match a DXGI Format that is used in DirectX. I see that in cases like this the original WIC Pixel Format is converted into a WIC Pixel Format that does directly match a DXGI Format. And doing this conversion is easy, but I do not understand the reason behind 2 of the WIC Pixel Formats that are converted based on Microsoft's guide
I was wondering if someone could tell me why Microsoft's guide on this topic says that GUID_WICPixelFormat40bppCMYKAlpha should be converted into GUID_WICPixelFormat64bppRGBA and why GUID_WICPixelFormat80bppCMYKAlpha should be converted into GUID_WICPixelFormat64bppRGBA
In one case I would think that:
GUID_WICPixelFormat40bppCMYKAlpha would convert to GUID_WICPixelFormat32bppRGBA and that GUID_WICPixelFormat80bppCMYKAlpha would convert to GUID_WICPixelFormat64bppRGBA, because the black channel (k) values would get readded / "swallowed" into into the CMY channels
In the second case I would think that:
GUID_WICPixelFormat40bppCMYKAlpha would convert to GUID_WICPixelFormat64bppRGBA and that GUID_WICPixelFormat80bppCMYKAlpha would convert to GUID_WICPixelFormat128bppRGBA, because the black channel (k) bits would get redistributed amongst the remaining 4 channels (CYMA) and those "new bits" added to those channels would fit in the GUID_WICPixelFormat64bppRGBA and GUID_WICPixelFormat128bppRGBA formats. But also seeing as there is no GUID_WICPixelFormat128bppRGBA format this case is kind of null and void
I basically do not understand why Microsoft says GUID_WICPixelFormat40bppCMYKAlpha and GUID_WICPixelFormat80bppCMYKAlpha should convert to GUID_WICPixelFormat64bppRGBA in the end

• Hi, New here.
I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc....
I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn?
How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want?
Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn.
So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started.
Thanks,
Dejay Hextrix

• 10
• 9
• 13
• 24
• 11