Archived

This topic is now archived and is closed to further replies.

Tszafran

Map File Loading

Recommended Posts

Hello, I have a two dimensional structure array, which I try to read from a file and place the contents into the array. CODE: //--------------------------------------------------------------- void LoadMap(void) { char Chr; char filename[20]="map.txt"; int mode=(ios::in); fstream fin(filename,mode); if(!fin) printf("Unable to open file"); while(fin.get(Chr)) { for(int y=0;y<=(MAPHEIGHT-1);y++) { for(int x=0;x<=(MAPWIDTH-1);x++) {Map[x][y].Tile=Chr;} } } fin.close(); } //--------------------------------------------------------------- MAP.TXT: 1111111111111111111111111 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1000000000000000000000001 1111111111111111111111111 I am trying to use {Map[x][y].Tile=Chr;} to put in the integer or char (which ever is easier) value of that character read into that MAP structure array. But for some reason it fills the MAP array structure all with the first character read which is ''1''. Could someone help me out or give me a push in a certain direction? Thanks in advance, GameDev is great, but the community is greater.

Share this post


Link to post
Share on other sites
Actually, it fills your map array with the last character read.

The problem is in the following code:

      
while(fin.get(Chr))
{
for (int y = 0; y <= (MAPHEIGHT - 1); y++)
{
for (int x = 0; x <= (MAPWIDTH - 1); x++)
{
Map[x][y].Tile = Chr;
}
}
}



What this does is read a single character from your file, fills the entire map with it, then repeats until it reaches the end of the file.

Try removing the while loop and modifying the rest like so:

        
for (int y = 0; y < MAPHEIGHT; y++)
{
for (int x = 0; x < MAPHEIGHT; x++)
{
fin.get(Chr);
Map[x][y].Tile = Chr;
}
}


You're also going to have to parse the newline character ('\n') from the input stream at the end of every line, but I'll leave that bit up to you

Game: The Adventure (tm).
-------------------------


Edited by - RabidOcelot on December 19, 2001 3:09:43 AM

Share this post


Link to post
Share on other sites
I usually use good old C fopen,fclose,feof even in C++ so I am not sure but shouldn't you be doing:

    
for(int y=0;y<MAPHEIGHT;y++)
{
for(int x=0;x<MAPWIDTH;x++)
{
if (fin.eof()) break;
fin.get(Chr,1); // Make sure you get just one char

Map[x][y].Tile=Chr;
}
if (fin.eof()) break;
}
//oh yeah, the <MAPHEIGHT is the same as <=(MAPHEIGHT-1) but saves you a substaction operation



instead of the while loop?




Edited by - kwizatz on December 19, 2001 2:57:44 AM

Share this post


Link to post
Share on other sites
Thanks guys, I got the map file loading but have one small problem I could use some help with. My file loads and displays properly but 3 tiles are black for no apparent reason. I checked the code and it seems that all of the structure array is being filled so I have no clue why this happens. Here are my two procedures...

//--------------------------------------------------------------
void LoadMap(void)
{

char ReadChar;
char MapChar[475];
int Count=0;

char filename[20]="map.txt";
int mode=(ios::in);

fstream fin(filename,mode);
if(!fin)
printf("Unable to open map file.");

while(fin.get(ReadChar))
{
MapChar[Count]=ReadChar;
Count++;
}
fin.close();


Count=0;

for(int y=0;y<=(MAPHEIGHT);y++)
{
for(int x=0;x<=(MAPWIDTH);x++)
{Map[x][y].Tile=MapChar[Count];Count++;}
}

}
//--------------------------------------------------------------
void DrawMap(void)
{
int XPOS=0;
int YPOS=0;

for(int y=0;y<=(MAPHEIGHT);y++)
{
for(int x=0;x<=(MAPWIDTH);x++)
{
if(Map[x][y].Tile==int(''0''))
{DrawImage(Grass,XPOS,YPOS);}
else if(Map[x][y].Tile==int(''1''))
{DrawImage(Dirt,XPOS,YPOS);}
else if(Map[x][y].Tile==int(''2''))
{DrawImage(Water,XPOS,YPOS);}
XPOS+=32;
}
XPOS=0;
YPOS+=32;
}
}
//--------------------------------------------------------------

Share this post


Link to post
Share on other sites
You still haven't said your programm what it should do with that '\n'.

fin.getline removes the newline automaticly when i remember correct, but in you case you would have to write something like:

while(fin.get(ReadChar))
{
if (ReadChar != '\n')
{

MapChar[Count]=ReadChar;
Count++;
}

}


Edited by - Jonus on December 20, 2001 5:39:33 AM

Share this post


Link to post
Share on other sites