Back to General and Gameplay Programming

Win32 Windows and classes again. Something wrong...

ANSI2000 · 2002-03-05T08:23:10

We talked about this a while back... I have managed to wrap the win32 code that wraps up the window creation within classes.. But i thought I should give it a try to clean it up a bit a or rearange things they way "I think" they should be.... Of course this failed miserably, can some one look and tell me what is wrong? I want to implement the constructor and create() function as I have them shown, of course this might not be possible... It doesnt seem that the WM_CREATE ever happens.... // g3dgui.h #ifndef G3DGUI_H #define G3DGUI_H // Required include files. #include <windows.h> #include <windowsx.h> namespace G3DGUI { class Object { public: Object(HINSTANCE pInstance, HWND pParent) : instance(pInstance), parent(pParent) {} virtual ~Object() {} const HINSTANCE getInstance() const { return(instance); } const HWND getParent() const { return(parent); } const HWND getHandle() const { return(handle); } const char* getClassName() const { return(className); } const getX() const { return(x); } const getY() const { return(y); } const getWidth() const { return(width); } const getHeight() const { return(height); } const unsigned int getStyleEx() const { return(styleEx); } const unsigned int getStyle() const { return(style); } const char* getCaption() const { return(caption); } void create(const char *pClassName, int pX, int pY, int pWidth, int pHeight, unsigned int pStyle, unsigned int pStyleEx, const char *pCaption) { setClassName(pClassName); setX(pX); setY(pY); setWidth(pWidth); setHeight(pHeight); setStyle(pStyle); setStyleEx(pStyleEx); setCaption(pCaption); windowClass.lpfnWndProc = defaultProc; windowClass.hInstance = getInstance(); windowClass.lpszClassName = getClassName(); windowClass.cbSize = sizeof(WNDCLASSEX); windowClass.cbClsExtra = 0; windowClass.cbWndExtra = 0; windowClass.style = 0; windowClass.hCursor = LoadCursor(0, IDC_ARROW); windowClass.hbrBackground = (HBRUSH)GetStockObject(BLACK_BRUSH); windowClass.hIcon = LoadIcon(0, IDI_APPLICATION); windowClass.hIconSm = LoadIcon(0, IDI_APPLICATION); windowClass.lpszMenuName = 0; registerClass(); handle = CreateWindowEx(getStyleEx(), getClassName(), getCaption(), getStyle(), getX(), getY(), getWidth(), getHeight(), getParent(), NULL, getInstance(), (LPSTR)this); update(); show(); } void update() { UpdateWindow(getHandle()); } void show() { ShowWindow(getHandle(), SW_SHOW); } void hide() { ShowWindow(getHandle(), SW_HIDE); } void focus() { SetFocus(getHandle()); } static LRESULT CALLBACK defaultProc(HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam) { Object *thisObject = (Object*)GetWindowLong(hWnd, GWL_USERDATA); if(!thisObject) { if(Msg == WM_CREATE) { MessageBox(NULL, "WM_CREATE", "WM_CREATE", 0); LPCREATESTRUCT lpcs = (LPCREATESTRUCT)lParam; thisObject = (Object*)lpcs->lpCreateParams; SetWindowLong(hWnd, GWL_USERDATA, (LONG)thisObject); return thisObject->winProc(Msg, wParam, lParam); } else return DefWindowProc(hWnd, Msg, wParam, lParam); // should never be called } else { MessageBox(NULL, "winProc", "winProc", 0); return thisObject->winProc(Msg, wParam, lParam); } } virtual LRESULT winProc(UINT Msg, WPARAM wParam, LPARAM lParam) = 0; protected: void setClassName(const char *pClassName) { className = pClassName; } void setX(int pX) { x = pX; } void setY(int pY) { y = pY; } void setWidth(int pWidth) { width = pWidth; } void setHeight(int pHeight) { height = pHeight; } void setStyle(unsigned int pStyle) { style |= pStyle; } void setStyleEx(unsigned int pStyleEx) { styleEx |= pStyleEx; } void setCaption(const char *pCaption) { caption = pCaption; } bool registerClass() { if(!RegisterClassEx(&windowClass)) return(false); else return(true); } void unRegisterClass() { UnregisterClass(getClassName(), getInstance()); } private: HINSTANCE instance; HWND parent; HWND handle; WNDCLASSEX windowClass; const char* className; const char* caption; int x; int y; int width; int height; unsigned int style; unsigned int styleEx; }; } #endif // g3dgui.cpp //Required include files. //Application include files. #include "g3dgui.h" // Nothing in here all of it is inlined in the g3dgui.h file. //winmain.cpp #include <g3dgui.h> using namespace G3DGUI; bool running = true; class TestWindow : public Object { public: TestWindow(HINSTANCE pInstance, HWND pParent) : Object(pInstance, pParent){} protected: LRESULT winProc(UINT Msg, WPARAM wParam, LPARAM lParam); }; LRESULT TestWindow::winProc(UINT Msg, WPARAM wParam, LPARAM lParam) { switch (Msg) { case WM_CREATE: MessageBox(NULL, "dood", "doods", 0); case WM_DESTROY: PostQuitMessage(0); running = false; break; default: return DefWindowProc(getHandle(), Msg, wParam, lParam); } return 0; } int APIENTRY WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { TestWindow testWindow(hInstance, NULL); testWindow.create("My Window", 10, 10, 100, 100, WS_OVERLAPPEDWINDOW | WS_CLIPSIBLINGS | WS_CLIPCHILDREN, NULL, "My Window"); while(running) { MSG msg; while(PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) { TranslateMessage(&msg;; DispatchMessage(&msg;; } } return(0); }

General and Gameplay Programming Programming

Started by ANSI2000 February 20, 2002 09:47 PM

23 comments, last by ANSI2000 22 years, 1 month ago

ANSI2000

122

Author

February 27, 2002 10:28 AM

Well you can make a constructor "fail" by throwing an exception.

Redleaf

219

February 27, 2002 06:32 PM

ANSI2000 has a point about inducing a constructor failure.

However, ANSI... I don''t think I mentioned this, but I originally intended this to be used for getting a window up and running with very little code, and condensed the abstraction of WNDCLASS with an actual instance of such.

If you wish to make multiple instances, or even a more complex windows-based GUI, you really should separate these abstractions as they should be. Something like Window vs. WindowDesc (or your own analogous term) comes to mind.

If this is the case, I definitely think the separation would be a much cleaner design, and I highly recommend reading the windows programming sections at this site.

For a simple one-window app however, I think you''re still in the clear.

"Don''t be afraid to dream, for out of such fragile things come miracles."

ANSI2000

122

Author

February 28, 2002 09:02 AM

Well for now I just wanted to rearange things a bit in the class the way I understand it. Eventually I will massage it around even more...

Ill check out the link...

Thanks.

Shannon Barber

1,684

March 03, 2002 10:02 PM

If someone hasn''t mentioned it, there''s wxWindows (check sourceforge). It''s a cross-platform GUI, OO widget based IIRC.

You could either use it, or look at thier design for inspiration.

- The trade-off between price and quality does not exist in Japan. Rather, the idea that high quality brings on cost reduction is widely accepted.-- Tajima & Matsubara

ANSI2000

122

Author

March 05, 2002 08:23 AM

Yep seen it... Thanks for reminding me the name

Win32 Windows and classes again. Something wrong...

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Win32 Windows and classes again. Something wrong...

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines