Hello. I´m doing now a little UNO game (you know, the card game in which you have annoying cards as the Draw Two, Reverse, etc.) just for kicks, and to practice the language. The logic is still under work, but right now I have a rather functional game. But there is a thing that I want to work well. You see, the Random class in Java is not good: the Shuffle function for the deck works well for the first 30 or 40 cards, but the rest of the deck is almost untouched. This gives as a result the first 30 cards shuffled and a big zone of ordered yellow, green and blue cards. I´d like to know if you have a good site about this random issue, or a good book, or even a good code! ;-), in short, if you have any useful information about this, I´d be very grateful. Thank you El Cyrax256

Hmm, I''ve never heard of anything like this. And I have seen several done in java. I am actually getting ready to make a black jack trainer. Do you have some code from your shuffle function that we can see? I have a feeling the problem might lay in there first.

Hey when you have a link post it so we can take it for a test drive.

Good luck.

-Just when you think things are starting to look up, life grabs you by the jaws makes you open up wide and sh*ts down your throat.

Here it is a stripped part of the class Deck. It is not complete, but shows you more or less the random function

/**
Class: UNODeck
Description: This class sets the UNO cards
*/
import java.util.*;

class UNODeck {

static int luck = 1;
private Vector cards;

private void initCards(Vector cards) {

for (int i = Card.RED; i != 4; i += 1) {

for (int k = 0; k != 2; k++) {
for (int j = 0; j != 10; j++) {
cards.add(new Card(i, j));
}
}

for (int j = 0; j != 2; j++) {
cards.add(new Card(i, Card.DRAW_TWO));
cards.add(new Card(i, Card.REVERSE));
cards.add(new Card(i, Card.SKIP));
}
}

for (int i = 0; i != 4; i += 1) {
cards.add(Card.NULL, new Card(Card.NULL, Card.WILD));
}

for (int i = 0; i != 4; i += 1) {
cards.add(i, new Card(Card.NULL, Card.WILD_FOUR));
}

shuffleDeck(); //This deals the deck
}

public void shuffleDeck() {
Vector randomDeck = new Vector (cards.size(), 0);

for (int i = 0; i != cards.capacity(); i += 1) {
randomDeck.add(this.getCard(getRandomCard()));
}

cards = randomDeck;
}

private int getRandomCard() {

Random rand = new Random();

int lucky = rand.nextInt(cards.size());

return lucky;
}
}

I´ll probably upload the complete code in my site, check it out next week: http://go.to/elciro

quote:Original post by snowmoon
When you could just do

while(!cards.isEmpty()){
randomDeck.add(this.getCard(rand.nextInt(cards.size())));
}

** Mental note to myself: read the WHOLE Vector page of the API ** :-)

Thanks for the help, I´ll correct that part and I´ll note you any changes. :-)

El Cyrax256