This is my TGA file loader. Can anyone spot any errors? When i use the loader the colors get screwed up. Help? int LoadTGAFile(char* filename, TGAFILE *tgaFile) { FILE* filePtr; // file pointer unsigned char ucharBad; // garbage uchar data short int sintBad; // grabage sint data long imageSize; // size of TGA file int colorMode; // 4 = RGBA, 3 = RGB long imageIdx; // counter variable unsigned char colorSwap; // swap variable filePtr = fopen(filename,"rb"); if (!filePtr) { MessageBox(NULL,"Could not find file", "ERROR", MB_OK); return 0; } fread(&ucharBad, sizeof(unsigned char), 1, filePtr); // read the two first bytes of data fread(&ucharBad, sizeof(unsigned char), 1, filePtr); // cause we don''t need them fread(&tgaFile->imageTypeCode, sizeof(unsigned char), 1, filePtr); if ((tgaFile->imageTypeCode != 2) && (tgaFile->imageTypeCode != 3)) { MessageBox(NULL, "Wrong imageTypeCode", "ERROR", NULL); fclose(filePtr); return 0; } //read 13 bytes of data we don''t need fread(&sintBad, sizeof(short int), 1, filePtr); fread(&sintBad, sizeof(short int), 1, filePtr); fread(&ucharBad, sizeof(unsigned char), 1, filePtr); fread(&sintBad, sizeof(short int), 1, filePtr); fread(&sintBad, sizeof(short int), 1, filePtr); // read height / widht / bit fread(&tgaFile->imageHeight, sizeof(short int), 1, filePtr); fread(&tgaFile->imageWidth, sizeof(short int), 1, filePtr); fread(&tgaFile->bitCount, sizeof(unsigned char), 1, filePtr); colorMode = tgaFile->bitCount /8; imageSize = tgaFile->imageWidth * tgaFile->imageHeight * colorMode; tgaFile->imageData = (unsigned char*)malloc(sizeof(unsigned char)*imageSize); fread(tgaFile->imageData, sizeof(unsigned char), imageSize, filePtr); // change BGR to RGB so we can read the image for (imageIdx = 0; imageIdx < imageSize; imageIdx += colorMode) { colorSwap = tgaFile->imageData[imageIdx]; tgaFile->imageData[imageIdx] = tgaFile->imageData[imageIdx +2]; tgaFile->imageData[imageIdx +2] = colorSwap; } fclose(filePtr); return 1; }

As well as the potential performance issue Cybertron mentioned, I noticed three definate problems with that code:

1. You read height before width - in the TGA file header, width comes before height!!! - it should be:
fread(&tgaFile->imageWidth, sizeof(short int), 1, filePtr);
fread(&tgaFile->imageHeight, sizeof(short int), 1, filePtr);

2. There is one more byte of the header after the bitcount - so you need to read an extra byte after you read the bitcount.

3. In some TGA files, the image data DOES NOT come immediately after the header, there is an option "image ID" chunk followed by an optional "colour map" chunk. The sizes of these chunks are specified in the header.

--
Simon O''Connor
Creative Asylum Ltd
www.creative-asylum.com

thanks for the replies. a given example of a problem is that a TGA file with some snow and mountains has a light shade of green. Other images have wrong colors too.

thanks S1CA. it works just fine:D performance is not an issue yet