#pragma once
template <class DataType>
class Array
{
public:
Array(int p_size);
DataType* m_array;
int m_size;
public:
~Array(void);
};
#include "StdAfx.h"
#include "Array.h"
Array::Array(int p_size)
{
m_array = new DataType[p_size];
m_size = p_size;
}
Array::~Array(void)
{
if (m_array !=0) delete[] m_array;
m_array=0;
}
#include "stdafx.h"
#include "Array.h"
int _tmain(int argc, _TCHAR* argv[])
{
Array <int> intArray(10);
return 0;
}
template <class DataType>Array<DataType>::Array(int p_size){ m_array = new DataType[p_size]; m_size = p_size;}// Array.h#pragma once // Microsoft-specifictemplate <class DataType> class Array{public: // You might prefer "unsigned int" or better, "size_t" to your "int" Array(int p_size) { // What if p_size <= 0? m_array = new DataType[p_size]; m_size = p_size; } // Information hiding anyone? // What if I decide to modify those? DataType* m_array; int m_size;public: ~Array(void) { // Why do this test? your constructor ALWAYS allocates memory. if (m_array !=0) delete[] m_array; // Unnecessary, the object is to be obliterated from your ram in a nanosecond m_array=0; } // Copy constructor anyone? // Assignment operator overloading anyone?};Quote:Original post by jyk
AFAIK, the template argument list must also be included in the function definition, e.g.:template <class DataType>Array<DataType>::Array(int p_size){ m_array = new DataType[p_size]; m_size = p_size;}
Quote:Original post by jyk
AFAIK, the template argument list must also be included in the function definition, e.g.:There are a couple of other funky things about that code that I'll mention:template <class DataType>Array<DataType>::Array(int p_size){ m_array = new DataType[p_size]; m_size = p_size;}
1. Public member data (which doesn't seem like it ought to be public)
2. No use of initializer lists
3. Unnecessary check for null in the destructor
4. Unnecessary assignment of null in the destructor
Quote:Original post by _ArmuT_
What if the new call is unsuccessfull ? Isn't that makes the use of null check at the destructor necessary ?
