Jump to content

View more

Image of the Day

Inventory ! Va falloir trouver une autre couleur pour le cadre D: #AzTroScreenshot #screenshotsaturday https://t.co/PvxhGL7cOH
IOTD | Top Screenshots

The latest, straight to your Inbox.

Subscribe to GameDev.net Direct to receive the latest updates and exclusive content.

Sign up now

Things that are "bad" to do, but go unnoticed

4: Adsense

Old topic!

Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.

  • You cannot reply to this topic
5 replies to this topic

#1 Casey Hardman   Members   


Posted 07 October 2012 - 06:40 PM


I've been scripting/programming for a few years now, and I seem to be progressing rather well. I can do things comfortably and a lot easier than I could before.
I've used C# with XNA a bit, and UnityScript/C# with Unity. I'm familiar with the Unity engine.

However, I didn't really go by the suggested routine: make a simple game and move up. People here frequently suggest that new programmers make a small game, like a Pong game, then move on to something a bit harder. I didn't do that; I just stumbled around making some pieces of a dozen different projects without ever finishing any of the projects. I didn't focus very well, and got sidetracked on lots of stuff.

Now I'm wondering if maybe this entire time, I've been making a lot of mistakes in programming that I couldn't notice, due to my indirect approach at programming.

However, I'm not entirely sure how to go about figuring out if I actually am making mistakes that I don't notice.
I can't just dump a bunch of code on the GameDev community and say "Hey, is there a more efficient way of doing all of this?", and if I try to show smaller blocks of code, how would I know which pieces to show?

So the question is, am I just being paranoid, or should I be worried that I might be doing things wrong without even realizing it? If the code works, does it really matter if I could have done it in 3 less lines, or with 1 less 'if' statement?

Hopefully this doesn't sound completely stupid...I'm just fretting because I've been coding alone for a while, thinking I've been learning and getting better, without really having any 'confirmation' of that by more experienced coders.

Thanks for reading, any help you can give would be appreciated!

#2 frob   Moderators   


Posted 07 October 2012 - 07:06 PM


Yes, you are probably making many mistakes that you will not discover until you get into the professional workplace. That is very common.

Do the best you can with what you know, and keep learning.

Even professionals keep making mistakes and hopefully keep growing. Your entire career should include finding new and creative mistakes.

As you learn new things and apply them, you will slowly have fewer mistakes and better code.

Check out my book, Game Development with Unity, aimed at beginners who want to build fun games fast.

Also check out my personal website at bryanwagstaff.com, where I occasionally write about assorted stuff.

#3 MrDaaark   Members   


Posted 07 October 2012 - 08:26 PM


I learned to program the way you are going about it. I was impatient. It was a mistake.

Among my first projects was a SNES quality RPG. It was working. It had a full tile editor, cutscenes, a title screen. I could walk around, talk to sign posts, talk to NPCs, and transition through maps.

However, the code was horrible! There was so much I didn't understand, and it was all held together with chewing gum. I always focused on just getting stuff up on the screen, and then trying to burrow under it to build the foundation retroactively.

Especially when I jumped into C. I tried to do too much, and fumbled my way around the language instead of reading a good book and following through with the example programs chapter by chapter. I would have progressed so much faster if I had.

Back when I was on the XNA forums, I'd see other people making the same mistake. Most of the new comers there are working on games, and they don't know so many basic things.

They don't know what C# is.

They don't know what a library is (and by extension, what XNA is)

They don't know how classes work, and that the Game1 class in the default generated starting project is a subclassed version of the Game class.

They don't know what reference types are and have no understanding of how or why you can pass around references and have them point at the same thing! This also means they don't know why the resource manager class behaves the way it does. They don't understand that loading the same resource 50 times will just give you 50 references to the same one, and not 50 copies.


So I suggest you work your way through a good C# book, or even just the MSDN tutorials. It will let you know how to write proper code. It will let you know what options and tools are available with all the included classes so that you can make use of them to solve your problems, instead of fumbling through bullshit, held together by chewing gum solutions when you independently re-invent much worse versions of the wheel!

Also, it will let you have a good idea if your code is working well, as intended, and why it does or doesn't work, instead of just 'it works'.

As for 1 line of code vs 3. Everyone will do something in 1 line of code, but will use those other 2 lines of code to do something like validate the input / output. Code that works well is done defensively. Bad code naively assumes everything is going correct. Good code stops and checks the results of everything it attempts.


In a number guessing game, you can prompt the user to enter a number, and then test against their raw input. This code will 'just work', but only until someone enters something you didn't expect! A better way to code that up is to implement a loop that asks for a number, and then keeps asking if the user didn't enter a number in the proper range, or typed out letters instead. That way you don't crash or get strange results when you do your tests on that input.

A lot of early 3D games had console commands to change the field of view. You'd type `fov x and it would change. But a lot of games would crash immediately if you chose an FOV out of range. That's the same problem as above. Assuming good input on the user's part! A good implementation would make sure the FOV argument was between say 35 and 90, and if not, adjust it to the minimum or maximum legal value. Then, you don't crash.

Good code would check the list of supported graphic resolutions, set the most relevant mode, and then check to make sure the mode change went well. Bad code (and lots of old code), naively assumes a default safe resolution and hard codes it in! A lot of old programs now will crash on start up because 320x200 and 640x480 are unsupported on newer hardware and in newer OSes.

Trying to divide by 0 will kill your program instantly! Always do sanity checks before dividing anything.

Don't worry about using too many lines of code. It's a poor measure of program speed. Use a profiler when you are done to find what sections of your code are running the slowest, then work to optimize them later.

Edited by Daaark, 07 October 2012 - 08:29 PM.

#4 Nanook   Members   


Posted 08 October 2012 - 04:07 AM

Start reading books.. They will teach you alot about how to do things right.. Read forums.. use chat.. join a project or start one with a friend or someone online..

Whenever you are unsure of some piece of code, post it on the forums here and describe what you are thinking and ask for suggestions for improvements.

Its always a good idea to start on a project thats possible to finnish. Then its easier to keep the motivation and focus.

You'll never know how to do everything 100% correctly. Keep coding and you'll continue to learn untill you die ;)

Edited by Nanook, 08 October 2012 - 04:08 AM.

#5 Casey Hardman   Members   


Posted 09 October 2012 - 12:51 AM

Thanks for the advice and reassurance!

I think I've picked up on most of the stuff as I went. I don't have as many problems with syntax anymore.

I didn't want to read a tutorial because I didn't think I'd need it, since I already knew a good bit of the general programming syntax from my previous experience. When I was getting into C# from UnityScript, I had noted on a few of the syntax differences already from reading other people's C# code briefly; for example, I knew how to declare variables and functions in C#. So I went with it, looking up the errors I got as I went. Using Google, I soon learned that C# was a bit more strict with value types, and I learned how to typecast and put the 'f' suffix at the end of doubles to turn them into floats. So I picked up simple stuff like that as I went on, rather than reading a tutorial from the get-go (which would probably be a 'cleaner' way of learning).

I'll get into the MSDN tutorials as suggested to fill in the gaps.

#6 ankhd   Members   


Posted 09 October 2012 - 02:20 AM

How to tell if your a good programmer.
if(project is woking how it was designed too 100% of the time)
if(computer is in the same state it was in before you start exe)
return yes you are going ok.
return read some books

Old topic!

Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.