//
/*
*/// Add two values and return the sum
int Add(int a, int b)
{
return (a + b);
}
/*
This
is
all
comment code!
*/
AlexB.hpp, considering your new to the forum I'm not going to get mad at you, but who are you to be talking like you're an expert in C++? It doesn't matter if pointers are more flexible then references, I don't need pointers and I don't plan to use their harder to understand syntax. Also, you should probably realize I AM USING A LIBRARY CALLED SFML AND OMG I'M USING BOUNDING BOX COLLISION. That's why I can't "refactor" my code, and that's probably why you don't understand this:
LogicBall->GetCollision().Intersects(LogicBoard[index]->GetTop())
If you actually used SFML you would know what was going on. You also just signed up for the forum, so I suggest you stop telling people in the beginners
section that their code is:
this if is freaking terrible[/quote]
I'm in the beginners section, do you expect "your" quality code.(That's considering your an actual developer, which I doubt you are.)
I'm saying that if Collision(A bounding box rectangle) intersects one of my blocks I set that block to being hit. If you knew what you were talking about you might understand that.
BUT,
Your interface Manager idea is smart, and I might implement it later. Thank you for your input, just please be less harsh on people in the beginners section.
[/quote]
Wow, reading this response officially makes we never want to help you, ever.
Generally when asking for criticism, it is bad form to jump down someones throat for giving it. You came across as a world class d-bag there.
For the record, the Manager is a bad idea, it adds a layer of unneeded, and most probably, not fully understood abstraction to a design. You are in the learning phases, adhere to the KISS principle of Keep It Simple Stupid. That said, even after you move beyond the learning phase, any class named "Manager" should be a code smell of sorts, setting off your spidey-sense that you are creating a bad design. No, Manager!=Bad, at least, not always, but it very often is.
Also, references should pretty much always be preferred over pointers, until you have a very good reason to act otherwise.
Board.resize(20);
for (int index = 0; index < 20; ++index)
This code is officially dead, I'm going to try something simpler before attempting breakout again. My interface is awful (As the guy above pointed out), and I didn't plan my code at all. I'm going to try to become a better programmer by taking a smaller step, because I bit off more than I could chew.
AlexB.hpp, considering your new to the forum I'm not going to get mad at you, but who are you to be talking like you're an expert in C++? It doesn't matter if pointers are more flexible then references, I don't need pointers and I don't plan to use their harder to understand syntax. Also, you should probably realize I AM USING A LIBRARY CALLED SFML AND OMG I'M USING BOUNDING BOX COLLISION. That's why I can't "refactor" my code, and that's probably why you don't understand this:
LogicBall->GetCollision().Intersects(LogicBoard[index]->GetTop())
If you actually used SFML you would know what was going on. You also just signed up for the forum, so I suggest you stop telling people in the beginners
section that their code is:
this if is freaking terrible[/quote]
I'm in the beginners section, do you expect "your" quality code.(That's considering your an actual developer, which I doubt you are.)
I'm saying that if Collision(A bounding box rectangle) intersects one of my blocks I set that block to being hit. If you knew what you were talking about you might understand that.
BUT,
Your interface Manager idea is smart, and I might implement it later. Thank you for your input, just please be less harsh on people in the beginners section.
[/quote]
Sozz dude, looks like I was a little bit mean.
I'm not an expert but I'm trying to get some experience too. So that's why I wanna give you a little review.
Would you agree if guys will give you some feedbacks on your code to improve it. Your code looks really difficult to understand.
Did you just begin or not, it doesn't matter, 'cause you HAVE to write good code.
Let me tell what I call good code. Good code - when you send it to another programmer with enough skill, he can understand and modify it after few hours of reading.
Sooo that's why I said that that some part of your code freak me out. But ofc your code can be OK.
My suggestion - keep dev it, 'cause you've got nice feedback on it.
[quote name='superman3275' timestamp='1350264118' post='4990203']
AlexB.hpp, considering your new to the forum I'm not going to get mad at you, but who are you to be talking like you're an expert in C++? It doesn't matter if pointers are more flexible then references, I don't need pointers and I don't plan to use their harder to understand syntax. Also, you should probably realize I AM USING A LIBRARY CALLED SFML AND OMG I'M USING BOUNDING BOX COLLISION. That's why I can't "refactor" my code, and that's probably why you don't understand this:
LogicBall->GetCollision().Intersects(LogicBoard[index]->GetTop())
If you actually used SFML you would know what was going on. You also just signed up for the forum, so I suggest you stop telling people in the beginners
section that their code is:
this if is freaking terrible[/quote]
I'm in the beginners section, do you expect "your" quality code.(That's considering your an actual developer, which I doubt you are.)
I'm saying that if Collision(A bounding box rectangle) intersects one of my blocks I set that block to being hit. If you knew what you were talking about you might understand that.
BUT,
Your interface Manager idea is smart, and I might implement it later. Thank you for your input, just please be less harsh on people in the beginners section.
[/quote]
Sozz dude, looks like I was a little bit mean.
I'm not an expert but I'm trying to get some experience too. So that's why I wanna give you a little review.
Would you agree if guys will give you some feedbacks on your code to improve it. Your code looks really difficult to understand.
Did you just begin or not, it doesn't matter, 'cause you HAVE to write good code.
Let me tell what I call good code. Good code - when you send it to another programmer with enough skill, he can understand and modify it after few hours of reading.
Sooo that's why I said that that some part of your code freak me out. But ofc your code can be OK.
My suggestion - keep dev it, 'cause you've got nice feedback on it.
[/quote]
I'm sorry, it was late at night when I made that post. I guess I was annoyed because of all the time I had invested, and when you criticized me that harshly I just felt like all my work was for nothing.
