I have a game class in which I want to initialize a vector of players: Please note that this has to be a reference: It goes like this:

#define GAME_H
#include "player.h"
#include <vector>
#include <iostream>
#include <iterator>

class game
{

public:

	game();
	~game();

	player P;
	std::vector<player>&gPlayerVec;
	std::vector<player>gPlayerVecCopy;

	void PlayGame();




};
#endif //GAME_H

I get the following error when I compile:

c:\mpgames2\pointer\game.cpp(9) : error C2758: 'gPlayerVec' : must be initialized in constructor base/member initializer list
c:\mpgames2\pointer\game.h(17) : see declaration of 'gPlayerVec'
c:\mpgames2\pointer\game.cpp(9) : error C2758: 'gPlayerVecCopy' : must be initialized in constructor base/member initializer list
c:\mpgames2\pointer\game.h(18) : see declaration of 'gPlayerVecCopy'

the game constructor is here:

game::game()
{
	

	gPlayerVec.push_back(P);

}

What do I need to put in there to fix this problem

I may be wrong, but I don't think you can initialise references like that. Is there a vector that it is actually referencing? If so how about putting the line you have for initialising the reference into the argument of the constructor? So you can pass in the reference as you create the game class.

I think Spiro answered the question. I haven't tried to implement his code yet, (but thank you for the help spiro) but I think he is exactly right

What I'm trying to do this: I have a fixed size array of players in player class, then I have a vector of player waiting to get into the game, gPlayerVec, then the game players are in gPlayerVecCopy that are active, This is a vector with players back inserted from gPlayerVec.

When a player sits out he is poped out of the vectors, but the player array keeps track of what would have been his opportunities. When the player comes back in he is pushed back into the vector.

The vectors aren't recognizing the changes that have been made to the player when he is put back in. Or lets say when I try to change a variable directly from the underlying player in the player array, the vectors of players aren't picking up on it.

I think Spiro answered the question. I haven't tried to implement his code yet, (but thank you for the help spiro) but I think he is exactly right

What I'm trying to do this: I have a fixed size array of players in player class, then I have a vector of player waiting to get into the game, gPlayerVec, then the game players are in gPlayerVecCopy that are active, This is a vector with players back inserted from gPlayerVec.

When a player sits out he is poped out of the vectors, but the player array keeps track of what would have been his opportunities. When the player comes back in he is pushed back into the vector.

The vectors aren't recognizing the changes that have been made to the player when he is put back in. Or lets say when I try to change a variable directly from the underlying player in the player array, the vectors of players aren't picking up on it.

Because you are using a vector of players when you should be using a vector of pointers or references to players.

E.g.

vector<Player> player_vec;
Player p("someplayer")
p.setFoo(0);
 
player_vec.push_back(p);
p.setFoo(1);
 
Player p2 = player_vec[0];   
p2.getFoo();  /// returns 0
 

This shoudl be somethign like

vector<Player*> player_vec;
Player p("someplayer")
p.setFoo(0);
 
player_vec.push_back(&p);
p.setFoo(1);
 
Player *p2 = player_vec[0];   
p2->getFoo();  /// returns 1

Edit: Basically what Spiro suggested

Actually Spiro's method of initializing a reference to a vector didn't compile 10 errors. But I'm using visual c++6.0 which is a 1998 compiler, even though it was current up to 2004.

This works, its a mix of both suggestions:

game.h

std::vector<player *>playervec;

player * P

game.cpp

game::game()

{

P = new Player;

gPlayerVec.push_back(P);

}

Now, a change works across all vectors and the underlying player whether initiated from the player or the vector.

Question, Is it worth re-writing the whole program which has grown up with a constant array of Players?

I can accomplish the same thing with an I & J loop setting the requisite elements equal to each other at the end of every game run loop.