Meshes look squished

Ryan Vermeulen · 2012-01-01T16:16:36

Hi All. for some reason the meshes looks to be vertically squashed, the white box if a perfect square. im using GetClientRect to get the size for the back buffer and for the width and height param for the camera. here is a pic of it: [attachment=6574:squished.jpg] here is the code im using for the camera( its a bit messy, but ill get around to cleaning it up later ) #include "StdAfx.h" #include <d3dx9.h> #include "TIPInput_Mouse_Async.h" #include "TIPInput_Keyboard_Async.h" #include "TIPVector3.h" #define PIE D3DX_PI//3.1415926 #define DEG_TO_RAD 0.0174532925 float RadianToDegree( float Radien ) { return Radien * ( 180 / PIE ); } float DegreeToRadian( float Degree ) { return Degree * ( PIE / 180 ); } class Camera { public: TIP::Physics::TIPVector3 Position; TIP::Physics::TIPVector3 Target; TIP::Physics::TIPVector3 Reference; float aspectRatio; float nearPlane; float farPlane; float fieldOfView; D3DXMATRIX Projection; D3DXMATRIX View; float Yaw; float Pitch; TIP::Input::TIPInput_Mouse_Async mStateCashe; int width, height; public: Camera() { nearPlane = 1.0f; farPlane = 1000.0f; fieldOfView = 45.0f; Reference.Z = 1.0f; Target = Reference + Position; Yaw = 0.0f; Pitch = 0.0f; } void Initialize( int ScreenWidth, int ScreenHeight ) { width = ScreenWidth; height = ScreenHeight; aspectRatio = ScreenWidth / ScreenHeight; float rad = D3DX_PI / 4;//DegreeToRadian( fieldOfView ); D3DXMatrixPerspectiveFovLH( &Projection, rad, aspectRatio, nearPlane, farPlane ); SetCursorPos( ScreenWidth / 2, ScreenHeight / 2 ); mStateCashe.GetState(); } void Update( float DeltaTime ) { TIP::Input::TIPInput_Mouse_Async mouse; TIP::Input::TIPInput_Keyboard_Async keyboard; mouse.GetState(); keyboard.GetState(); TIP::Physics::TIPVector3 moveVector; if ( keyboard.IsKeyDown( 'W' ) ) moveVector.Z += 150 * DeltaTime; if ( keyboard.IsKeyDown( 'S' ) ) moveVector.Z -= 150 * DeltaTime; if ( keyboard.IsKeyDown( 'A' ) ) moveVector.X -= 150 * DeltaTime; if ( keyboard.IsKeyDown( 'D' ) ) moveVector.X += 150 * DeltaTime; if ( keyboard.IsKeyDown( VK_CONTROL ) ) moveVector.Y -= 150 * DeltaTime; else if ( keyboard.IsKeyDown( VK_SPACE ) ) moveVector.Y += 150 * DeltaTime; float mouseX = mouse.State.Position_X - mStateCashe.State.Position_X; float mouseY = mouse.State.Position_Y - mStateCashe.State.Position_Y; Pitch += (mouseY * 0.15f) * DeltaTime; Yaw += (mouseX * 0.15f) * DeltaTime; if( Pitch < DegreeToRadian( -89.9f ) ) Pitch = DegreeToRadian( -89.9f ); else if( Pitch > DegreeToRadian( 89.9f ) ) Pitch = DegreeToRadian( 89.9f ); SetCursorPos( width / 2, height / 2 ); D3DXMATRIXA16 ViewRotationMatrix, MoveRotationMatrix, rotx, roty; D3DXMatrixRotationX( &rotx, Pitch ); D3DXMatrixRotationY( &roty, Yaw ); ViewRotationMatrix = rotx * roty; MoveRotationMatrix = roty; D3DXVECTOR3 vec( Reference.X, Reference.Y, Reference.Z ); D3DXVECTOR3 transformedCameraReference; D3DXVec3TransformCoord( &transformedCameraReference, &vec, &ViewRotationMatrix ); D3DXVECTOR3 vec3; vec.x = moveVector.X; vec.y = moveVector.Y; vec.z = moveVector.Z; D3DXVec3TransformCoord( &vec3, &vec, &MoveRotationMatrix ); Position.X += vec3.x; Position.Y += vec3.y; Position.Z += vec3.z; Target.X = transformedCameraReference.x + Position.X; Target.Y = transformedCameraReference.y + Position.Y; Target.Z = transformedCameraReference.z + Position.Z; D3DXVECTOR3 pos, tar, up; pos.x = Position.X; pos.y = Position.Y; pos.z = Position.Z; tar.x = Target.X; tar.y = Target.Y; tar.z = Target.Z; up.x = 0; up.y = 1; up.z = 0; D3DXMatrixLookAtLH( &View, &pos, &tar, &up ); } }; and here is the rendering code for the meshes: void Render( IDirect3DDevice9* g_pd3dDevice, TIP::Physics::TIPVector3 Pos, TIP::Physics::TIPVector3 Rot, float Scale ) { // Set up world matrix D3DXMATRIXA16 matWorld; D3DXMATRIXA16 translation; D3DXMATRIXA16 rotation; D3DXMATRIXA16 scale; D3DXMatrixRotationYawPitchRoll( &rotation, Rot.X, Rot.Y, Rot.Z ); D3DXMatrixTranslation( &translation, Pos.X, Pos.Y, Pos.Z ); D3DXMatrixScaling( &scale, Scale, Scale, Scale ); matWorld = rotation * translation * scale; g_pd3dDevice->SetTransform( D3DTS_WORLD, &matWorld ); // Meshes are divided into subsets, one for each material. Render them in // a loop for( DWORD i = 0; i < NumMaterials; i++ ) { // Set the material and texture for this subset g_pd3dDevice->SetMaterial( &Materials ); g_pd3dDevice->SetTexture( 0, Textures ); // Draw the mesh subset Mesh->DrawSubset( i ); } } what am i doing wrong ? Thanks In Advance. ---edit--- also the window size also seams to affect the way the objects looked. if the window width and height are the same, then the square box looks square like it is supposed to.

Graphics and GPU Programming Programming

Started by ryan20fun January 01, 2012 06:15 AM

9 comments, last by ryan20fun 12 years, 10 months ago

ryan20fun

Author

2,635

January 01, 2012 04:16 PM

I'm starting to think this has to do with your aspect ratio, where you have width/height

Thank You

From initialize():
[source]
aspectRatio = ScreenWidth / ScreenHeight;

[/source]

Both ScreenWidth and ScreenHeight are integers, so you're performing an integer division and the results is thus an integer. That is, your aspect ratio is wrong. Cast the numerator and/or the denominator to a floating point value to perform a floating point division.

Thank You

Never say Never, Because Never comes too soon. - ryan20fun

Disclaimer: Each post of mine is intended as an attempt of helping and/or bringing some meaningfull insight to the topic at hand. Due to my nature, my good intentions will not always be plainly visible. I apologise in advance and assure you I mean no harm and do not intend to insult anyone.

Meshes look squished

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Meshes look squished

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines