Back to For Beginners

shrink code

For Beginners

Started by phil67rpg March 20, 2012 11:55 PM

5 comments, last by phil67rpg 12 years, 1 month ago

phil67rpg

458

Author

March 20, 2012 11:55 PM

is there anyway to condense this code

[font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"] curImage1 = [/font][/font][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"].FromFile([/font][/font][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"]@"c:\Users\phil\Desktop\brick1.bmp"[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"]);[/font][/font]
[font="Consolas"][size="2"][font="Consolas"][size="2"]g.DrawImage(curImage1, 0, 0);[/font][/font]

[font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"] curImage2 = [/font][/font][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"].FromFile([/font][/font][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"]@"c:\Users\phil\Desktop\brick1.bmp"[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"]);[/font][/font]
[font="Consolas"][size="2"][font="Consolas"][size="2"]g.DrawImage(curImage2, 150, 0);[/font][/font]

[font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"] curImage3 = [/font][/font][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"].FromFile([/font][/font][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"]@"c:\Users\phil\Desktop\brick1.bmp"[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"]);[/font][/font]
[font="Consolas"][size="2"][font="Consolas"][size="2"]g.DrawImage(curImage3, 300, 0);[/font][/font]

[font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"] curImage4 = [/font][/font][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"].FromFile([/font][/font][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"]@"c:\Users\phil\Desktop\brick1.bmp"[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"]);[/font][/font]
[font="Consolas"][size="2"][font="Consolas"][size="2"]g.DrawImage(curImage4, 450, 0);[/font][/font]

[font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"] curImage5 = [/font][/font][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"][font="Consolas"][size="2"][color="#2b91af"]Image[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"].FromFile([/font][/font][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"][font="Consolas"][size="2"][color="#a31515"]@"c:\Users\phil\Desktop\brick1.bmp"[/font][/font][/font][font="Consolas"][size="2"][font="Consolas"][size="2"]);[/font][/font]
[font="Consolas"][size="2"][font="Consolas"][size="2"]g.DrawImage(curImage5, 600, 0);[/font][/font]

Washu

7,836

March 21, 2012 12:07 AM

why are you loading the same image 5 times and then drawing it in 5 different positions. Load it once. Draw it five times.

Also, for loop, read up on it.

In time the project grows, the ignorance of its devs it shows, with many a convoluted function, it plunges into deep compunction, the price of failure is high, Washu's mirth is nigh.

phil67rpg

458

Author

March 21, 2012 12:15 AM

thanks washu, that helped,do you know of anywhere I can get help with collision detection and breakout game and c#

Washu

7,836

March 21, 2012 01:10 AM

Coldet depends, but since you're using 2d... I would probably look at something like box2d. Its a 2d physics engine and has C# ports out there (google em). That includes collision and collision response.

In time the project grows, the ignorance of its devs it shows, with many a convoluted function, it plunges into deep compunction, the price of failure is high, Washu's mirth is nigh.

phil67rpg

458

Author

March 21, 2012 01:13 AM

so I should read up on bounding box collision detection?

Washu

7,836

March 21, 2012 01:16 AM

Yes, you should. Its pretty simple (in 2d) but its a nice thing to know and understand. You should read up and understand both OOBB (object oriented bounding boxes) and AABB (axis aligned bounding boxes) and how to perform coldet on them.

In time the project grows, the ignorance of its devs it shows, with many a convoluted function, it plunges into deep compunction, the price of failure is high, Washu's mirth is nigh.

phil67rpg

458

Author

March 21, 2012 01:20 AM

thanks I will