So is there an idiomatic way to remove all items from a map for which some predicate is true?

std::remove_if "removes" items by moving them to the end of a collection and then returns an iterator to the first of the "removed" items so you can erase them or do whatever you want to do. This doesn't work for maps because maps are ordered and therefore you can't just arbitrarily move their contents around.

Is there some way of doing this with standard library algorithms? I just wrote a function but it seemed weird that I had to.

There are no immediate functions in the standard library to do that as far as I am aware. It should, however, be fairly trivial to just make a simple loop and erase elements yourself. Since map iterators are not invalidated on erase, you don't need much effort to keep the loop valid like when you iterate over and erase from, say, a vector.

Also does anyone else just find remove_if broken? I mean why not just get rid of it and have erase_if? Or at least have erase_if and remove_if?

remove_if serves a purpose when the container itself cannot be modified. For example, you can call remove_if on a static array to partition its content into a part with the remaining part and the removed part, and the return value is the pointer to where the second partition starts. An erase_if equivalent would not work on a static array.

Since erase_if can easily be implemented in terms of remove_if and erase, the function itself is not really something fundamental on the same level as remove_if and erase. Although I could definitely agree that it would be nice to have, since remove_if is often called with erase.

I use this function in my code:

//Removes all occurances of elements in the map that have a value that returns true for 'predicate'.
template<typename MapType, typename PredicateFunc>
void MapRemoveValues(MapType &map, PredicateFunc predicate)
{
	for(auto it = std::begin(map); it != std::end(map); )
	{
		if(predicate(it->second))
		{
			it = map.erase(it);
		}
		else
		{
			++it;
		}
	}
}

Just make the predicate take *it instead of it->second.

[Edit:] Whoops, skimming too much. Didn't see you said you already wrote a function.

std::remove_if() has no guarantees whatsoever about whether or not elements at or after the iterator returned by std::remove_if() satisfy or don't satisfy the predicate passed to std::remove_if(). The contents of those elements will be valid in the sense they can be properly destroyed (assuming that the copy assignment/move assignment operator are implemented correctly).