Back to Coding Horrors

for (score and seven; years_ago; ...

Coding Horrors Community

Started by Cornstalks September 24, 2013 11:28 PM

8 comments, last by iAmCodeMonkey 10 years, 6 months ago

Cornstalks

7,033

Author

September 24, 2013 11:28 PM

My coworker just showed me this piece of beauty he wrote in a project for a client. It's gloriously horrible. And hilarious.


#define years_ago (score < 4)
#define and =
#define our_forefathers (score++)
#define seven 0
int score;
 
- (void)setImage:(UIImage *)image
{
    ...
    for (score and seven; years_ago; our_forefathers) {
        GPUImagePicture * stupidlyNamedClassFromALibraryWithNoRegardForDevelopers = [[GPUImagePicture alloc] initWithImage:image];
        ...
    }
}

[size=2][ I was ninja'd 71 times before I stopped counting a long time ago ] [ f.k.a. MikeTacular ] [ My Blog ] [ SWFer: Gaplessly looped MP3s in your Flash games ]

frob

46,226

September 24, 2013 11:48 PM

... he wrote in a project for a client ...

#define years_ago (score < 4)
#define and =
#define our_forefathers (score++)
#define seven 0

And when they do a code review, he might discover they are a FORMER client.

It might look cute, but in a professional environment stunts like that can easily mean losing your job.

Cornstalks

7,033

Author

September 25, 2013 12:13 AM

And when they do a code review, he might discover they are a FORMER client.

It might look cute, but in a professional environment stunts like that can easily mean losing your job.

The client is actually a programmer himself and did a code review, and inserted the comments:


...
// my favorite #define ever.
#define seven 0
int score;
 
- (void)setImage:(UIImage *)image
{
    ...
    // Friggin awesome.
    for (score and seven; years_ago; our_forefathers) {
        ...
    }
}

So I guess it's all good.

[size=2][ I was ninja'd 71 times before I stopped counting a long time ago ] [ f.k.a. MikeTacular ] [ My Blog ] [ SWFer: Gaplessly looped MP3s in your Flash games ]

frob

46,226

September 25, 2013 02:02 AM

Very lucky for him it didn't turn out different.

Sik_the_hedgehog

3,003

September 25, 2013 03:01 AM

Bonus: and is actually a keyword in C++ (inherited from iso646.h then made part of the language), so that macro is effectively changing the language itself. Can't get worse than this.

Reminds me of somebody who found long long ago in a file, except of course in that case it was something perfectly acceptable that happened to fit perfectly (long long is a built-in type, and ago is a variable name). No cheating needed there.

Don't pay much attention to "the hedgehog" in my nick, it's just because "Sik" was already taken =/ By the way, Sik is pronounced like seek, not like sick.

Migi0027

4,632

September 29, 2013 01:42 PM

I, I don't even know what to say...

FastCall22: "I want to make the distinction that my laptop is a whore-box that connects to different network"

Blog about... stuff (GDNet, WordPress): www.gamedev.net/blog/1882-the-cuboid-zone/, cuboidzone.wordpress.com/

stupid_programmer

2,378

September 29, 2013 07:12 PM

Bonus: and is actually a keyword in C++ (inherited from iso646.h then made part of the language), so that macro is effectively changing the language itself. Can't get worse than this.

Reminds me of somebody who found long long ago in a file, except of course in that case it was something perfectly acceptable that happened to fit perfectly (long long is a built-in type, and ago is a variable name). No cheating needed there.

The code is Objective-C so no worries about it being a keyword. But it is Objective-C which is a coding horror of its own. I shudder the days I need to work on iOS stuff at work.