Jump to content

  • Log In with Google      Sign In   
  • Create Account

Banner advertising on our site currently available from just $5!


1. Learn about the promo. 2. Sign up for GDNet+. 3. Set up your advert!


return shared_ptr or Handle ?


Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.

  • You cannot reply to this topic
1 reply to this topic

#1 Tispe   Members   -  Reputation: 1372

Like
0Likes
Like

Posted 20 April 2014 - 01:40 PM

Hi

 

I am refactoring and the Asset Manager has a std::map of all the game resources. But I can't quite think of how I should encapsulate things.

 

An entity manager can for example use the asset manager and call GetResource...(ID) and use it. But should GetResource() return a HANDLE with a shared_ptr inside it, or can I just return the shared_ptr?

 

It seems if I use handles I just put another layer on the cake but it does not do anything.

 

Any tips?

struct GameAssets
{
	std::vector<std::shared_ptr<Mesh> > Meshes;
	std::vector<std::shared_ptr<Texture> > Textures;
	std::vector<std::shared_ptr<Animation> > AnimationTracks;
	std::vector<std::shared_ptr<Skeleton> > Skeletons;
};

struct HandleAssets
{
	std::shared_ptr<GameAssets> Assets;
};

class AssetManager
{
public:
	AssetManager();
	~AssetManager();

	HandleAssets GetResourceByHandle(DWORD ID);
	std::shared_ptr<GameAssets> GetResourceBysptr(DWORD ID);

private:
	std::map<DWORD, HandleAssets > AllAssetsByHandle;
	std::map<DWORD, std::shared_ptr<GameAssets> > AllAssetsBysptr;
};


Sponsor:

#2 L. Spiro   Crossbones+   -  Reputation: 20856

Like
3Likes
Like

Posted 20 April 2014 - 01:49 PM

I am about to head out so I can only give a short answer, but you are correct that the extra layer on the cake is needless.
Just return a shared pointer and be alert as to how to and not to use them (as in passing them as references, not copies, to functions, etc.)


L. Spiro




Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.



PARTNERS