Simple problem

Started by
14 comments, last by dta1 21 years, 5 months ago
quote:Original post by petewood
None of that works (and I want x to be 2 in header.h)


which begs the questions: why do you want x to be 2 in header.h? what does it mean? why do you want a new variable x made in every file that header.h is included?

the explanation of oluseyi''s answer is this:

you want one copy of the variable x to be available to your program. by declaring x in a header you can include that header in places that need to know about x. the statement x = 2 is not a declaration though. it is a definition. whats that? there''s a difference?

the difference:
the declaration will tell your program that somewhere there exists a variable x. it will be able to find it when the program finally links.

the definition will actually declare and define the variable. that variable is the object. you can only have one of them. that''s why it''s a problem to put the definition in the header file.

the solution:
put a definition of the variable in one cpp file.
put a declaration of the variable as ''extern''. this means it will look for it elsewhere at link time (and hopefully find it defined in your cpp file)

Hehe. You took in consistently =)

I wan''t only one x, every file that includes header.h must refer to that header''s x when using and changing it.
This works good if I declare x as a static but when I use extern it doesn''t work. I''ve tried most combinations of it but without luck.

Is anyone perfectly sure of how this should be done?
It''s not a hard question, really. =)
Erase, rewind and improve
Advertisement
cough

have you tried what we''ve said?

if you want x in a header then it can''t be the ''real'' x. the real x has to be in one and only one cpp file.

put int x = 2; in a .cpp
put extern int x; in a .h

make sure the .cpp is in your project.
include the .h wherever you need to know about x.
quote:Is anyone perfectly sure of how this should be done?
It''s not a hard question, really. =)
perfectly sure. are you?
static at file scope to indicate internal linking is deprecated. Use an unnamed namespace.

namespace{  int x = 2;}     



Documents [ GDNet | MSDN | STL | OpenGL | Formats | RTFM | Asking Smart Questions ]
C++ Stuff [ MinGW | Loki | SDL | Boost. | STLport | FLTK | ACCU Recommended Books ]


[edited by - Fruny on November 12, 2002 5:46:46 AM]
"Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." — Brian W. Kernighan
quote:Original post by dta1
I wan''t only one x, every file that includes header.h must refer to that header''s x when using and changing it.

Right, you''ve been shown how to do that.
quote:
This works good if I declare x as a static

No it doesn''t. If you declare it as static (which is deprecated as Fruny points out), then you don''t have "only one x", you have an x for each translation unit it appears in. In fact, your requirements are self-contradictory: you want a single "x", but want that x to have different values at the same time.
quote:
but when I use extern it doesn''t work.

What do you mean "it doesn''t work"? If you want "only one x", then the only way to achieve that is to use the extern keyword, which tells the linker to fix-up each symbol export to the same offset in the stack. If you actually want to have a separate x for each translation unit (which I think is what you want), then you''ve also been shown how to do that.
quote:
Is anyone perfectly sure of how this should be done?

Not whilst you continue to be vague and ambiguous about what you want to achieve.
quote:
It''s not a hard question, really. =)

We''ll be the judges of that. Why don''t you describe the outer problem that makes you want to do this?
To summarize:

header.h

  extern int x;  


header.cpp

  int x = 2;  


main.cpp

  #include <iostream.h>#include "header.h"int main(){   cout << x;   return 0;}  



main2.cpp

  #include <iostream.h>#include "header.h"int func(){   x = 4;   cout << x;   return 0;}  
Ok, thanks.
Didn''t get that thing about making a header.h file.
Erase, rewind and improve

This topic is closed to new replies.

Advertisement