Quote:Original post by deathwearer

Quote:Original post by agi_shi

Quote:Original post by superpig
Why not move all that initialisation out of the constructor and into something like CGameManager::Initialise()? That way you could return true or false directly, and you wouldn't need the extra status variable.

A fake init() function? That's what the constructor is for, initialization! And I need m_Status to return in main, so I don't return any ugly 0's. Plus I can use m_Status as a check, too.

The constructor is more used to Init your attributes (not sure of the english word) to their starting values. e.g m_bGameRunning = true;

The SDL Initialisation should be in a function because this way it can return if the Init was succesfull or no.

Quote:Original post by Zahlman
Throw an exception if something goes wrong in the constructor. Since that's obviously not supposed to happen, it's a valid use of the exception (assuming you can make the ctor exception-safe). Also, the status is *not* going to be "failed" after the main loop ends - if it's possible for something seriously wrong(TM) to happen during that loop, you could throw an exception from there, too. That gets rid of the need for GetStatus() entirely (and it was buggy: (a) it gets called twice at the beginning and we don't know right now that it doesn't have side effects; (b) the return from main is supposed to be 0, i.e. a 'false' value, if everything went ok. The reasoning on that one is that there is only one way for everything to be ok and multiple ways to fail, so the unique 0 value is used for success and non-zero values for error codes. Also sprach POSIX.)

Also, I'd give the game constructor a chance to look at the command-line arguments - you may want that later :)

#include <vector>#include <string>#include <exception> // or should it be <stdexcept>?#include <iostream>using namespace std;int main(int argc, char *argv[]) {  vector<string> arguments(argv, argv + argc); // I think that's right  try {    // I vote against Hungarian notation and I especially hate the 'C'    // prefix for classes. Also, this instance is *not* a global.    GameManager mainGame(arguments);    while (mainGame.doLoop()); // why complicate the interface more than that?  } catch (exception& e) {    cout << "OH NOES!!!11 " << e.what() << endl;    return -1; // some sort of error.    // You could use your own exception class and give it a .errorCode()    // function or something.  }  // 0 is returned implicitly here if no exception happened.}