Finished a program challenge, would like some input please

Sria · 2006-04-22T03:12:32

So, if this is out of the norm and not an appropriate place for this just say so and I'll edit it right out! Anyway I decided to do a challenge out of the book that I got.. The challenge was: Write a program using vectors and iterators that allows a user to maintain a list of his or her favorite games. The program should be able to allow the user to list all titles, add a title, or remove a title. So I set out to do it with the best of my knowledge and this is what I ended up with. Any comments on it would be appreciated (ie point out where things could have been better or anything like that) I can take it so be honest. It's in C++ with Microsoft Visual Studio 2005 //Program to keep and maintain a list of favored games. #include <iostream> #include <vector> #include <string> using namespace std; //function for adding a game to the list. string addGames(string question); //Function for removing a game from the list. int removeGames(string question); //Function for displaying the list void listGames(); int main() { //begin main() //Vector to store the list in. vector<string> gameList; //Iterator refering to objcts in gameList. vector<string>::iterator myGames; //Const int to refer and display the list. vector<string>::const_iterator listGames; string firstName; string quit = "no"; //Welcoming the user cout<<"\t\t\tHello, and Welcome to Sria's game keeper!\n\n"; cout<<"What's your name? "; cin>> firstName; cout<<"\n\nAlright "<< firstName <<", what would you like to do?\n\n\n"; do //Beggining main program loop. { //Stores the choice they make in the menu. int menuChoice; //Displaying the main menu cout<<"\n\n\n1 - Show current games in the list. \n"; cout<<"2 - Add a game to the list. \n"; cout<<"3 - Remove a game from the list. \n"; cout<<"4 - Quit the program. \n"; //End of menu cout<<"\n\nEnter your choice here - "; cin>> menuChoice; //Trivial displaying of what the user chose :) switch(menuChoice) { case 1: system("cls"); cout<<"\n\nBring on the list!"; break; case 2: system("cls"); cout<<"\n\nLets add to the list!"; break; case 3: system("cls"); cout<<"\n\nAlright, let's remove some games!\n\n"; break; case 4: system("cls"); cout<<"\n\nOk, but you're missing out on the most useful program of your lifetime!"; break; default: system("cls"); cout<<"\n\nSorry, but that is not a correct input choice."; break; } //End switch statement //If they chose show list... if (menuChoice == 1) { int gameNum = 0; cout<<"\n\nYour game list is: \n\n"; for (listGames = gameList.begin(); listGames != gameList.end(); ++listGames) { ++gameNum; cout<< gameNum <<" - "<< *listGames << endl; } } //End Show list option //If they Chose add game option. if (menuChoice == 2) { char again = 'y'; do{ string addGame = addGames("\nEnter a new game for your list! \n"); gameList.push_back(addGame); cout<<"\nWould you like to add another game? <y/n> " << endl; cin>>again; }while (again != 'n'); } //End Add game option //If they chose remove game option. if (menuChoice == 3) { char removAgain = 'y'; do { cout<<"Your current game list is : \n\n"; int b = 0; for (listGames = gameList.begin(); listGames != gameList.end(); ++listGames) { ++b; cout<< b << " - " << *listGames << endl; } int remove = removeGames("\nType the number which corresponds with the game you want to remove to have it taken off your list. "); gameList.erase((gameList.begin() + remove) - 1); cout<<"Your updated game list is: \n\n"; int a = 0; for (listGames = gameList.begin(); listGames != gameList.end(); ++listGames) { ++a; cout<< a << " - " << *listGames << endl; } cout<<"\n\nWould you like to remove another game? <y/n> "; cin>>removAgain; }while (removAgain != 'n'); } //End remove game option. //If they chose quit if (menuChoice == 4) quit = "quit"; //end quit option }while (quit != "quit"); cout<<"\n\n"; system("PAUSE"); return 0; } inline string addGames(string question) { string answer; cout<< question <<endl; cin>> answer; return answer; } int removeGames(string question) { int answer; cout<< question << endl; cin>> answer; return answer; } Anyway like I said, if critiquing programs is not something people do (i love art and am used to always having someone more educated/talented critiquing my work) I'll just remove it and we can forget it ever happend ;) But this was really my first project that I went totally solo on and didn't customize examples from the book so I am pleased :) Thanks

For Beginners

Started by Sria April 21, 2006 05:59 PM

9 comments, last by wild_pointer 18 years ago

wild_pointer

291

April 22, 2006 03:12 AM

Just some really general stuff:

You have a bit too much going on in main, there shouldnt be much actual work being done there.

You have a big switch statement thats only purpose is to print a message, why not move all the logic in there (move it into functions first, while you're at it) instead of rechecking menuchoice later?

Declare variables near first use, not all at once at the beginning of a code block (this isn't C89).

Don't use inline. If you understand what it actually means to declare something inline well enough to prove that my previous statement isn't always good advice, then you can use it =)

Please don't let RAZORUNREAL confuse you as far as gameList not being a list goes =P You're correct in your thinking.

[size=2]

Finished a program challenge, would like some input please

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Finished a program challenge, would like some input please

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines