Quote:Original post by SonicD007
Ohhhh. Thats cool. I never even heard of that until now. Also, the get and set functions were for the program to use to give a character power levels and all that. If that's bad coding please point me in a direction on how to improve it because I don't want to get any bad habbits.

class Enemy {  // I prefer to put the private stuff at the top, when possible.  // That's probably unusual, though.  std::string name;  int power_level;  int max_power_level;  int attack;  int defense;  int ki;  int max_ki;  int level;  int zenni;  public:  // A constructor is a function, so the usual rules for parameter passing  // apply: i.e., prefer to pass non-primitives by const reference.  // I would normally put a constructor this straightforward directly into  // the class body, but here I'll separate it out so you see how it's done.  Enemy(const std::string& name, int PL, int atk, int def, int ki, int lvl, int zenni);};Enemy::Enemy(const std::string& name, int PL, int atk, int def, int ki, int lvl, int zenni) :  // Initializer list goes between the colon and the open brace.  // Names outside the parens are the names of members as they were declared  // in your class. Stuff inside the parens are the expressions that will  // initialize those members. In your case, those will just be parameters.  name(name), power_level(PL), max_power_level(PL), attack(atk), defense(def),  ki(ki), max_ki(ki), level(lvl), zenni(zenni)// Constructor body can now be empty.{}

Quote:Original post by SimonForsman

class IntArray{	private:		int m_size;		int * m_data;		// disable copy-constructor and copy-assignment		// operator unless you're goint to implement		// them properly		IntArray(const IntArray &);		IntArray & operator=(const IntArray &);	public:		IntArray(int size)			:			m_size(size)		{			m_data = new int[m_size];		}		~IntArray()		{			delete[] m_data; //free up the used memory		}};

cLandLord::cLandLord(int type, int slave_count){ type_ = type; this->slaves= new cServant[slave_count]}cLandLord::InitUnit(int hp, int mana, ...){ hitPoints_ = hp; mana_ = mana;}

Quote:Original post by EasilyConfused
IMHO, that violates the principle that the class should always be in a well-defined state. If you were to access the mana_ member (for example) after the object constructor but before you had called InitUnit, it would contain random data (assuming the object was on the stack or had been created with new).

I'm not saying a seperate Init function is bad per se, but you should at least be assigning default values to hitPoints_ and mana_ in the constructor in case they are accessed before InitUnit is called.

Even just calling InitUnit(0,0); at the end of the constructor would be an improvement.