Quote:17.4.3.1.2 Global names [lib.global.names]

1 Certain sets of names and function signatures are always reserved to the implementation:

* Each name that contains a double underscore (_ _) or begins with an underscore followed by an upper case letter (2.11) is reserved to the implementation for any use.
* Each name that begins with an underscore is reserved to the implementation for use as a name in the global namespace.

ShoppingListEntry(ResourceType type, ResourceState state, const std::string& name)				:type(type),state(state),name(name){}

Quote:Original post by Hodgman
style: Names beginning with an _ can be reserved by the implementation in some cases, so I like to avoid them.

Quote:17.4.3.1.2 Global names [lib.global.names]

1 Certain sets of names and function signatures are always reserved to the implementation:

* Each name that contains a double underscore (_ _) or begins with an underscore followed by an upper case letter (2.11) is reserved to the implementation for any use.
* Each name that begins with an underscore is reserved to the implementation for use as a name in the global namespace.

There's nothing wrong with doing this:

ShoppingListEntry(ResourceType type, ResourceState state, const std::string& name)				:type(type),state(state),name(name){}

Performance: _name and entry should be passed by const reference here:
ShoppingListEntry(ResourceType _type, ResourceState _state, std::string _name)
and here:
void pushDirective(ShoppingListEntry entry);

Function: Should the pop function return boolean in case the vector is empty?

Documentation: Are the comments for the push/pop functions reversed?
Does getAllOf remove the returned items from the member vector?

Typo: I assume that "std::vector<ShoppingListEntry>t_entry_list;" is supposed to be "t_entry_list entries;" ;)

	enum ResourceType	{		// ...		AnyType	};

	enum ResourceState{		Load,		Unload,		AnyState	};

	class ShoppingListEntry	{		        // ...		private:			ResourceType type;			ResourceState state;			std::string name;	};

			ResourceShoppingList(){}			~ResourceShoppingList(){}

			bool popDirective(ShoppingListEntry& entry);			//just get the top one

			void getAllOf(ResourceType _type, ResourceState _state, t_entry_list& _entries);			//get list of all resources which match those properties

Quote:Original post by hoLogramm
As my previouse poster stated the "_"-Parameters are better avoided. Instead you could use something like "InType, InState, InEntries" or the like.

//! Return all the list elements that satisfy both filterssequence_type get_filtered(resource_type type_filter, bool loaded_filter) const;

	enum ResourceType	{		StaticMesh,		Material,		Sound,		Vehicle,		Character,		AnyType		};	enum ResourceState{		Load,		Unload,		AnyState	};

shopping_list.getAllOf(AnyType, Load, subset);orvoid getAllOf(Material, AnyState, subset);

Quote:
Also, document your code: which directive, exactly, is the top one? The first one? The last one? A random one? Is this a stack or a queue or something else?

Quote:Original post by speciesUnknown
This allows a search for all resources named charlie, for example, or all materials regardless of the directive to be performed.

I will change the name ResourceState to ResourceDirective, since that is what it is: load, unload, or either. The problem is that these enums are being used as search parameters as well. How can I deal with that duality?

// If you use boost :typedef boost::optional<ResourceDirective> directive_option;// Otherwise :typedef ResourceDirective *directive_option;

sequence_type get_all() const { return get(0, 0); }sequence_type get_filtered(ResourceDirective d) const { return get(0, &d); }sequence_type get_filtered(ResourceType t) const{ return get(&t, 0); }sequence_type get_filtered(ResourceType t, ResourceDirective d) const{ return get(&t, &d); }private: sequence_type get(type_option t, directive_option d) const { ... }

static const directive_option any_directive;static const type_option any_type;sequence_type get_filtered(type_option t, directive_option d) const{ ... }