Sign in to follow this  
ecco_the_dolphin

OpenGL is it legal to pass invalid pointer to glTexCoordPointer

Recommended Posts

I have very big array of vertex data (around 5 mb). I want to draw textured lines. But I dont want to store texture coordinates. I can calculate them during runtime. I do the following:
void __fastcall CGraphicCore::_SurfaceDrawTextureLine
                                           //Pointer to primitive
                                           (const Primitive_In * ptr_prim
                                           //Some additional info
                                           ,CDrawRule * rule)
{
    _ASSERTE(ptr_prim->PointsCount()>1);
    size_t first_point_index = ptr_prim->GetFirstPointIndex();
    size_t points_number     = ptr_prim->PointsCount();
    //rule->first_point_ptr - it is a pointer to the first point in vertex array
    const fvec2_s * cur_pnt_ptr    = rule->first_point_ptr + first_point_index;
    const fvec2_s * border_pnt_ptr = cur_pnt_ptr + points_number;

    double * tex_mem;
    //this is function for getting memory from buffer (actually template function)
    //it calls realloc(buffer_data_,sizeof(double)*elements_number)
    rule->additional_buffer_prt->GetRawMemory(points_number,&tex_mem);
    double * ptr_tex_storage = tex_mem;

    double tex_crd = 0;
    fvec2_s prev_pnt;
    fvec2_s cur_pnt;
    prev_pnt = *cur_pnt_ptr;
    cur_pnt  = *cur_pnt_ptr;    
    while (cur_pnt_ptr!=border_pnt_ptr)
    {
        cur_pnt = *cur_pnt_ptr;
        tex_crd = //do some calculations
        *ptr_tex_storage = tex_crd;
        ++ptr_tex_storage;
        ++cur_pnt_ptr;
        prev_pnt = cur_pnt;
    }
    //HACK: possible solution: modify Vertexpointer and in Deinit function reset it to first element.
    glTexCoordPointer(1,GL_DOUBLE,0,tex_mem - first_point_index);
    glEnableClientState(GL_TEXTURE_COORD_ARRAY);
    //render primitive
    glDrawArrays(GL_LINE_STRIP,first_point_index,points_number);
    glDisableClientState(GL_TEXTURE_COORD_ARRAY);
    
    NDebugTool::DetectGLError();
    return;
}





The question is: can I set glTexCoordPointer(1,GL_DOUBLE,0,tex_mem - first_point_index) with (tex_mem - first_point_index)? I mean is it legal to pass invalid pointer to glTexCoordPointer if ("illegal pointer" + offset) == valid pointer? This code is working for me, but maybe it will not work with some opengl implementation... [Edited by - ecco_the_dolphin on June 8, 2009 2:08:20 PM]

Share this post


Link to post
Share on other sites
It doesn't *sound* like a good idea. Why? Well, an implementation might well do something to optimise access like (say), the first time you access element N, upload 0..N so that it has it all in local memory. You can't tell if it'll do something like that, as far as I know.

Share this post


Link to post
Share on other sites
Thaks for reply.
You mean that implementation can cashe vertex coordinates (or texture coordinates) which I specify in glVertexPointer (or glTexCoordPointer)?

Then if i write something like this :


...
struct fvect2d
{
float x;
float y;
};
....
void DrawSomething ()
{
fvect2d vertex_data[3];

vertex_data[0].x = 0;
vertex_data[0].y = 0;

vertex_data[1].x = 1.f;
vertex_data[1].y = 1.f;

vertex_data[2].x = 1.f;
vertex_data[2].y = 0;

glVertexPointer(2,GL_FLOAT,0,&vertex_data[0].x);
glEnableClientState(GL_VERTEX_ARRAY);
glDrawArrays(GL_TRIANGLES,0,3);

//I modify vertex_data during enabled vertex array
vertex_data[1].x = -1.f;
vertex_data[1].y = -1.f;

glDrawArrays(GL_TRIANGLES,0,3);
glDisableClientState(GL_VERTEX_ARRAY);
}




then, some implementation can display only first triangle? And to draw 2 triangles I must Disable/Enable array every time i modify vertex data?

Share this post


Link to post
Share on other sites
Quote:
Original post by ecco_the_dolphin
I mean is it legal to pass invalid pointer to glTexCoordPointer if ("illegal pointer" + offset) == valid pointer?
No. Doing so is undefined behavior, technically. If you have a pointer to a block of allocated memory, you are only allowed to do pointer arithmetic within the range of the block of allocated memory (plus 1 past the end). There was a nice discussion of pointer arithmetic and the undefined-ness of making pointers point outside of this range.

Share this post


Link to post
Share on other sites
Quote:
No. Doing so is undefined behavior, technically. If you have a pointer to a block of allocated memory, you are only allowed to do pointer arithmetic within the range of the block of allocated memory (plus 1 past the end). There was a nice discussion of pointer arithmetic and the undefined-ness of making pointers point outside of this range.


Thanks a lot! I didn't knew that. According to ISO/IEC 14882:2003 (it is C++ standart) section 5.7 :
Quote:

...
5.
When an expression that has integral type is added to or subtracted from a pointer, the result has the type of
the pointer operand. If the pointer operand points to an element of an array object, and the array is large
enough, the result points to an element offset from the original element such that the difference of the subscripts
of the resulting and original array elements equals the integral expression. In other words, if the
expression P points to the i-th element of an array object, the expressions (P)+N (equivalently, N+(P))
and (P)-N (where N has the value n) point to, respectively, the i+n-th and i–n-th elements of the array
object, provided they exist. Moreover, if the expression P points to the last element of an array object, the
expression (P)+1 points one past the last element of the array object, and if the expression Q points one
past the last element of an array object, the expression (Q)-1 points to the last element of the array object.
If both the pointer operand and the result point to elements of the same array object, or one past the last element
of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined.
...


[Edited by - ecco_the_dolphin on June 9, 2009 8:15:45 PM]

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Forum Statistics

    • Total Topics
      627773
    • Total Posts
      2979011
  • Similar Content

    • By lonewolff
      Hi guys,
      With OpenGL not having a dedicated SDK, how were libraries like GLUT and the likes ever written?
      Could someone these days write an OpenGL library from scratch? How would you even go about this?
      Obviously this question stems from the fact that there is no OpenGL SDK.
      DirectX is a bit different as MS has the advantage of having the relationship with the vendors and having full access to OS source code and the entire works.
      If I were to attempt to write the most absolute basic lib to access OpenGL on the GPU, how would I go about this?
    • By DelicateTreeFrog
      Hello! As an exercise for delving into modern OpenGL, I'm creating a simple .obj renderer. I want to support things like varying degrees of specularity, geometry opacity, things like that, on a per-material basis. Different materials can also have different textures. Basic .obj necessities. I've done this in old school OpenGL, but modern OpenGL has its own thing going on, and I'd like to conform as closely to the standards as possible so as to keep the program running correctly, and I'm hoping to avoid picking up bad habits this early on.
      Reading around on the OpenGL Wiki, one tip in particular really stands out to me on this page:
      For something like a renderer for .obj files, this sort of thing seems almost ideal, but according to the wiki, it's a bad idea. Interesting to note!
      So, here's what the plan is so far as far as loading goes:
      Set up a type for materials so that materials can be created and destroyed. They will contain things like diffuse color, diffuse texture, geometry opacity, and so on, for each material in the .mtl file. Since .obj files are conveniently split up by material, I can load different groups of vertices/normals/UVs and triangles into different blocks of data for different models. When it comes to the rendering, I get a bit lost. I can either:
      Between drawing triangle groups, call glUseProgram to use a different shader for that particular geometry (so a unique shader just for the material that is shared by this triangle group). or
      Between drawing triangle groups, call glUniform a few times to adjust different parameters within the "master shader", such as specularity, diffuse color, and geometry opacity. In both cases, I still have to call glBindTexture between drawing triangle groups in order to bind the diffuse texture used by the material, so there doesn't seem to be a way around having the CPU do *something* during the rendering process instead of letting the GPU do everything all at once.
      The second option here seems less cluttered, however. There are less shaders to keep up with while one "master shader" handles it all. I don't have to duplicate any code or compile multiple shaders. Arguably, I could always have the shader program for each material be embedded in the material itself, and be auto-generated upon loading the material from the .mtl file. But this still leads to constantly calling glUseProgram, much more than is probably necessary in order to properly render the .obj. There seem to be a number of differing opinions on if it's okay to use hundreds of shaders or if it's best to just use tens of shaders.
      So, ultimately, what is the "right" way to do this? Does using a "master shader" (or a few variants of one) bog down the system compared to using hundreds of shader programs each dedicated to their own corresponding materials? Keeping in mind that the "master shaders" would have to track these additional uniforms and potentially have numerous branches of ifs, it may be possible that the ifs will lead to additional and unnecessary processing. But would that more expensive than constantly calling glUseProgram to switch shaders, or storing the shaders to begin with?
      With all these angles to consider, it's difficult to come to a conclusion. Both possible methods work, and both seem rather convenient for their own reasons, but which is the most performant? Please help this beginner/dummy understand. Thank you!
    • By JJCDeveloper
      I want to make professional java 3d game with server program and database,packet handling for multiplayer and client-server communicating,maps rendering,models,and stuffs Which aspect of java can I learn and where can I learn java Lwjgl OpenGL rendering Like minecraft and world of tanks
    • By AyeRonTarpas
      A friend of mine and I are making a 2D game engine as a learning experience and to hopefully build upon the experience in the long run.

      -What I'm using:
          C++;. Since im learning this language while in college and its one of the popular language to make games with why not.     Visual Studios; Im using a windows so yea.     SDL or GLFW; was thinking about SDL since i do some research on it where it is catching my interest but i hear SDL is a huge package compared to GLFW, so i may do GLFW to start with as learning since i may get overwhelmed with SDL.  
      -Questions
      Knowing what we want in the engine what should our main focus be in terms of learning. File managements, with headers, functions ect. How can i properly manage files with out confusing myself and my friend when sharing code. Alternative to Visual studios: My friend has a mac and cant properly use Vis studios, is there another alternative to it?  
    • By ferreiradaselva
      Both functions are available since 3.0, and I'm currently using `glMapBuffer()`, which works fine.
      But, I was wondering if anyone has experienced advantage in using `glMapBufferRange()`, which allows to specify the range of the mapped buffer. Could this be only a safety measure or does it improve performance?
      Note: I'm not asking about glBufferSubData()/glBufferData. Those two are irrelevant in this case.
  • Popular Now