Sign in to follow this  

OpenGL is it legal to pass invalid pointer to glTexCoordPointer

This topic is 3143 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I have very big array of vertex data (around 5 mb). I want to draw textured lines. But I dont want to store texture coordinates. I can calculate them during runtime. I do the following:
void __fastcall CGraphicCore::_SurfaceDrawTextureLine
                                           //Pointer to primitive
                                           (const Primitive_In * ptr_prim
                                           //Some additional info
                                           ,CDrawRule * rule)
{
    _ASSERTE(ptr_prim->PointsCount()>1);
    size_t first_point_index = ptr_prim->GetFirstPointIndex();
    size_t points_number     = ptr_prim->PointsCount();
    //rule->first_point_ptr - it is a pointer to the first point in vertex array
    const fvec2_s * cur_pnt_ptr    = rule->first_point_ptr + first_point_index;
    const fvec2_s * border_pnt_ptr = cur_pnt_ptr + points_number;

    double * tex_mem;
    //this is function for getting memory from buffer (actually template function)
    //it calls realloc(buffer_data_,sizeof(double)*elements_number)
    rule->additional_buffer_prt->GetRawMemory(points_number,&tex_mem);
    double * ptr_tex_storage = tex_mem;

    double tex_crd = 0;
    fvec2_s prev_pnt;
    fvec2_s cur_pnt;
    prev_pnt = *cur_pnt_ptr;
    cur_pnt  = *cur_pnt_ptr;    
    while (cur_pnt_ptr!=border_pnt_ptr)
    {
        cur_pnt = *cur_pnt_ptr;
        tex_crd = //do some calculations
        *ptr_tex_storage = tex_crd;
        ++ptr_tex_storage;
        ++cur_pnt_ptr;
        prev_pnt = cur_pnt;
    }
    //HACK: possible solution: modify Vertexpointer and in Deinit function reset it to first element.
    glTexCoordPointer(1,GL_DOUBLE,0,tex_mem - first_point_index);
    glEnableClientState(GL_TEXTURE_COORD_ARRAY);
    //render primitive
    glDrawArrays(GL_LINE_STRIP,first_point_index,points_number);
    glDisableClientState(GL_TEXTURE_COORD_ARRAY);
    
    NDebugTool::DetectGLError();
    return;
}





The question is: can I set glTexCoordPointer(1,GL_DOUBLE,0,tex_mem - first_point_index) with (tex_mem - first_point_index)? I mean is it legal to pass invalid pointer to glTexCoordPointer if ("illegal pointer" + offset) == valid pointer? This code is working for me, but maybe it will not work with some opengl implementation... [Edited by - ecco_the_dolphin on June 8, 2009 2:08:20 PM]

Share this post


Link to post
Share on other sites
It doesn't *sound* like a good idea. Why? Well, an implementation might well do something to optimise access like (say), the first time you access element N, upload 0..N so that it has it all in local memory. You can't tell if it'll do something like that, as far as I know.

Share this post


Link to post
Share on other sites
Thaks for reply.
You mean that implementation can cashe vertex coordinates (or texture coordinates) which I specify in glVertexPointer (or glTexCoordPointer)?

Then if i write something like this :


...
struct fvect2d
{
float x;
float y;
};
....
void DrawSomething ()
{
fvect2d vertex_data[3];

vertex_data[0].x = 0;
vertex_data[0].y = 0;

vertex_data[1].x = 1.f;
vertex_data[1].y = 1.f;

vertex_data[2].x = 1.f;
vertex_data[2].y = 0;

glVertexPointer(2,GL_FLOAT,0,&vertex_data[0].x);
glEnableClientState(GL_VERTEX_ARRAY);
glDrawArrays(GL_TRIANGLES,0,3);

//I modify vertex_data during enabled vertex array
vertex_data[1].x = -1.f;
vertex_data[1].y = -1.f;

glDrawArrays(GL_TRIANGLES,0,3);
glDisableClientState(GL_VERTEX_ARRAY);
}




then, some implementation can display only first triangle? And to draw 2 triangles I must Disable/Enable array every time i modify vertex data?

Share this post


Link to post
Share on other sites
Quote:
Original post by ecco_the_dolphin
I mean is it legal to pass invalid pointer to glTexCoordPointer if ("illegal pointer" + offset) == valid pointer?
No. Doing so is undefined behavior, technically. If you have a pointer to a block of allocated memory, you are only allowed to do pointer arithmetic within the range of the block of allocated memory (plus 1 past the end). There was a nice discussion of pointer arithmetic and the undefined-ness of making pointers point outside of this range.

Share this post


Link to post
Share on other sites
Quote:
No. Doing so is undefined behavior, technically. If you have a pointer to a block of allocated memory, you are only allowed to do pointer arithmetic within the range of the block of allocated memory (plus 1 past the end). There was a nice discussion of pointer arithmetic and the undefined-ness of making pointers point outside of this range.


Thanks a lot! I didn't knew that. According to ISO/IEC 14882:2003 (it is C++ standart) section 5.7 :
Quote:

...
5.
When an expression that has integral type is added to or subtracted from a pointer, the result has the type of
the pointer operand. If the pointer operand points to an element of an array object, and the array is large
enough, the result points to an element offset from the original element such that the difference of the subscripts
of the resulting and original array elements equals the integral expression. In other words, if the
expression P points to the i-th element of an array object, the expressions (P)+N (equivalently, N+(P))
and (P)-N (where N has the value n) point to, respectively, the i+n-th and i–n-th elements of the array
object, provided they exist. Moreover, if the expression P points to the last element of an array object, the
expression (P)+1 points one past the last element of the array object, and if the expression Q points one
past the last element of an array object, the expression (Q)-1 points to the last element of the array object.
If both the pointer operand and the result point to elements of the same array object, or one past the last element
of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined.
...


[Edited by - ecco_the_dolphin on June 9, 2009 8:15:45 PM]

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Similar Content

    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
    • By dpadam450
      I have this code below in both my vertex and fragment shader, however when I request glGetUniformLocation("Lights[0].diffuse") or "Lights[0].attenuation", it returns -1. It will only give me a valid uniform location if I actually use the diffuse/attenuation variables in the VERTEX shader. Because I use position in the vertex shader, it always returns a valid uniform location. I've read that I can share uniforms across both vertex and fragment, but I'm confused what this is even compiling to if this is the case.
       
      #define NUM_LIGHTS 2
      struct Light
      {
          vec3 position;
          vec3 diffuse;
          float attenuation;
      };
      uniform Light Lights[NUM_LIGHTS];
       
       
    • By pr033r
      Hello,
      I have a Bachelor project on topic "Implenet 3D Boid's algorithm in OpenGL". All OpenGL issues works fine for me, all rendering etc. But when I started implement the boid's algorithm it was getting worse and worse. I read article (http://natureofcode.com/book/chapter-6-autonomous-agents/) inspirate from another code (here: https://github.com/jyanar/Boids/tree/master/src) but it still doesn't work like in tutorials and videos. For example the main problem: when I apply Cohesion (one of three main laws of boids) it makes some "cycling knot". Second, when some flock touch to another it scary change the coordination or respawn in origin (x: 0, y:0. z:0). Just some streng things. 
      I followed many tutorials, change a try everything but it isn't so smooth, without lags like in another videos. I really need your help. 
      My code (optimalizing branch): https://github.com/pr033r/BachelorProject/tree/Optimalizing
      Exe file (if you want to look) and models folder (for those who will download the sources):
      http://leteckaposta.cz/367190436
      Thanks for any help...

    • By Andrija
      I am currently trying to implement shadow mapping into my project , but although i can render my depth map to the screen and it looks okay , when i sample it with shadowCoords there is no shadow.
      Here is my light space matrix calculation
      mat4x4 lightViewMatrix; vec3 sun_pos = {SUN_OFFSET * the_sun->direction[0], SUN_OFFSET * the_sun->direction[1], SUN_OFFSET * the_sun->direction[2]}; mat4x4_look_at(lightViewMatrix,sun_pos,player->pos,up); mat4x4_mul(lightSpaceMatrix,lightProjMatrix,lightViewMatrix); I will tweak the values for the size and frustum of the shadow map, but for now i just want to draw shadows around the player position
      the_sun->direction is a normalized vector so i multiply it by a constant to get the position.
      player->pos is the camera position in world space
      the light projection matrix is calculated like this:
      mat4x4_ortho(lightProjMatrix,-SHADOW_FAR,SHADOW_FAR,-SHADOW_FAR,SHADOW_FAR,NEAR,SHADOW_FAR); Shadow vertex shader:
      uniform mat4 light_space_matrix; void main() { gl_Position = light_space_matrix * transfMatrix * vec4(position, 1.0f); } Shadow fragment shader:
      out float fragDepth; void main() { fragDepth = gl_FragCoord.z; } I am using deferred rendering so i have all my world positions in the g_positions buffer
      My shadow calculation in the deferred fragment shader:
      float get_shadow_fac(vec4 light_space_pos) { vec3 shadow_coords = light_space_pos.xyz / light_space_pos.w; shadow_coords = shadow_coords * 0.5 + 0.5; float closest_depth = texture(shadow_map, shadow_coords.xy).r; float current_depth = shadow_coords.z; float shadow_fac = 1.0; if(closest_depth < current_depth) shadow_fac = 0.5; return shadow_fac; } I call the function like this:
      get_shadow_fac(light_space_matrix * vec4(position,1.0)); Where position is the value i got from sampling the g_position buffer
      Here is my depth texture (i know it will produce low quality shadows but i just want to get it working for now):
      sorry because of the compression , the black smudges are trees ... https://i.stack.imgur.com/T43aK.jpg
      EDIT: Depth texture attachment:
      glTexImage2D(GL_TEXTURE_2D, 0,GL_DEPTH_COMPONENT24,fbo->width,fbo->height,0,GL_DEPTH_COMPONENT,GL_FLOAT,NULL); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, fbo->depthTexture, 0);
  • Popular Now