Back to General and Gameplay Programming

Any buffer over runs in this char 'toHexStr' code?

IFooBar · 2011-11-24T20:21:27

Hi guys, does this code have any safety issues? const char *tohexstr1(const char *src, size_t srclen, char* dst, int dstlen) { assert(dstlen > 1); char temp[3]; int len = 0; *dst = 0; for (size_t i = 0; i < srclen; ++i) { sprintf(temp, "%02X", src); temp[2] = 0; len += 2; if (len < dstlen) strcat(dst, temp); } return dst; } Thanks in advance!

General and Gameplay Programming Programming

Started by IFooBar November 16, 2011 08:47 AM

19 comments, last by SiCrane 12 years, 5 months ago

JoshuaHoffmann

102

November 24, 2011 07:53 PM

I'm wondering if sprintf_s might be useful here (if you're targeting Windows) for guarding against buffer overruns.

If your program is targeting non-Windows platforms (like Mac or Linux), I wonder if there's equivalents to sprintf_s out there.

Joshua Hoffmann
Developer, Land of Smiley Cubes
landofsmileycubes.com