problem with load obj file

Started by
11 comments, last by metsfan 10 years, 10 months ago

I try to load the obj file to the opengl but the system crash, I tested My code in console system:


#include <iostream>
#include <string>
#include <vector>
#include <fstream>
#include <ostream>
#include <algorithm>
#include <Windows.h>
using namespace std;

class vertex
{public:
float f1;
float f2;
float f3;
vertex(float F1,float F2, float F3):f1(F1),f2(F2),f3(F3){};
};//the vertex

class face{
public:
	int a;
	int b;
	int c;
	int d;
	bool four;
	face(int x,int y,int z):a(x),b(y),c(z){four =false;};
	face(int x,int y,int z,int k):a(x),b(y),c(z),d(k){four =true;};
};

vector<vertex>v;
vector<face>f;

void loadvertex(char*filename){

	ifstream infile(filename);
	ofstream outfile("out.txt");
	float f1,f2,f3;
	char buffer;
	if(!infile.is_open())
	{return;
	}
	while(infile>>buffer>>f1>>f2>>f3){
	if(buffer=='v')
	{outfile<<f1<<" "<<f2<<" "<<f3<<endl;
	cout<<f1<<" "<<f2<<" "<<f3<<endl;
	v.push_back(vertex(f1,f2,f3));}
	
	}

	infile.close();
	outfile.close();

}


void loadface(char*filename){
	ifstream infile(filename);
	ofstream outfile("out.txt");
	int f1,f2,f3;
	char buffer;
	if(!infile.is_open())
	{return;
	}
	while(infile>>buffer>>f1>>f2>>f3){
	if(buffer=='f'){

	outfile<<f1<<" "<<f2<<" "<<f3<<endl;
	cout<<f1<<" "<<f2<<" "<<f3<<endl;
	f.push_back( face(f1,f2,f3));
	}
	}

	infile.close();
	outfile.close();
}
void Loadobj(char*filename)
{
string line;
ifstream objfile(filename);
if(objfile.is_open())
{

while(!objfile.eof())
{ getline(objfile,line);
  if(line.c_str()[0]=='v')
 {  float tmpx,tmpy,tmpz;
   sscanf(line.c_str(),"v %f %f %f",&tmpx,&tmpy,&tmpz);
   v.push_back(vertex(tmpx,tmpy,tmpz));
}
  if(line.c_str()[0]=='f')
  {  int a,b,c,d;
   sscanf(line.c_str(),"f %d//%d %d//%d %d//%d",&a,&b,&c,&b,&d,&b);
   f.push_back(face(a,c,d));
}
}
}

}
int main(){
	Loadobj("cube.txt");
	for(int i=0;i<f.size();i++)
	{ 
		float F1=v[f[i].a-1].f1;
		float F2=v[f[i].a-1].f2;
		float F3=v[f[i].a-1].f3;
		cout<<F1<<"--"<<F2<<"--"<<F3<<endl;
	
	}
	system("pause");
	return 0;
}

the obj file:

# Blender3D v249 OBJ File:
# www.blender3d.org
v 1.000000 1.000000 -1.000000
v 1.000000 -1.000000 -1.000000
v -1.000000 -1.000000 -1.000000
v -1.000000 1.000000 -1.000000
v 1.000000 0.999999 1.000000
v 0.999999 -1.000001 1.000000
v -1.000000 -1.000000 1.000000
v -1.000000 1.000000 1.000000
vn 0.000000 1.000000 0.000000
vn -1.000000 0.000000 -0.000000
vn -0.000000 -1.000000 -0.000000
vn 1.000000 0.000000 -0.000000
vn 1.000000 -0.000001 0.000000
vn 0.000000 0.000000 1.000000
vn 0.000000 0.000000 -1.000000
usemtl Material
s off
f 5//1 1//1 4//1
f 5//1 4//1 8//1
f 3//2 7//2 8//2
f 3//2 8//2 4//2
f 2//3 6//3 3//3
f 6//3 7//3 3//3
f 1//4 5//4 2//4
f 5//5 6//5 2//5
f 5//6 8//6 6//6
// the error shows that: ...
if (longone)
// *(long UNALIGNED *)pointer = (unsigned long)number;
// else...
Advertisement

And I also get warning that I can't use "sscanf"

how to fix this problem??

Did you run it in your debugger? On a crash, the debugger will break at the line that caused the crash, which will help you fix it.

Since you're #include-ing windows.h you're probably on Windows, so you really should use Visual Studio's debugger - it's the best in the business and a valuable tool for this kind of situation.

Direct3D has need of instancing, but we do not. We have plenty of glVertexAttrib calls.

Are you using Visual Studio? Run in debug mode and step by step see what it reads and why it is not breaking. What does infile >> return at end of file? Figure it out. Your while loop codition is awful as well. Read a single char: "v" and if(char == "v"){ read f1,f2,f3} not reading them all at once

NBA2K, Madden, Maneater, Killing Floor, Sims http://www.pawlowskipinball.com/pinballeternal

I am using visual stdio 2010

the error appears at

void Loadobj(char*filename)
{
string line;
ifstream objfile(filename);
if(objfile.is_open())
{

while(!objfile.eof())
{ getline(objfile,line);
if(line.c_str()[0]=='v')
{ float tmpx,tmpy,tmpz;
sscanf(line.c_str(),"v %f %f %f",&tmpx,&tmpy,&tmpz);
v.push_back(vertex(tmpx,tmpy,tmpz));
}
if(line.c_str()[0]=='f')
{ int a,b,c,d;
sscanf(line.c_str(),"f %d//%d %d//%d %d//%d",&a,&b,&c,&b,&d,&b);
f.push_back(face(a,c,d));
}
}
}

}

because I only use this function

There is a pretty decent .obj loader at the following site. I'm able to export indices, tangents and biNormals out of it without any issue. It does have some intermittent crash problems that are related to some of the Blender export settings, you might be having the same problem. I just set a preset that exports the model using stable settings. For instance, if a .obj loader expects edges and you don't set the Blender export plugin to include edges you may have a crash if there is no proper error handling built in to your program. Conversely, if your program is NOT expecting edges and you do include them, then your parser may fail and once again you might have a crash. Finding the proper Blender export settings for your program may also help you track down your bug.

http://www.dhpoware.com/demos/glObjViewer.html

Consider it pure joy, my brothers and sisters, whenever you face trials of many kinds, 3 because you know that the testing of your faith produces perseverance. 4 Let perseverance finish its work so that you may be mature and complete, not lacking anything.

...


Apart from the fact that I would avoid the scanf family of functions (either use the standard streams or generate a proper parser with AntLR or friends): you are entering undefined behavior with "line.c_str()[0]" as soon as a line you read is empty.


you are entering undefined behavior with "line.c_str()[0]" as soon as a line you read is empty.

It isn't UB, I think. The line may be empty but strlen() will return zero and the character at [0] will be the null character. c_str() returns a valid C null-terminated char array and may not return a null pointer. So it should just skip the line. Still kind of fragile, though, I agree.

“If I understand the standard right it is legal and safe to do this but the resulting value could be anything.”

So you should put a breakpoint and step through your code. If you don't know how to do that look it up. You have a bug in your code you have to see whats going on and this is straightforward to solve in VS debuginning line by line.

Also c++ strings have an index operator.
line.c_str()[0]=='v'
line[0] == 'v'

NBA2K, Madden, Maneater, Killing Floor, Sims http://www.pawlowskipinball.com/pinballeternal

Dude your code is an eye sore.

If this post or signature was helpful and/or constructive please give rep.

// C++ Video tutorials

http://www.youtube.com/watch?v=Wo60USYV9Ik

// Easy to learn 2D Game Library c++

SFML2.2 Download http://www.sfml-dev.org/download.php

SFML2.2 Tutorials http://www.sfml-dev.org/tutorials/2.2/

// Excellent 2d physics library Box2D

http://box2d.org/about/

// SFML 2 book

http://www.amazon.com/gp/product/1849696845/ref=as_li_ss_tl?ie=UTF8&camp=1789&creative=390957&creativeASIN=1849696845&linkCode=as2&tag=gamer2creator-20

This topic is closed to new replies.

Advertisement