Thanks very much for the quick reply, a quick follow up question. I have been struggling with while loops for the last few days, the above script is my current attempt to loop the script if the user input is not one of the acceptable values, from what i have read it would seem that a do-while loop would apply but i should be able to do it with a while statement?

Also, Mr Stx, I would highly suggest tackling one error at a time and not adding code when you know you have an error. This practice should make it easier to fix things as you find them. Above, you have changed the main line to loop, but you also still have the problem of treating randRange() as a variable. Now, this error has nothing to do with your infinite loop--the replies you've gotten on that should be helpful--but that just happens to be the case in this situation. If you add too much all at one time, it can become much more difficult (as a beginner) to figure out where the problem is really coming from. So fix the randRange() thing, then straighten out your boolean algebra(woot!), and then move on.

While I was typing this I see you have another post. I put in a link above, I don't know how helpful it will be.

Not either 1 or 2 would be !(choice == 1 || choice ==2).

Take a closer look at how you wrote your code, and answer each question for yourself in each situation.

while ( choice != 1 || choice != 2)

input test 1 -- test 2 -- summary

1 F T (F || T) = T

2 T F (T || F) = T

3 T T (T || T) = T

Step through SiCrane's code and see what you get in each of these cases.

if(!(choice == 1 || choice ==2))

should work.

Are you doing

if !(choice == 1 || choice ==2)

that won't work, "if" needs brackets straight away.