Recommended Posts

Hi guys.

so I'm currently having a minor issue here. I generate my luminance map, then attempt to adapt it and then use it for other purposes, such as the bloom pass. But the problem is that theres no visible adaptation for some reason. Someone might find the shader code familiar, well thats because I based it on a sample from MJP (Thanks btw. Great samples you have there.)

Logic in the high level render when rendering & adapting the luminance map, DX11 is my own small wrapper, it should work as intended:

void CE_NAMESPACE::CEPostLuminance::Render(DX11 *pD3D11, float dTime, DX11Resource *p, DX11RenderTarget *pOut)
{
// Set DTIME
Buffer.fTimeDelta = dTime;

// Map Data
pD3D11->BufferConstantMap(m_vBuffers[0]->p, &Buffer);

SetData(pD3D11);

// Calculate new luminance
{
pD3D11->RTVSet(&m_pLum->pRTV, 1, false);

ApplyPost(pD3D11, &m_pPasses[0]);

pD3D11->Bind(p, 0);

pD3D11->Render(3, 0);

// Unbind
pD3D11->Unbind(PS, 0);
}

{
pD3D11->RTVSet(&m_pTemp->pRTV, 1, false);

ApplyPost(pD3D11, &m_pPasses[1]);

pD3D11->Bind(m_pLumLast, 1);

pD3D11->Bind(m_pLum, 2);

pD3D11->Render(3, 0);
}

// Swappy Times!
m_pLumLast = m_pLum;
m_pLum = m_pTemp;
m_pTemp = m_pLumLast;

.... Some more unrelated stuff


...
Texture2D<float> lum_old : register(t1);
Texture2D<float> lum : register(t2);

...

{
float lastLum = exp(lum_old.Sample(ss, input.Tex));
float currentLum = lum.Sample(ss, input.Tex);

// Adapt the luminance using Pattanaik's technique
float adaptedLum = lastLum + (currentLum - lastLum) * (1 - exp(-TimeDelta * Tau));

}


The mistake is most likely obvious but theres no change in the luminance map according to my eyes.

Thank you for your time. I appreciate it.

-MIGI0027

Share on other sites

float adaptedLum = lastLum + (currentLum - lastLum) * (1 - exp(-TimeDelta * Tau));

Probably this line. Just quessing, but thats what caused problems at my end more than once. try to replace the exp()-statement with a constant, like

float adaptedLum = lastLum + (currentLum - lastLum) * 0.75f;

and see if it works.

Share on other sites

Tried replacing the exp with 0.75f, still, no change, its most likely a simple mistake, which are the worst.

Share on other sites

Visualize the content of your render-targets then. How does the current/last/blended luminance looks like?Try to see if there is any change here at all first, maybe the luminance isn't even calculated properly to begin with.

Share on other sites

Hi, can you show how are you computing luminance ?

and also your bloom pass ?

Log and exp should be used during generation of luminance, so instead of :

float lastLum = exp(lum_old.Sample(ss, input.Tex));
float currentLum = lum.Sample(ss, input.Tex);

// Adapt the luminance using Pattanaik's technique
float adaptedLum = lastLum + (currentLum - lastLum) * (1 - exp(-TimeDelta * Tau));

return log(adaptedLum);

you should have :

float lastLum = lum_old.Sample(ss, input.Tex);
float currentLum = exp(lum.Sample(ss, input.Tex));

// Adapt the luminance using Pattanaik's technique
float adaptedLum = lastLum + (currentLum - lastLum) * (1 - exp(-TimeDelta * Tau));



and use Log during generation of luminance.

Or first you can try you luminance without any log/exp and see if it works.

Edited by joeblack

Share on other sites

Thanks for all the valuable help, the problem lied deeper due to a flaw in my logic and naive assumptions.

The problem was the swapping part. Im not sure when or how or why I did it like that.

WRONG: (I must have been under some sort of hallucinating drug  )

// Adapt it, no effect
{
pD3D11->RTVSet(&m_pTemp->pRTV, 1, false);

ApplyPost(pD3D11, &m_pPasses[1]);

pD3D11->Bind(m_pLumLast, 1);

pD3D11->Bind(m_pLum, 2);

pD3D11->Render(3, 0);
}

// Swappy Times! Like wtf is this!?
m_pLumLast = m_pLum;
m_pLum = m_pTemp;
m_pTemp = m_pLumLast;


The solution was two have an array called m_pLumLast of 2 elements, then casually swap them after usage:

	// Blend it
{
pD3D11->RTVSet(&m_ppLumLast[1]->pRTV, 1, false);

ApplyPost(pD3D11, &m_pPasses[1]);

pD3D11->Bind(m_ppLumLast[0], 1);

pD3D11->Bind(m_pLum, 2);

pD3D11->Render(3, 0);

// Unbind
pD3D11->Unbind(PS, 0);
}

// Swap Old Luminance Maps
DX11RenderTarget *pRCPY = m_ppLumLast[0];
m_ppLumLast[0] = m_ppLumLast[1];
m_ppLumLast[1] = pRCPY;


Ohh, and for anyone wondering, its a good idea to clear the last luminance textures after youve created them to a value, might be 0.

And thanks joeblack + juliean. But the problem was on my side, I apologize for the trouble. But thanks for the awesome help.

Perhaps someone will find this valuable at some point.

EDIT: Sorry for the long delay, but its hard finding time to test...

-MIGI0027

Edited by Migi0027

Create an account

Register a new account

• Forum Statistics

• Total Topics
627700
• Total Posts
2978690
• Similar Content

• By Baemz
Hello,
I've been working on some culling-techniques for a project. We've built our own engine so pretty much everything is built from scratch. I've set up a frustum with the following code, assuming that the FOV is 90 degrees.
float angle = CU::ToRadians(45.f); Plane<float> nearPlane(Vector3<float>(0, 0, aNear), Vector3<float>(0, 0, -1)); Plane<float> farPlane(Vector3<float>(0, 0, aFar), Vector3<float>(0, 0, 1)); Plane<float> right(Vector3<float>(0, 0, 0), Vector3<float>(angle, 0, -angle)); Plane<float> left(Vector3<float>(0, 0, 0), Vector3<float>(-angle, 0, -angle)); Plane<float> up(Vector3<float>(0, 0, 0), Vector3<float>(0, angle, -angle)); Plane<float> down(Vector3<float>(0, 0, 0), Vector3<float>(0, -angle, -angle)); myVolume.AddPlane(nearPlane); myVolume.AddPlane(farPlane); myVolume.AddPlane(right); myVolume.AddPlane(left); myVolume.AddPlane(up); myVolume.AddPlane(down); When checking the intersections I am using a BoundingSphere of my models, which is calculated by taking the average position of all vertices and then choosing the furthest distance to a vertex for radius. The actual intersection test looks like this, where the "myFrustum90" is the actual frustum described above.
The orientationInverse is actually the viewMatrix-inverse in this case.
bool CFrustum::Intersects(const SFrustumCollider& aCollider) { CU::Vector4<float> position = CU::Vector4<float>(aCollider.myCenter.x, aCollider.myCenter.y, aCollider.myCenter.z, 1.f) * myOrientationInverse; return myFrustum90.Inside({ position.x, position.y, position.z }, aCollider.myRadius); } The Inside() function looks like this.
template <typename T> bool PlaneVolume<T>::Inside(Vector3<T> aPosition, T aRadius) const { for (unsigned short i = 0; i < myPlaneList.size(); ++i) { if (myPlaneList[i].ClassifySpherePlane(aPosition, aRadius) > 0) { return false; } } return true; } And this is the ClassifySpherePlane() function. (The plane is defined as a Vector4 called myABCD, where ABC is the normal)
template <typename T> inline int Plane<T>::ClassifySpherePlane(Vector3<T> aSpherePosition, float aSphereRadius) const { float distance = (aSpherePosition.Dot(myNormal)) - myABCD.w; // completely on the front side if (distance >= aSphereRadius) { return 1; } // completely on the backside (aka "inside") if (distance <= -aSphereRadius) { return -1; } //sphere intersects the plane return 0; }
Please bare in mind that this code is not optimized nor well-written by any means. I am just looking to get it working.
The result of this culling is that the models seem to be culled a bit "too early", so that the culling is visible and the models pops away.
How do I get the culling to work properly?
I have tried different techniques but haven't gotten any of them to work.
If you need more code or explanations feel free to ask for it.

Thanks.

• hi,
i have read very much about the binding of a constantbuffer to a shader but something is still unclear to me.
e.g. when performing :   vertexshader.setConstantbuffer ( buffer,  slot )
is the buffer bound
or
b. to the VertexShader that is currently set as the active VertexShader
Is it possible to bind a constantBuffer to a VertexShader e.g. VS_A and keep this binding even after the active VertexShader has changed ?
I mean i want to bind constantbuffer_A  to VS_A, an Constantbuffer_B to VS_B  and  only use updateSubresource without using setConstantBuffer command every time.

Look at this example:
perform drawcall       ( buffer_A is used )

perform drawcall   ( buffer_B is used )
perform drawcall   (now which buffer is used ??? )

I ask this question because i have made a custom render engine an want to optimize to
the minimum  updateSubresource, and setConstantbuffer  calls

• I got a quick question about buffers when it comes to DirectX 11. If I bind a buffer using a command like:
IASetVertexBuffers IASetIndexBuffer VSSetConstantBuffers PSSetConstantBuffers  and then later on I update that bound buffer's data using commands like Map/Unmap or any of the other update commands.
Do I need to rebind the buffer again in order for my update to take effect? If I dont rebind is that really bad as in I get a performance hit? My thought process behind this is that if the buffer is already bound why do I need to rebind it? I'm using that same buffer it is just different data

• I am really stuck with something that should be very simple in DirectX 11.
1. I can draw lines using a PC (position, colored) vertices and a simple shader just fine.
2. I can draw 3D triangles using PCN (position, colored, normal) vertices just fine (even transparency and SpecularBlinnPhong shaders).

However, if I'm using my 3D shader, and I want to draw my PC lines in the same scene how can I do that?

If I change my lines to PCN and pass them to the 3D shader with my triangles, then the lighting screws them all up.  I only want the lighting for the 3D triangles, but no SpecularBlinnPhong/Lighting for the lines (just PC).
I am sure this is because if I change the lines to PNC there is not really a correct "normal" for the lines.
I assume I somehow need to draw the 3D triangles using one shader, and then "switch" to another shader and draw the lines?  But I have no clue how to use two different shaders in the same scene.  And then are the lines just drawn on top of the triangles, or vice versa (maybe draw order dependent)?
I must be missing something really basic, so if anyone can just point me in the right direction (or link to an example showing the implementation of multiple shaders) that would be REALLY appreciated.

I'm also more than happy to post my simple test code if that helps as well!

• By Reitano
Hi,
I am writing a linear allocator of per-frame constants using the DirectX 11.1 API. My plan is to replace the traditional constant allocation strategy, where most of the work is done by the driver behind my back, with a manual one inspired by the DirectX 12 and Vulkan APIs.
In brief, the allocator maintains a list of 64K pages, each page owns a constant buffer managed as a ring buffer. Each page has a history of the N previous frames. At the beginning of a new frame, the allocator retires the frames that have been processed by the GPU and frees up the corresponding space in each page. I use DirectX 11 queries for detecting when a frame is complete and the ID3D11DeviceContext1::VS/PSSetConstantBuffers1 methods for binding constant buffers with an offset.
The new allocator appears to be working but I am not 100% confident it is actually correct. In particular:
1) it relies on queries which I am not too familiar with. Are they 100% reliable ?
2) it maps/unmaps the constant buffer of each page at the beginning of a new frame and then writes the mapped memory as the frame is built. In pseudo code:
BeginFrame:
page.data = device.Map(page.buffer)
device.Unmap(page.buffer)
RenderFrame
Alloc(size, initData)
...
memcpy(page.data + page.start, initData, size)
Alloc(size, initData)
...
memcpy(page.data + page.start, initData, size)
(Note: calling Unmap at the end of a frame prevents binding the mapped constant buffers and triggers an error in the debug layer)
Is this valid ?
3) I don't fully understand how many frames I should keep in the history. My intuition says it should be equal to the maximum latency reported by IDXGIDevice1::GetMaximumFrameLatency, which is 3 on my machine. But, this value works fine in an unit test while on a more complex demo I need to manually set it to 5, otherwise the allocator starts overwriting previous frames that have not completed yet. Shouldn't the swap chain Present method block the CPU in this case ?
4) Should I expect this approach to be more efficient than the one managed by the driver ? I don't have meaningful profile data yet.
Is anybody familiar with the approach described above and can answer my questions and discuss the pros and cons of this technique based on his experience ?
For reference, I've uploaded the (WIP) allocator code at https://paste.ofcode.org/Bq98ujP6zaAuKyjv4X7HSv.  Feel free to adapt it in your engine and please let me know if you spot any mistakes
Thanks
Stefano Lanza

• 20
• 14
• 12
• 10
• 12