activity = new Idle(this, NULL);

class Idle : public Activity

{

private:

    float mTimeInIdle;



public:

    Idle() : mTimeInIdle(0)    { }

    Idle(Objects *actor, Goods *target) : Activity(actor, target)

    {



    }

Error 1 error C2514: 'Idle' : class has no constructors d:\jacky\documents\visual studio 2010\projects\perfectsim\perfectsim\perfectsim\Objects\Objects.h 43 1 PerfectSim

The activity = new Idle(this, NULL) line is located inside the Objects::Objects(...) constructor.

Would it be caused by some cyclic dependencies? How do I go about resolving it?

Thanks

Jack

I put everything inside header files. like Objects.h and Idle.h

#pragma once

#include "..\SkinnedMesh\skinnedMesh.h"
#include "..\Activities\Activity.h"
#include "DetourNavMeshQuery.h"
#include "MotiveBase.h"

//#include "..\myDX9Widget.h"

class myDX9Widget;
class Idle;

class Objects
{
public:
    Objects() : m_pAnimCtrl(0), energy(0) { }

    Objects(SkinnedMesh* _mesh) : m_pAnimCtrl(0)
    {
        SetPos(D3DXVECTOR3(0,0,0));
        SetRot(D3DXVECTOR3(0,0,0));
        SetRotCenter(D3DXVECTOR3(0,0,0));
        SetScale(D3DXVECTOR3(1,1,1));
        SetScaleCenter(D3DXVECTOR3(1,1,1));

        D3DXQUATERNION quat;
        D3DXQuaternionIdentity(&quat);

        SetRotQuat(quat);
        
        
        if (_mesh->GetMasterAnimCtrl() != NULL)
        {
            _mesh->GetMasterAnimCtrl()->CloneAnimationController(
            _mesh->GetMasterAnimCtrl()->GetMaxNumAnimationOutputs(),
            _mesh->GetMasterAnimCtrl()->GetMaxNumAnimationSets(),
            _mesh->GetMasterAnimCtrl()->GetMaxNumTracks(),
            _mesh->GetMasterAnimCtrl()->GetMaxNumEvents(),
            &m_pAnimCtrl);
        }
        

        activity = new Idle(this, NULL);
        
        mesh = _mesh;
    }

Now that I've included Idle.h in Objects.h

so that Objects should see everything in idle, that's point 1

Point 2, idle can't see everything in Objects. So I forward declare it, otherwise, I have a circular references, Objects->Idle and Idle->Objects

How do I make Idle see Objects so I won't get the following errors:

Error 1 error C2027: use of undefined type 'Objects' d:\jacky\documents\visual studio 2010\projects\perfectsim\perfectsim\perfectsim\Activities\Idle.h 29 1 PerfectSim
Error 3 error C2027: use of undefined type 'Objects' d:\jacky\documents\visual studio 2010\projects\perfectsim\perfectsim\perfectsim\Activities\Idle.h 33 1 PerfectSim
Error 10 error C2027: use of undefined type 'Objects' d:\jacky\documents\visual studio 2010\projects\perfectsim\perfectsim\perfectsim\activities\Idle.h 29 1 PerfectSim

You can break the circular dependency if you split your implementation and declaration into .cpp and .h-files

Only declare the classes in the header-files, no method implementations.

You can have only a forward declaration in the .h-file if you only have pointers to the classes in the .h-file

Then include the full header in the cpp-file to be able to call its methods.

I put everything inside header files.

Please do a quick check on my coding

Activity.h

#include <string>
 

class Idle;
class Objects;
class Goods;

class Activity
{
public:
    Objects *Actor;
    Goods *Target;
    Activity() : Actor(0), Target(0) { }
    Activity( Objects* actor, Goods* target )
    {
        Actor = actor;
        Target = target;
    }

    virtual bool OnUpdate(float seconds) = 0;

    void Update(float seconds);
    

    Activity *FindBestActivity(Objects *actor);
    
    std::string ToString();

};

Idle.h

#include "Activity.h"
 
 
 

#define MAX_IDLE_TIME 8
#define ACTIVITY_IDLE_ENERGY 1.0

class Objects;
class Activity;

class Idle : public Activity
{
private:
    float mTimeInIdle;

public:
    Idle() : mTimeInIdle(0)    { }
    Idle(Objects *actor, Goods *target);

    bool OnUpdate(float seconds);
    

};

idle.cpp

#include "Idle.h"

 

Idle::Idle(Objects* actor, Goods *target) : Activity(actor, target)
{

}

bool Idle::OnUpdate(float seconds)
{

    mTimeInIdle += seconds;
    if (mTimeInIdle >= MAX_IDLE_TIME)
    {
        Actor->activity = FindBestActivity(Actor);
    }


    Actor->energy += ACTIVITY_IDLE_ENERGY * seconds;
    return false;
}

Error 1 error C2027: use of undefined type 'Objects' D:\Jacky\Documents\Visual Studio 2010\Projects\PerfectSim\PerfectSim\PerfectSim\Activities\Idle.cpp 16 1 PerfectSim
Error 3 error C2027: use of undefined type 'Objects' D:\Jacky\Documents\Visual Studio 2010\Projects\PerfectSim\PerfectSim\PerfectSim\Activities\Idle.cpp 20 1 PerfectSim
Error 2 error C2227: left of '->activity' must point to class/struct/union/generic type D:\Jacky\Documents\Visual Studio 2010\Projects\PerfectSim\PerfectSim\PerfectSim\Activities\Idle.cpp 16 1 PerfectSim
Error 4 error C2227: left of '->energy' must point to class/struct/union/generic type D:\Jacky\Documents\Visual Studio 2010\Projects\PerfectSim\PerfectSim\PerfectSim\Activities\Idle.cpp 20 1 PerfectSim

I've moved everything into implementation file. Here now are what I've got.

Thanks

From quickly glancing over it the problem seems to be the obvious failure to include Activity.h in Idle.cpp.

From quickly glancing over it the problem seems to be the obvious failure to include Activity.h in Idle.cpp.