Back to For Beginners

A quick question, about encapsulation

For Beginners

Started by Concentrate January 10, 2012 10:03 PM

1 comment, last by return0 12 years, 3 months ago

Concentrate

181

Author

January 10, 2012 10:03 PM

I have a IChessPIece class that encapsulates an sf::Sprite. sf::Sprite has its own interface. Would it be a better idea to have IChessPiece create a interface where it delegates its job to sf::Sprite, or would it be better to just returned sf::Sprite by reference? For example,



class IChessPiece{

 void animateTo(...);

 void showPossibleMoveLoaction(GameBoard& board);



 sf::Sprite getSprite()const{ return m_sprite; }

 sf::Sprite getSprite()const{ return m_sprite; }

public:

 sf::Sprite m_sprite;

 enum { PAWN, KNIGHT, ... };

};





class IChessPiece{

 void animateTo(...);

 void showPossibleMoveLoaction(GameBoard& board);



 void setLocation(..){ m_sprite.SetLocation(...); }

 void setSize(...){ m_sprite.SetSize(...); }

 //.. and so on

public:

 sf::Sprite m_sprite;

 enum { PAWN, KNIGHT, ... };

};

Or maybe a possible combination of the two to make it easier on the user? All works, I guess, but just seeing what you guys thought about it.

Edge cases will show your design flaws in your code!
Visit my site
Visit my FaceBook
Visit my github

swiftcoder

18,997

January 10, 2012 10:21 PM

The first. You should be composing, not encapsulating here - there is no reason why IChessPiece should have to wrap all the methods of the Sprite class.

Tristam MacDonald. Ex-BigTech Software Engineer. Future farmer. [https://trist.am]

return0

508

January 11, 2012 01:35 AM

That type looks confused, is it a model or a viewmodel?

Can't figure out how to edit on phone screen, hit post by accident, meant to add it's mixing MVVM concerns.

When will a decent mobile version of this site be available, like the old one?

return0

508

January 11, 2012 01:39 AM

Can't figure out how to edit on phone screen, hit post by accident, meant to add it's mixing MVVM concerns.

When will a decent mobile version of this site be available, like the old one?

A quick question, about encapsulation

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

A quick question, about encapsulation

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines